From patchwork Mon Feb 6 17:03:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 18257 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 41ACDC329C for ; Mon, 6 Feb 2023 17:04:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0079B625FD; Mon, 6 Feb 2023 18:04:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1675703044; bh=RiAibVoMVJWWjNmCK3UmaB/yHa779zjqdmV1+13l7TM=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=dvq0goepW2cTw4Cn+OrZ9NsBouqRLcLv67nZlwcBayYLeLcIpN8HupJge30CtjA3w sTZKjKiVZ5KqYrOZJRhn0Ow4Pa0xz1pORKBruQBbymdbWx/HuxRW3SBgUyvkGotR8I aEuK0QJktvaaIKBpLima5MXGP08NpNbny4ugtHTTRhg6o8LErwAtYP6NEWQ/UEfumc z9tM6z/ePS883OosvO+UpPXqgTqi7A3rDspNJ7npEliQfWTvblOTKry6/qcW0H1ijt U67COZP/aGWdF1bY5Ple7sDpAuaLbToNOnsniy66bTgX+iEPmnxhD51XBtpInZXXjU SQ+Eisu8RESMQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6960E625FF for ; Mon, 6 Feb 2023 18:04:02 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Vr2wJo1U"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (unknown [109.136.43.56]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D1AEF4DA for ; Mon, 6 Feb 2023 18:04:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1675703042; bh=RiAibVoMVJWWjNmCK3UmaB/yHa779zjqdmV1+13l7TM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Vr2wJo1UiDWLGO85NB6O0nqk142zZYBxz3gS9xIVgfY4yCDEklXwffvK2ddtGDiqR GuoX02DYuDnGpgclobnod4EfdWIydAlUIDhL+CB+bn5wwvyVZOr6ozRi2r2KrQFjFM GB4CySyMRICTvCcc53MFwgRH/ey2aKZzYNI/aoIk= To: libcamera-devel@lists.libcamera.org Date: Mon, 6 Feb 2023 19:03:55 +0200 Message-Id: <20230206170356.20340-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230206170356.20340-1-laurent.pinchart@ideasonboard.com> References: <20230206170356.20340-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 3/4] pipeline: ipu3: Drop unused code X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Commit 1a614866a29c ("libcamera: camera_sensor: Validate Transform") has removed usage of the IPU3CameraData::rotationTransform_ but hasn't removed the field itself, nor its initialization. Drop those as they're unused. Fixes: 1a614866a29c ("libcamera: camera_sensor: Validate Transform") Signed-off-by: Laurent Pinchart Reviewed-by: Umang Jain --- src/libcamera/pipeline/ipu3/ipu3.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 3a569c7e0031..355cb0cb76b8 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -73,7 +73,6 @@ public: Stream rawStream_; Rectangle cropRegion_; - Transform rotationTransform_; std::unique_ptr delayedCtrls_; IPU3Frames frameInfos_; @@ -1101,13 +1100,6 @@ int PipelineHandlerIPU3::registerCameras() << cio2->sensor()->id() << ". Assume rotation 0"; - int32_t rotationValue = rotation.value_or(0); - bool success; - data->rotationTransform_ = transformFromRotation(rotationValue, &success); - if (!success) - LOG(IPU3, Warning) << "Invalid rotation of " << rotationValue - << " degrees: ignoring"; - /** * \todo Dynamically assign ImgU and output devices to each * stream and camera; as of now, limit support to two cameras