[libcamera-devel,v1,1/4] libcamera: camera_sensor: Demote flip support message to Debug
diff mbox series

Message ID 20230206170356.20340-2-laurent.pinchart@ideasonboard.com
State Accepted
Commit fb344abda93cdf6f459a71d9829fcf4777a1284a
Headers show
Series
  • Misc fixes for transformation handling
Related show

Commit Message

Laurent Pinchart Feb. 6, 2023, 5:03 p.m. UTC 
The CameraSensor::validateSensorDriver() function prints a Warning
message when the camera sensor doesn't support flips. We don't mandate
flip support and can run without it without any problem, so a warning is
too harsh. Demote it to a Debug message.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/camera_sensor.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Umang Jain Feb. 8, 2023, 10:25 a.m. UTC | #1 
Hi Laurent,

Thank you for the patch

On 2/6/23 10:33 PM, Laurent Pinchart via libcamera-devel wrote:
> The CameraSensor::validateSensorDriver() function prints a Warning
> message when the camera sensor doesn't support flips. We don't mandate
> flip support and can run without it without any problem, so a warning is
> too harsh. Demote it to a Debug message.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   src/libcamera/camera_sensor.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
> index b772337eb44a..11117502d817 100644
> --- a/src/libcamera/camera_sensor.cpp
> +++ b/src/libcamera/camera_sensor.cpp
> @@ -261,7 +261,7 @@ int CameraSensor::validateSensorDriver()
>   		supportFlips_ = true;
>   
>   	if (!supportFlips_)
> -		LOG(CameraSensor, Warning)
> +		LOG(CameraSensor, Debug)
>   			<< "Camera sensor does not support horizontal/vertical flip";
>   
>   	/*

Patch
diff mbox series 

diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
index b772337eb44a..11117502d817 100644
--- a/src/libcamera/camera_sensor.cpp
+++ b/src/libcamera/camera_sensor.cpp
@@ -261,7 +261,7 @@  int CameraSensor::validateSensorDriver()
 		supportFlips_ = true;
 
 	if (!supportFlips_)
-		LOG(CameraSensor, Warning)
+		LOG(CameraSensor, Debug)
 			<< "Camera sensor does not support horizontal/vertical flip";
 
 	/*