[libcamera-devel,v2,3/4] ipa: rkisp1: Add OV4689 tuning file
diff mbox series

Message ID 20230123140619.177878-4-mike.rudenko@gmail.com
State Accepted
Headers show
Series
  • Add Omnivision OV4689 support
Related show

Commit Message

Mikhail Rudenko Jan. 23, 2023, 2:06 p.m. UTC 
Add a minimal tuning file for Omnivision OV4689, specifying black
level subtraction level.

Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
---
 src/ipa/rkisp1/data/meson.build |  1 +
 src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++
 2 files changed, 14 insertions(+)
 create mode 100644 src/ipa/rkisp1/data/ov4689.yaml

Comments

Jacopo Mondi Jan. 24, 2023, 5:28 p.m. UTC | #1 
Hi Mikhail

On Mon, Jan 23, 2023 at 05:06:18PM +0300, Mikhail Rudenko wrote:
> Add a minimal tuning file for Omnivision OV4689, specifying black
> level subtraction level.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
> ---
>  src/ipa/rkisp1/data/meson.build |  1 +
>  src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++
>  2 files changed, 14 insertions(+)
>  create mode 100644 src/ipa/rkisp1/data/ov4689.yaml
>
> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
> index c3b4e388..f5e9fa75 100644
> --- a/src/ipa/rkisp1/data/meson.build
> +++ b/src/ipa/rkisp1/data/meson.build
> @@ -2,6 +2,7 @@
>
>  conf_files = files([
>      'imx219.yaml',
> +    'ov4689.yaml',
>      'ov5640.yaml',
>      'uncalibrated.yaml',
>  ])
> diff --git a/src/ipa/rkisp1/data/ov4689.yaml b/src/ipa/rkisp1/data/ov4689.yaml
> new file mode 100644
> index 00000000..2068684c
> --- /dev/null
> +++ b/src/ipa/rkisp1/data/ov4689.yaml
> @@ -0,0 +1,13 @@
> +# SPDX-License-Identifier: CC0-1.0
> +%YAML 1.1
> +---
> +version: 1
> +algorithms:
> +  - Agc:
> +  - Awb:
> +  - BlackLevelCorrection:
> +      R:  66
> +      Gr: 66
> +      Gb: 66
> +      B:  66

Oh great, you've measured them!
Thanks!

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> +...
> --
> 2.39.1
>

Patch
diff mbox series 

diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
index c3b4e388..f5e9fa75 100644
--- a/src/ipa/rkisp1/data/meson.build
+++ b/src/ipa/rkisp1/data/meson.build
@@ -2,6 +2,7 @@ 
 
 conf_files = files([
     'imx219.yaml',
+    'ov4689.yaml',
     'ov5640.yaml',
     'uncalibrated.yaml',
 ])
diff --git a/src/ipa/rkisp1/data/ov4689.yaml b/src/ipa/rkisp1/data/ov4689.yaml
new file mode 100644
index 00000000..2068684c
--- /dev/null
+++ b/src/ipa/rkisp1/data/ov4689.yaml
@@ -0,0 +1,13 @@ 
+# SPDX-License-Identifier: CC0-1.0
+%YAML 1.1
+---
+version: 1
+algorithms:
+  - Agc:
+  - Awb:
+  - BlackLevelCorrection:
+      R:  66
+      Gr: 66
+      Gb: 66
+      B:  66
+...