[libcamera-devel,v2,0/4] Add Omnivision OV4689 support
mbox series

Message ID 20230123140619.177878-1-mike.rudenko@gmail.com
Headers show
Series
  • Add Omnivision OV4689 support
Related show

Message

Mikhail Rudenko Jan. 23, 2023, 2:06 p.m. UTC 
Hi,

this is second revision of OV4689 support series. In this revision
I've tried to adress all of Jacopo's comments. Specifically, I've done some
experimentation concerning the black level.

When capturing raw SBGGR10 frames with exposition and gain manually
set to minimum and the lens lid closed, pixel values randomly
fluctuate between 16 and 17. This corrsponds to 64-68 for
BlackLevelCorrection. I have also found that setting it to 66 is right
enough to have all zeros in XRGB8888 frames, so I've updated the
tuning file accordingly.

Changes in v2:
- collect R-b for [1/4]
- expose TestPatternModeColorBarsFadeToGray to libcamera
- use black level correction value of 66 (found experimentally)

Mikhail Rudenko (4):
  ipa: camera_sensor_helper: Add OV4689 support
  libcamera: camera_sensor: Add OV4689 sensor properties
  ipa: rkisp1: Add OV4689 tuning file
  ipa: rkisp1: Raise maximum analogue gain

 src/ipa/libipa/camera_sensor_helper.cpp    | 11 +++++++++++
 src/ipa/rkisp1/algorithms/agc.cpp          |  2 +-
 src/ipa/rkisp1/data/meson.build            |  1 +
 src/ipa/rkisp1/data/ov4689.yaml            | 13 +++++++++++++
 src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++
 5 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 src/ipa/rkisp1/data/ov4689.yaml

--
2.39.1