From patchwork Mon Jan 23 14:06:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18170 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 47FF5BEFBE for ; Mon, 23 Jan 2023 14:06:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 834B7625DF; Mon, 23 Jan 2023 15:06:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674482793; bh=8xt7OALZsy0JxqBamJRcBSUsrkVyFxG06M5Sr62G21Y=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=323Vf4JE7cr4Wtkr5MfTTYeTjx7lImlPRpb67+v9PkkQDuj2oFHo2oVJyj5Zmwfmj tz9/KBQbBR3hKqcjpHKRJDsk7j7AefBtpqk1xpSsH8CHjfh0w/UxDTIBu0Oqq67XRs o5MoNLePGgkFsjml62kHk5C8qa1h1ixXN3WEUBaaPbCJNHcTr9/xhCEpnrerh2Wam9 oE5JEgU/mANSGxVoqBLQ6HlZsYDySnYRGjDSEQr0oqkGnKAEi/U/7LD4dB9YEqNDQD A18sAqg1WUwfJAn4VKyPsJn/2tSA1rGuWgGq1GyGPD5NJc7TsqJYzr3OaAk8a6HZx7 CRRg+4PXoNCDA== Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 74807603C7 for ; Mon, 23 Jan 2023 15:06:31 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="P+fFficV"; dkim-atps=neutral Received: by mail-lf1-x134.google.com with SMTP id cf42so18369442lfb.1 for ; Mon, 23 Jan 2023 06:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2k+n3ZopC4qF6yHHkrucbsHaQtBAdY4Ln+AdHoKDKH0=; b=P+fFficVz1eqRyMTgMbWEyorC/0fHHq4MTQPi3jeQgyjPXCJm4zDCupwwMusCwAhns e3264aGaGxWuXSV2AkMox+rLgCd0r6Cb14R3KWA9b+xCnmRNpjza3DBpqfNPqzYEQdaS 2nxVRXqzWNiDX8zHcgVjmn38qeXXBCLlzZtebcL3t1vFZqcA3k2fzdJNkciw0jr9KZVY 4PGAAAUvlhV1PCTQIEAFqfqxxiX4IgLKE2hMnSJXUedR9WIeDuTUAv7MQdBG8KSFrTVb Z2d5us8DdfpOwNoxwzMrZmkNOHVmUEhjcT27g1QNKM3mdNuodhLLoVQLzEc2Xu401Bct M2vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2k+n3ZopC4qF6yHHkrucbsHaQtBAdY4Ln+AdHoKDKH0=; b=XC5YGc8TI9QO8Ez0rohUXFZjDatd/zRuhdF1zoqcJ8ulSAnPCWDRVFCL4J0w9P4NEQ 0OTfkJsOMHM1yPbSY79VQYsxMjhN7/REuXyrtSlwGsbhVO102bls90CVnzTaixHzSoZa P/6L6FuRwwrQp8sbgnR6NI7caOTWmvBgZcqBscqRQkI7udiurXSKU4SbzPVRHOPeWjyE 9v7Gvtq0ORiIVyoWCpP493XcIRYthfp7Pg6SxXR6yQ1q1D4gTjTNRZ1XZJ9fa1MSE8h9 wGQMowQrfOXl6gkhfBEaozU7KVSjr+c9QLGhwmsAKVclEPNUuAlt/d+TIRGyWeCBNkcc Bmqg== X-Gm-Message-State: AFqh2koLqcknjoCK57cTahG0TVaSSbV51ynYAbnw0Q2UsUtaYbo5JTuv CztfewiAv1FV4QN3T5Gj8sSaYoCCAQg= X-Google-Smtp-Source: AMrXdXuKZZRPM6mbfTVB4sDcn2nrWSww22hU/AGmWuz4/V6JiLUykCufGIqvuGhCvg4OfVRwHGoapg== X-Received: by 2002:a05:6512:2216:b0:4cd:47e:47a9 with SMTP id h22-20020a056512221600b004cd047e47a9mr7577549lfu.58.1674482789883; Mon, 23 Jan 2023 06:06:29 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id u15-20020a05651c130f00b0028b756197d1sm2983095lja.17.2023.01.23.06.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 06:06:29 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Mon, 23 Jan 2023 17:06:15 +0300 Message-Id: <20230123140619.177878-1-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/4] Add Omnivision OV4689 support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, this is second revision of OV4689 support series. In this revision I've tried to adress all of Jacopo's comments. Specifically, I've done some experimentation concerning the black level. When capturing raw SBGGR10 frames with exposition and gain manually set to minimum and the lens lid closed, pixel values randomly fluctuate between 16 and 17. This corrsponds to 64-68 for BlackLevelCorrection. I have also found that setting it to 66 is right enough to have all zeros in XRGB8888 frames, so I've updated the tuning file accordingly. Changes in v2: - collect R-b for [1/4] - expose TestPatternModeColorBarsFadeToGray to libcamera - use black level correction value of 66 (found experimentally) Mikhail Rudenko (4): ipa: camera_sensor_helper: Add OV4689 support libcamera: camera_sensor: Add OV4689 sensor properties ipa: rkisp1: Add OV4689 tuning file ipa: rkisp1: Raise maximum analogue gain src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ src/ipa/rkisp1/algorithms/agc.cpp | 2 +- src/ipa/rkisp1/data/meson.build | 1 + src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++ src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++ 5 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 src/ipa/rkisp1/data/ov4689.yaml --- 2.39.1