From patchwork Mon Jan 23 14:06:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18171 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5C4B4C3240 for ; Mon, 23 Jan 2023 14:06:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 15FA2603C7; Mon, 23 Jan 2023 15:06:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674482794; bh=KMABLFjid9EFNgT0+w8BwYI3v5aolFGaBwVRaDyKrtQ=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WFxTKuXfI9IRY1nR7iQfh1bgyYXD+mVpzTG4IVSPgCbVFN2EvsKhNsAbJdmNc9Lza fXGGA0LIAeQIJdTErDbISiINwyUCaW8UJ64chA7vfSNCCQPPYqE/OpO/8MC19cr4JT thDYHfY1qoOzSWvgLxYlg8ytsoxas8yaavTUXBuaMtqyzbHry1VqJPjS+c7Y+aA+XP lt5s4cxw0HAzVKiiCUDbgoPpzBJK+TdIM9mOm3Z89+eCmGDOj6AJIhgVpYubtx02TS Bmwjl6cn/nJ2bEE4TB79OSDyaityIoG8iEhVnW+WpK5vgur1Pf4e9iehMOf5XB7txR LDtlWO8B5wU2Q== Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B8E88603C7 for ; Mon, 23 Jan 2023 15:06:32 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qrPHWnrZ"; dkim-atps=neutral Received: by mail-lf1-x134.google.com with SMTP id f34so18314855lfv.10 for ; Mon, 23 Jan 2023 06:06:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7/fILwPrw1ukzSO0LHL3gmP/gNaQQ5z2ToLa7FXm+Ts=; b=qrPHWnrZzKlRhdjJsfBwV+eyOglrzdhqQvip3mzDwbDXouPS5RW02Y9TRNe/zj+v4C gHAbAVh4N5JmnEH5/l6xqnYKp61jM462BzbHkB7VRuXlZsAY9iQFD2lObG3sbsWITuNI MbKyjHHGgLrwfLOUHQZKSAKtEIrfOQloouMZwp+y6Z5E1TM8dPHcp1vZXI3BZjRuuYm2 QK3FsU4VE44srx8NuR5iiKF53R/TcPWwJHGZ5qto1snjZo+6R48kN1uncLyEmjZP7rMJ xoeJdHF8jGtG+Wy2BaNVHT5Twy7VKVRxH3qv+lgQG2ZpbFeOV8hhQkNdTuyTdrzBckyA JJ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7/fILwPrw1ukzSO0LHL3gmP/gNaQQ5z2ToLa7FXm+Ts=; b=KQhWkidubFJBpl1sjqU0be7RlGI224fUtauqmAqHO65nNH85303Adbuk5s/NaqjXjI rKwZvyarxm3UKY3x61/6REGJFZAk5CJ7VZrWs89ROT0ZLtEExkP6Wv7Aj1x4l+tqU1Pq mNAh6wCjRU4q9qVByiLni7LG4zHHPEhe+kI43ojkRXTJSKKDTQpPBlSwfUVT9v1jLT40 TFIxasH8UFRJTGhDeXOlpjaQDV3DkOvpOUixV9sJc98ZKwXB6Li2uFLsJuHkGVe7lyhY UpSVR+rknK2LYZpr7FJWOCHi63TMwZ8oQD0yqgaqAtIcRY2vCGvbsvnEpgtOnzZBSazy 2GMA== X-Gm-Message-State: AFqh2kpFHmS+idcxCANAhNp7l/mFQQO3aY5OlbcdqWOAt13lYaRxvBwk GTiwUJXi5qGzIDq8E3JzyTbpFSR1APTawg== X-Google-Smtp-Source: AMrXdXtKS0qoMArLiX4kCzauMK/RWu9DcWFE2XXZIbYA4HQR8Tk6ww37uUN5nGw0DT0Kv73hBHP7Vg== X-Received: by 2002:a05:6512:304a:b0:4d5:2132:8187 with SMTP id b10-20020a056512304a00b004d521328187mr8969266lfb.43.1674482791606; Mon, 23 Jan 2023 06:06:31 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id cf37-20020a056512282500b004d254939bebsm2751816lfb.305.2023.01.23.06.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 06:06:30 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Mon, 23 Jan 2023 17:06:16 +0300 Message-Id: <20230123140619.177878-2-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123140619.177878-1-mike.rudenko@gmail.com> References: <20230123140619.177878-1-mike.rudenko@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/4] ipa: camera_sensor_helper: Add OV4689 support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Jacopo Mondi , Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add support for Omnivision OV4689 image sensor to libipa. The sensor implements a linear gain equation with analogue gain control values 0-2047 corresponding to 0x-16x physical gain range. Reviewed-by: Jacopo Mondi Signed-off-by: Mikhail Rudenko --- src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 3d8a2835..075c568e 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -461,6 +461,17 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("ov2740", CameraSensorHelperOv2740) +class CameraSensorHelperOv4689 : public CameraSensorHelper +{ +public: + CameraSensorHelperOv4689() + { + gainType_ = AnalogueGainLinear; + gainConstants_.linear = { 1, 0, 0, 128 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("ov4689", CameraSensorHelperOv4689) + class CameraSensorHelperOv5640 : public CameraSensorHelper { public: From patchwork Mon Jan 23 14:06:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18172 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3E2F8BEFBE for ; Mon, 23 Jan 2023 14:06:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C5F2D625E8; Mon, 23 Jan 2023 15:06:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674482796; bh=9/+GpQsH5Q+g3WCQBOPnk4BSrR5lIyHPYUt/t3HcENU=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OGsOMk5g5hXfYNLU2ORnkLLkBzMtOVmDgNJiR8KU6B/q3d9QFMMium4ya6EylufJ/ x34CF8gvKQqrCqZWfchxUHzRxylC1cK1bqGyN98VwtP2OLX7yc3RZLOIVWTabLsHue zq4oVrwEAENONncYbp83OBeiLgURiUgLFz7p6Vdp74jPy0gmk8ypb0UM/0mhX0ns5w ZO4xDPfnB9sf3VSv4Bw3cs3pBJXccw93ksNi5nrS6wkV/O8sDWiB/go/E6mqVEVTUa HwHC35Eret3O3H45ZtDRp5GCDyuN9tJ1BWpxIw0WZ+ViCcJQAxDAbLyNmRTTEMcEFP xuYGGkINZZ3+w== Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 37E60625E4 for ; Mon, 23 Jan 2023 15:06:34 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SY226GC9"; dkim-atps=neutral Received: by mail-lf1-x12e.google.com with SMTP id bp15so18270662lfb.13 for ; Mon, 23 Jan 2023 06:06:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=si24NKlxe7UrLVtQFXtacsPFQ0AE28HmQ/K2/7pcEbI=; b=SY226GC9ajePrgNb1mUZxIBgiVAtrxFcE9a8PQZSEq3oMIBSvghHOFQlqOgCscDURB +sigALEF9w90+U1kYZd/bNER+Fp1Qs4I/QaPfjlbphEv/9YLreWd+780SgHYhtwhfVpm SN9KLauNzDY8nsUV9zM9ewNEpYpOyCnEi5FlM2MOz9BZEvMEB19g5Gkz5By9zhXa6IUv 0kzy5253UHIcJhUJg6bwr+QK6S5xt7+KJfvVi6aL8Kkr5PPeB1T7OeXUjCc8iZqBj/4g 2+ke3ONz6caWK7AUCLlMeAHdo+pQrAxkgmszAWMav3HFZqFq2hJFsKCzZB1sOKS/XwUP Majg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=si24NKlxe7UrLVtQFXtacsPFQ0AE28HmQ/K2/7pcEbI=; b=EppXPicuEgwVTTR4wJoGgo9zQxFhC5tYu7QzBE1YtbnZdKFxghawcmPvwVNWMuR697 twBApX/4B0Zw2UPSj5Uidta70hTDA8bewBVDsDZgqCapEV7q8uFXoeGNqChBXGXYRsM0 9e6puiJAfdSsb8hfDkXEw+PxgTJBe712QWn1VHrIwSp7SlC14PTVMJW9ukc26rXpU192 lpJYdIUwi6iAvnmS7HPfn6Ix3R+7ak4DnLFWilEV/k4+SS1+amHxqRB8eOjagQiAscFQ vuF6XoLGXcs3QRaURqmWSydWjcnlRrDIEosxMTlVTcGUEkKYk1cPMBaQ4YmwnlS3wQmP VapQ== X-Gm-Message-State: AFqh2koS00LqgU21XquxMHussM69dmXmy7UrRRx8z45rFrk/TOv5R/pp 74cTr0/sE0RILKC9Ak3v3ilIVmHQits= X-Google-Smtp-Source: AMrXdXvvZvm8EK9Bt1fW4VYO1V1Gk8Upnh45hB2M8woK/Zh8Uq0gljpLp9G4E5xUjeGzgYmLDhQtKA== X-Received: by 2002:ac2:5151:0:b0:4d2:105e:c164 with SMTP id q17-20020ac25151000000b004d2105ec164mr5768683lfd.7.1674482793159; Mon, 23 Jan 2023 06:06:33 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id y29-20020a0565123f1d00b004ac980a1ba1sm6551771lfa.24.2023.01.23.06.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 06:06:32 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Mon, 23 Jan 2023 17:06:17 +0300 Message-Id: <20230123140619.177878-3-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123140619.177878-1-mike.rudenko@gmail.com> References: <20230123140619.177878-1-mike.rudenko@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 2/4] libcamera: camera_sensor: Add OV4689 sensor properties X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add an entry to the sensor properties for Omnivision OV4689. Kernel supports two more types of color bars patterns, which we do not expose now. Signed-off-by: Mikhail Rudenko Reviewed-by: Jacopo Mondi --- src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp index c3c2cace..a601e1ae 100644 --- a/src/libcamera/camera_sensor_properties.cpp +++ b/src/libcamera/camera_sensor_properties.cpp @@ -130,6 +130,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen { controls::draft::TestPatternModeColorBars, 1}, }, } }, + { "ov4689", { + .unitCellSize = { 2000, 2000 }, + .testPatternModes = { + { controls::draft::TestPatternModeOff, 0 }, + { controls::draft::TestPatternModeColorBars, 1}, + { controls::draft::TestPatternModeColorBarsFadeToGray, 2}, + /* + * No corresponding test patterns in + * MIPI CCS specification for sensor's + * colorBarType2 and colorBarType3. + */ + }, + } }, { "ov5640", { .unitCellSize = { 1400, 1400 }, .testPatternModes = { From patchwork Mon Jan 23 14:06:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18173 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C6134C3240 for ; Mon, 23 Jan 2023 14:06:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7EF2F625E4; Mon, 23 Jan 2023 15:06:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674482798; bh=FvW5zI0lM7JUCrLm6yPlhCEA0aOMpBzEhefl/XFA9nc=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=x0z+N/QsGRREdOcwtec/3zikLgVpZM9a6ZCmbztA1eLPL3prx3SPH0MWdSnPDjBSA Z46T0cIq2lo1r+TbXgzOKL7PymfCvf6gVdLA+lUqhfPFWOlb0J39f1J5DW0/67fNhg Y05ZGQ9N6lfTX9VrMig5SwnDeg9fANFMGxsGJnrtGsUrkA2Da5HaMfFTsQ/AFgQAj9 AIuey7dqEq9ZaaOpO0kN3TiF6zBbAC73MS/++65EVvZwzMfEO3V4JDUJ7xQGXnCfgp F5K8q0mxNYtPbkMgsPNnQlYoS1peGcQqd7cjAHLiUkLu3cxX0ZkyIgf9BRd/g9onpm revh3+jv+N7zQ== Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 68163625D8 for ; Mon, 23 Jan 2023 15:06:35 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YcuRF9+K"; dkim-atps=neutral Received: by mail-lj1-x22b.google.com with SMTP id t12so5630554lji.13 for ; Mon, 23 Jan 2023 06:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oPqbqfftDnvYF8xe/8IiYcARFnW7jHPwTsYWz4csyYM=; b=YcuRF9+KDQey3lCILa57bNsMbN1fDJJ6S4WJrm2Gqjqiylgst22JHbvtOb1x+MONQ5 2PUDVMSgJgo9EKAD5L6qeVgLgxI/sYLHm2eL57LLH3fWCYb1hGYPhcZrSjdC6MrYUt+7 qgDItOFJ+wLiDVEFilu1OKShXsveMLtZ+yjGbS2vgHs27i3Lb7FYPnXFt4WiSEK1NC32 6S7OOqA9SuwOejAh1yAzL5VmONb27h2AbmhuO+IttT7e7NWTMfCkSixoU51NfqxGSFXv ZYdjBP6c0Z4dKTdPZHB1UBhpoKkbI1nHj8qQ/njS1GuTEe6W7IysLcqMua4pgmM2RzIj tXYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oPqbqfftDnvYF8xe/8IiYcARFnW7jHPwTsYWz4csyYM=; b=kPngmeS2E0ylEuNRxOU8zIQygZvTQSmdj5NiLIgRxHQP4Gl7cUL8Fa6OhwIWyFGKzg SRmEn3olj65o3i8ImIUmE1mZnQaj9UAn4zLgBPCeG/gzK2EdFdwOqxLMde55SoSy8ED3 sQqO7eiSne7TSng/9a9Iy5pJFGwJd12R6s9DUJOSgIFprkEHxsyi0+btdnoiSBSwpNSm t2Qkf0pQFjRJbKTzmCCFdk5SEFfA0XZROroE7A0QaP1NwuzKGM0XUfq4He7YobErmqx0 665MClSEgTOaoHj+PynRa5oZq3sfeAeFXQhL3FO8YS849qvWxoZfc9phEYsCj+1OCMpA AeFw== X-Gm-Message-State: AFqh2krfWlzSe0AY03aXdtOteCAZEhSM2y+AoEL/2fMel5F+iZ/ZheeB 5sV2e5MuTyRe614Qo4NaRBO0jYpdr3M= X-Google-Smtp-Source: AMrXdXsuVtDQfawe9EO0ql7uZWNONZzNg7cgjQFQ0npzqtDYw2aV5jZxFk2Aiqwc33QPpvSGmhD8fA== X-Received: by 2002:a05:651c:b27:b0:285:61a1:d0db with SMTP id b39-20020a05651c0b2700b0028561a1d0dbmr7946204ljr.53.1674482794437; Mon, 23 Jan 2023 06:06:34 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id w29-20020a0565120b1d00b004b6e9530900sm6478947lfu.110.2023.01.23.06.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 06:06:34 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Mon, 23 Jan 2023 17:06:18 +0300 Message-Id: <20230123140619.177878-4-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123140619.177878-1-mike.rudenko@gmail.com> References: <20230123140619.177878-1-mike.rudenko@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 3/4] ipa: rkisp1: Add OV4689 tuning file X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add a minimal tuning file for Omnivision OV4689, specifying black level subtraction level. Signed-off-by: Mikhail Rudenko Reviewed-by: Jacopo Mondi --- src/ipa/rkisp1/data/meson.build | 1 + src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++ 2 files changed, 14 insertions(+) create mode 100644 src/ipa/rkisp1/data/ov4689.yaml diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build index c3b4e388..f5e9fa75 100644 --- a/src/ipa/rkisp1/data/meson.build +++ b/src/ipa/rkisp1/data/meson.build @@ -2,6 +2,7 @@ conf_files = files([ 'imx219.yaml', + 'ov4689.yaml', 'ov5640.yaml', 'uncalibrated.yaml', ]) diff --git a/src/ipa/rkisp1/data/ov4689.yaml b/src/ipa/rkisp1/data/ov4689.yaml new file mode 100644 index 00000000..2068684c --- /dev/null +++ b/src/ipa/rkisp1/data/ov4689.yaml @@ -0,0 +1,13 @@ +# SPDX-License-Identifier: CC0-1.0 +%YAML 1.1 +--- +version: 1 +algorithms: + - Agc: + - Awb: + - BlackLevelCorrection: + R: 66 + Gr: 66 + Gb: 66 + B: 66 +... From patchwork Mon Jan 23 14:06:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18174 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 40C5ABEFBE for ; Mon, 23 Jan 2023 14:06:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EFACB625EF; Mon, 23 Jan 2023 15:06:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674482799; bh=DLekmU5YxUdpDQJaNMa/zEFiFDOu+7zfKc3VjzXgj3I=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=4a9Cmo+l+lCpCAQ2Hioyljlb4TkKjsRONob1ved3iRICy2+tJdIwJEnrkGx+r88Pb iX1HUH3vXYb33Z+7h+zk0MIeE3czXmi9CFn1N79JEKaGszLfDO29aSieoOGQ5lJbAZ VYZvjMzoO2JzWp+0eYQ0/gnS/5OVhUGZSO2rNicXL5y5qcpa9bSRIQtSdhy3vbHwE9 O4Z94qwEwJhq+CsrrBjknMVXTgdGXA1U4EKU3G2ZdtuNr2uKm9gtT1pihN2mkwAdnD 1Y6Txlz3+1O+yE2g144dXy3BuB/gOYPzsCMuajB2ZZJdnqDV0kgDL8gIXY7RJrwUHD G1pZVHuO07Txw== Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A22D7625D8 for ; Mon, 23 Jan 2023 15:06:36 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YVRx/k2Q"; dkim-atps=neutral Received: by mail-lj1-x22e.google.com with SMTP id y18so13186439ljk.11 for ; Mon, 23 Jan 2023 06:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N+q4oXWlN7tVgrlEigWQgWnFoiDOaEvPc0hFBSvDfyE=; b=YVRx/k2QtubRnUjXDoGPztuA64o1KpqQ59yWfDVLMYIEC7NPeXVfNbBTVhjf5OvDBl rH+e8wfxKJ6lEI5RcS87txSOE0EhqJqZEvOu95wCLXlHZDyOaAQomH+JA8HZAF5rZ1Jn ig7PwN/bLC+zsVPn+MIcgDaYZNO4p7CfEJq/nqAof3Hlp0w44Gg7f0KGesDMmgu4KVpt jDbP2annVxpLETQcS25WW4nzqwKVBvSLqxXyjFSJ+Xo2Pskc6j+zS112ROMKZWEcTblc aty15C4WuLE6pyBh4VUr3CPHMbugB8+wjhZ1cyZVD4X4c8XhTSHmYhAI95MC/k3CMb0T 0Swg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N+q4oXWlN7tVgrlEigWQgWnFoiDOaEvPc0hFBSvDfyE=; b=QVbBZUGfGo1eCAVYcPlZ+ly2FlYOPX6vX7E4xcjYc8QwVZKIVzEkTz4ZRIocEpXPqw EBqQqwW/pRBLbF4lLQ/dTpY3r/2oZmqXbcUDZ1bDFuzx4eFkfLyz1J1+9dV0glXO7ixb XVt7X12A0kwuaCAVFRUIflyjuJVqCLcBk8SzoQbiyjhE//tj1yumADqBvGljHvE9I0l7 9DsBOEayh6sAnWQ7BZuzAQE26Rq2x30c/zoDUnpKxOoBWv7RqqY4OUZUxwrGs3ko8Ce9 S8+5xrDzIXAnkp5Qk1Hfr/FSzOB8vL2KZs2PlEO0wNco05iIxbs7KbzbnqFVSq6t+mrb E+HA== X-Gm-Message-State: AFqh2kogmEAekZu4M2xUOCxT6N7VlYn6NqWV2LUNV+skQAmM+piWN6kv cLlkmTudH/ifhocGKL30hpaQooadIkc= X-Google-Smtp-Source: AMrXdXuNvvXc9PpIY08j9oU2ij6DmmcGqLWg7XJVV+8wtkVBaa+G8YQCNw+QeKtLHyOB7H9iR4UZiw== X-Received: by 2002:a2e:bc25:0:b0:27f:bedc:6f09 with SMTP id b37-20020a2ebc25000000b0027fbedc6f09mr8004246ljf.7.1674482795678; Mon, 23 Jan 2023 06:06:35 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id k20-20020a2eb754000000b00287eb396f27sm4463926ljo.7.2023.01.23.06.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 06:06:35 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Mon, 23 Jan 2023 17:06:19 +0300 Message-Id: <20230123140619.177878-5-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123140619.177878-1-mike.rudenko@gmail.com> References: <20230123140619.177878-1-mike.rudenko@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 4/4] ipa: rkisp1: Raise maximum analogue gain X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Omnivision OV4689 sensor driver exposes maximum analogue gain of 16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can be used. Signed-off-by: Mikhail Rudenko Reviewed-by: Jacopo Mondi --- src/ipa/rkisp1/algorithms/agc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index e3470e25..e4cb2fc7 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -38,7 +38,7 @@ LOG_DEFINE_CATEGORY(RkISP1Agc) /* Limits for analogue gain values */ static constexpr double kMinAnalogueGain = 1.0; -static constexpr double kMaxAnalogueGain = 8.0; +static constexpr double kMaxAnalogueGain = 16.0; /* \todo Honour the FrameDurationLimits control instead of hardcoding a limit */ static constexpr utils::Duration kMaxShutterSpeed = 60ms;