| Message ID | 20230123140619.177878-3-mike.rudenko@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Mikhail On Mon, Jan 23, 2023 at 05:06:17PM +0300, Mikhail Rudenko wrote: > Add an entry to the sensor properties for Omnivision OV4689. > > Kernel supports two more types of color bars patterns, which we do not > expose now. > > Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> Thanks Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp > index c3c2cace..a601e1ae 100644 > --- a/src/libcamera/camera_sensor_properties.cpp > +++ b/src/libcamera/camera_sensor_properties.cpp > @@ -130,6 +130,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > { controls::draft::TestPatternModeColorBars, 1}, > }, > } }, > + { "ov4689", { > + .unitCellSize = { 2000, 2000 }, > + .testPatternModes = { > + { controls::draft::TestPatternModeOff, 0 }, > + { controls::draft::TestPatternModeColorBars, 1}, > + { controls::draft::TestPatternModeColorBarsFadeToGray, 2}, > + /* > + * No corresponding test patterns in > + * MIPI CCS specification for sensor's > + * colorBarType2 and colorBarType3. > + */ > + }, > + } }, > { "ov5640", { > .unitCellSize = { 1400, 1400 }, > .testPatternModes = { > -- > 2.39.1 >
diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp index c3c2cace..a601e1ae 100644 --- a/src/libcamera/camera_sensor_properties.cpp +++ b/src/libcamera/camera_sensor_properties.cpp @@ -130,6 +130,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen { controls::draft::TestPatternModeColorBars, 1}, }, } }, + { "ov4689", { + .unitCellSize = { 2000, 2000 }, + .testPatternModes = { + { controls::draft::TestPatternModeOff, 0 }, + { controls::draft::TestPatternModeColorBars, 1}, + { controls::draft::TestPatternModeColorBarsFadeToGray, 2}, + /* + * No corresponding test patterns in + * MIPI CCS specification for sensor's + * colorBarType2 and colorBarType3. + */ + }, + } }, { "ov5640", { .unitCellSize = { 1400, 1400 }, .testPatternModes = {
Add an entry to the sensor properties for Omnivision OV4689. Kernel supports two more types of color bars patterns, which we do not expose now. Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> --- src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+)