[libcamera-devel,2/4] android: camera_metadata: Constify argument to addEntry() and updateEntry()
diff mbox series

Message ID 20210515183826.21003-3-laurent.pinchart@ideasonboard.com
State Accepted
Delegated to: Laurent Pinchart
Headers show
Series
  • android: camera_metadata: Miscellaneous improvements
Related show

Commit Message

Laurent Pinchart May 15, 2021, 6:38 p.m. UTC 
The addEntry() and updateEntry() overrides that take a reference to a
container don't need to modify the container. Make it const.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/android/camera_metadata.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Hirokazu Honda May 17, 2021, 3:39 a.m. UTC | #1 
Hi Laurent,



On Sun, May 16, 2021 at 3:38 AM Laurent Pinchart <
laurent.pinchart@ideasonboard.com> wrote:

> The addEntry() and updateEntry() overrides that take a reference to a
> container don't need to modify the container. Make it const.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>

Reviewed-by: Hirokazu Honda <hiroh@chromium.org>


> ---
>  src/android/camera_metadata.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h
> index 56df6f1c9008..f95c34581fe4 100644
> --- a/src/android/camera_metadata.h
> +++ b/src/android/camera_metadata.h
> @@ -42,7 +42,7 @@ public:
>
>         template<typename S,
>                  typename T = typename S::value_type>
> -       bool addEntry(uint32_t tag, S &data)
> +       bool addEntry(uint32_t tag, const S &data)
>         {
>                 return addEntry(tag, data.data(), data.size(), sizeof(T));
>         }
> @@ -67,7 +67,7 @@ public:
>
>         template<typename S,
>                  typename T = typename S::value_type>
> -       bool updateEntry(uint32_t tag, S &data)
> +       bool updateEntry(uint32_t tag, const S &data)
>         {
>                 return updateEntry(tag, data.data(), data.size());
>         }
> --
> Regards,
>
> Laurent Pinchart
>
>
Kieran Bingham May 17, 2021, 9:35 a.m. UTC | #2 
On 15/05/2021 19:38, Laurent Pinchart wrote:
> The addEntry() and updateEntry() overrides that take a reference to a
> container don't need to modify the container. Make it const.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/android/camera_metadata.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h
> index 56df6f1c9008..f95c34581fe4 100644
> --- a/src/android/camera_metadata.h
> +++ b/src/android/camera_metadata.h
> @@ -42,7 +42,7 @@ public:
>  
>  	template<typename S,
>  		 typename T = typename S::value_type>
> -	bool addEntry(uint32_t tag, S &data)
> +	bool addEntry(uint32_t tag, const S &data)
>  	{
>  		return addEntry(tag, data.data(), data.size(), sizeof(T));
>  	}
> @@ -67,7 +67,7 @@ public:
>  
>  	template<typename S,
>  		 typename T = typename S::value_type>
> -	bool updateEntry(uint32_t tag, S &data)
> +	bool updateEntry(uint32_t tag, const S &data)
>  	{
>  		return updateEntry(tag, data.data(), data.size());
>  	}
>

Patch
diff mbox series 

diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h
index 56df6f1c9008..f95c34581fe4 100644
--- a/src/android/camera_metadata.h
+++ b/src/android/camera_metadata.h
@@ -42,7 +42,7 @@  public:
 
 	template<typename S,
 		 typename T = typename S::value_type>
-	bool addEntry(uint32_t tag, S &data)
+	bool addEntry(uint32_t tag, const S &data)
 	{
 		return addEntry(tag, data.data(), data.size(), sizeof(T));
 	}
@@ -67,7 +67,7 @@  public:
 
 	template<typename S,
 		 typename T = typename S::value_type>
-	bool updateEntry(uint32_t tag, S &data)
+	bool updateEntry(uint32_t tag, const S &data)
 	{
 		return updateEntry(tag, data.data(), data.size());
 	}