From patchwork Sat May 15 18:38:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 12305 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9079BC31FB for ; Sat, 15 May 2021 18:38:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 564796891F; Sat, 15 May 2021 20:38:44 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="EH2seeLy"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F7576891B for ; Sat, 15 May 2021 20:38:40 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EA8D9436; Sat, 15 May 2021 20:38:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1621103920; bh=r1xv+9WpF9UfQq7xQQxmyGDXXSzvFhn68xI6CqXPaYI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EH2seeLyQZscXJ+DwwN5eLdWhNfg27NAUMfbfeKUEAQuObITQojTx6RHkEGQ781Y/ uNNmvTo+awfrQrHSo0vBXgv2erLRRLmk5HL51SatN/kRErTkNc1apEJLTeWqOZN/eC zCEVxPfoxKIuKqOskUE2+kh1XTOScUliVv90OUac= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sat, 15 May 2021 21:38:24 +0300 Message-Id: <20210515183826.21003-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.28.1 In-Reply-To: <20210515183826.21003-1-laurent.pinchart@ideasonboard.com> References: <20210515183826.21003-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/4] android: camera_metadata: Constify argument to addEntry() and updateEntry() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The addEntry() and updateEntry() overrides that take a reference to a container don't need to modify the container. Make it const. Signed-off-by: Laurent Pinchart Reviewed-by: Hirokazu Honda Reviewed-by: Kieran Bingham --- src/android/camera_metadata.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h index 56df6f1c9008..f95c34581fe4 100644 --- a/src/android/camera_metadata.h +++ b/src/android/camera_metadata.h @@ -42,7 +42,7 @@ public: template - bool addEntry(uint32_t tag, S &data) + bool addEntry(uint32_t tag, const S &data) { return addEntry(tag, data.data(), data.size(), sizeof(T)); } @@ -67,7 +67,7 @@ public: template - bool updateEntry(uint32_t tag, S &data) + bool updateEntry(uint32_t tag, const S &data) { return updateEntry(tag, data.data(), data.size()); }