Message ID | 20210515183826.21003-1-laurent.pinchart@ideasonboard.com |
---|---|
Headers | show |
Series |
|
Related | show |
Hello Laurent, On Sat, May 15, 2021 at 09:38:22PM +0300, Laurent Pinchart wrote: > Hello, > > These small improvements stem from the review of the CameraMetadata > dynamic allocations series. As the series has been merged already, it > was as fast to express the review comments as code as it would have been > to write them in English. > > The patches haven't been tested. Paul, would you be able to test them ? Thank you for the nice improvements! Looks good to me (just one comment on 4/4 though). For everything, Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Tested-by: Paul Elder <paul.elder@ideasonboard.com> > > Laurent Pinchart (4): > android: camera_metadata: Rename sizeofT argument to elementSize > android: camera_metadata: Constify argument to addEntry() and > updateEntry() > android: camera_metadata: Make internal functions private > android: camera_metadata: Add type sanity check to updateEntry() > > src/android/camera_metadata.cpp | 15 ++++++++++++--- > src/android/camera_metadata.h | 22 +++++++++++++++------- > 2 files changed, 27 insertions(+), 10 deletions(-) > > -- > Regards, > > Laurent Pinchart >