| Message ID | 20261013-mali-lsc-fix-v1-1-65e948ef8d36@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Jacopo Mondi (2026-10-13 10:45:38) > The conversion of Mali-C55 LSC algorithm to libipa introduced a > wrong assertion check on the size of the blue channel table which breaks > capture operations: > > FATAL default lsc.cpp:92 assertion "rTable.size() == kGridSize && gTable.size() == kGridSize && bTable.size() != kGridSize" failed in configure() > > Fix the assertion check to restore capture operations. > > Fixes: 95efc3c17bcd ("ipa: mali-c55: Port to use LscAlgorithm") > Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/ipa/mali-c55/algorithms/lsc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/mali-c55/algorithms/lsc.cpp b/src/ipa/mali-c55/algorithms/lsc.cpp > index a79d8c80fa9f..e65e2a1807b1 100644 > --- a/src/ipa/mali-c55/algorithms/lsc.cpp > +++ b/src/ipa/mali-c55/algorithms/lsc.cpp > @@ -91,7 +91,7 @@ int Lsc::configure(IPAContext &context, const IPACameraSensorInfo &configInfo) > /* Only 32x32 tables of coefficients are accepted. */ > ASSERT(rTable.size() == kGridSize && > gTable.size() == kGridSize && > - bTable.size() != kGridSize); > + bTable.size() == kGridSize); Ooooooooooops. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > if (colourTemperatures_.size() >= kMaxColourTemperatures) { > LOG(MaliC55Lsc, Error) > > --- > base-commit: 06c3e2d719490aad8ce789fb5d2ad4dfa1459bfb > change-id: 20261013-mali-lsc-fix-5bead282bc1d > > Best regards, > -- > Jacopo Mondi <jacopo.mondi@ideasonboard.com> >
Hi Jacopo On 13/10/2026 10:45, Jacopo Mondi wrote: > The conversion of Mali-C55 LSC algorithm to libipa introduced a > wrong assertion check on the size of the blue channel table which breaks > capture operations: > > FATAL default lsc.cpp:92 assertion "rTable.size() == kGridSize && gTable.size() == kGridSize && bTable.size() != kGridSize" failed in configure() > > Fix the assertion check to restore capture operations. > > Fixes: 95efc3c17bcd ("ipa: mali-c55: Port to use LscAlgorithm") > Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > src/ipa/mali-c55/algorithms/lsc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/mali-c55/algorithms/lsc.cpp b/src/ipa/mali-c55/algorithms/lsc.cpp > index a79d8c80fa9f..e65e2a1807b1 100644 > --- a/src/ipa/mali-c55/algorithms/lsc.cpp > +++ b/src/ipa/mali-c55/algorithms/lsc.cpp > @@ -91,7 +91,7 @@ int Lsc::configure(IPAContext &context, const IPACameraSensorInfo &configInfo) > /* Only 32x32 tables of coefficients are accepted. */ > ASSERT(rTable.size() == kGridSize && > gTable.size() == kGridSize && > - bTable.size() != kGridSize); > + bTable.size() == kGridSize); > > if (colourTemperatures_.size() >= kMaxColourTemperatures) { > LOG(MaliC55Lsc, Error) > > --- > base-commit: 06c3e2d719490aad8ce789fb5d2ad4dfa1459bfb > change-id: 20261013-mali-lsc-fix-5bead282bc1d > > Best regards, > -- > Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Hi Jacopo, Thank you for the patch. > From: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > Sent: 13 October 2026 10:46 > To: libcamera-devel@lists.libcamera.org > Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; > jacopo.mondi <jacopo.mondi@ideasonboard.com> > Subject: [PATCH] ipa: mali-c55: Fix LSC tables size check > > The conversion of Mali-C55 LSC algorithm to libipa introduced a wrong > assertion check on the size of the blue channel table which breaks capture > operations: > > FATAL default lsc.cpp:92 assertion "rTable.size() == kGridSize && > gTable.size() == kGridSize && bTable.size() != kGridSize" failed in > configure() > > Fix the assertion check to restore capture operations. > > Fixes: 95efc3c17bcd ("ipa: mali-c55: Port to use LscAlgorithm") > Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/ipa/mali-c55/algorithms/lsc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Tested on RZ/V2H EVK. root@192:~# cam -c2 -C10 [0:00:29.774997889] [442] INFO Camera camera_manager.cpp:340 libcamera v0.7.2+164-1a7f9a3a-dirty (2026-10-13T10:59:07BST) [0:00:29.814081055] [445] INFO Camera camera_manager.cpp:223 Adding camera 'mali-c55 tpg' for pipeline handler mali-c55 [0:00:29.820373014] [445] WARN CameraSensor camera_sensor_legacy.cpp:358 'imx708': Recommended V4L2 control 0x009a0922 not supported [0:00:29.820578389] [445] WARN CameraSensor camera_sensor_legacy.cpp:442 'imx708': The sensor kernel driver needs to be fixed [0:00:29.820635305] [445] WARN CameraSensor camera_sensor_legacy.cpp:444 'imx708': See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information [0:00:29.824458930] [445] WARN CameraSensor camera_sensor_legacy.cpp:611 'imx708': Failed to retrieve the camera location [0:00:29.824542389] [445] WARN CameraSensor camera_sensor_legacy.cpp:633 'imx708': Rotation control not available, default to 0 degrees [0:00:29.854573555] [445] INFO IPAProxy ipa_proxy.cpp:184 Using tuning file /usr/share/libcamera/ipa/mali-c55/imx708.yaml [0:00:29.956683555] [445] INFO Awb awb.cpp:213 No AWB algorithm specified, using grey world [0:00:29.957733514] [445] WARN Awb awb_grey.cpp:49 Failed to parse 'colourGains' parameter from tuning file; manual colour temperature will not work properly [0:00:29.982099139] [445] INFO Camera camera_manager.cpp:223 Adding camera 'imx708' for pipeline handler mali-c55 Using camera imx708 as cam0 [0:00:29.985870889] [442] INFO Camera camera.cpp:1216 configuring streams: (0) 1920x1080-RGB565/Unset [0:00:29.988612764] [445] INFO Awb awb_grey.cpp:107 No gains curve defined, unable to interpolate gains to colour temperature [0:00:29.989058347] [445] WARN LscTable lsc_table.h:36 Tabular LSC data doesn't support resampling cam0: Capture 10 frames 30.191157 (0.00 fps) cam0-stream0 seq: 000000 bytesused: 4147200 30.203420 (81.55 fps) cam0-stream0 seq: 000001 bytesused: 4147200 30.221362 (55.74 fps) cam0-stream0 seq: 000002 bytesused: 4147200 30.239138 (56.26 fps) cam0-stream0 seq: 000003 bytesused: 4147200 30.257534 (54.36 fps) cam0-stream0 seq: 000004 bytesused: 4147200 30.275430 (55.88 fps) cam0-stream0 seq: 000005 bytesused: 4147200 30.293636 (54.93 fps) cam0-stream0 seq: 000006 bytesused: 4147200 30.311780 (55.11 fps) cam0-stream0 seq: 000007 bytesused: 4147200 30.329709 (55.78 fps) cam0-stream0 seq: 000008 bytesused: 4147200 30.347744 (55.45 fps) cam0-stream0 seq: 000009 bytesused: 4147200 root@192:~# Maybe can you also create a patch to add imx708.yaml into data folder please, so that we can test this setup out of the box. Cheers, Prabhakar > diff --git a/src/ipa/mali-c55/algorithms/lsc.cpp b/src/ipa/mali- > c55/algorithms/lsc.cpp > index a79d8c80fa9f..e65e2a1807b1 100644 > --- a/src/ipa/mali-c55/algorithms/lsc.cpp > +++ b/src/ipa/mali-c55/algorithms/lsc.cpp > @@ -91,7 +91,7 @@ int Lsc::configure(IPAContext &context, const > IPACameraSensorInfo &configInfo) > /* Only 32x32 tables of coefficients are accepted. */ > ASSERT(rTable.size() == kGridSize && > gTable.size() == kGridSize && > - bTable.size() != kGridSize); > + bTable.size() == kGridSize); > > if (colourTemperatures_.size() >= kMaxColourTemperatures) { > LOG(MaliC55Lsc, Error) > > --- > base-commit: 06c3e2d719490aad8ce789fb5d2ad4dfa1459bfb > change-id: 20261013-mali-lsc-fix-5bead282bc1d > > Best regards, > -- > Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Hi Prabhakar On Tue, Oct 13, 2026 at 10:20:56AM +0000, Prabhakar Mahadev Lad wrote: > Hi Jacopo, > > Thank you for the patch. > > > From: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > Sent: 13 October 2026 10:46 > > To: libcamera-devel@lists.libcamera.org > > Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; > > jacopo.mondi <jacopo.mondi@ideasonboard.com> > > Subject: [PATCH] ipa: mali-c55: Fix LSC tables size check > > > > The conversion of Mali-C55 LSC algorithm to libipa introduced a wrong > > assertion check on the size of the blue channel table which breaks capture > > operations: > > > > FATAL default lsc.cpp:92 assertion "rTable.size() == kGridSize && > > gTable.size() == kGridSize && bTable.size() != kGridSize" failed in > > configure() > > > > Fix the assertion check to restore capture operations. > > > > Fixes: 95efc3c17bcd ("ipa: mali-c55: Port to use LscAlgorithm") > > Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > --- > > src/ipa/mali-c55/algorithms/lsc.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Thank you! > > Tested on RZ/V2H EVK. > > root@192:~# cam -c2 -C10 > [0:00:29.774997889] [442] INFO Camera camera_manager.cpp:340 libcamera v0.7.2+164-1a7f9a3a-dirty (2026-10-13T10:59:07BST) > [0:00:29.814081055] [445] INFO Camera camera_manager.cpp:223 Adding camera 'mali-c55 tpg' for pipeline handler mali-c55 > [0:00:29.820373014] [445] WARN CameraSensor camera_sensor_legacy.cpp:358 'imx708': Recommended V4L2 control 0x009a0922 not supported > [0:00:29.820578389] [445] WARN CameraSensor camera_sensor_legacy.cpp:442 'imx708': The sensor kernel driver needs to be fixed > [0:00:29.820635305] [445] WARN CameraSensor camera_sensor_legacy.cpp:444 'imx708': See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information > [0:00:29.824458930] [445] WARN CameraSensor camera_sensor_legacy.cpp:611 'imx708': Failed to retrieve the camera location > [0:00:29.824542389] [445] WARN CameraSensor camera_sensor_legacy.cpp:633 'imx708': Rotation control not available, default to 0 degrees > [0:00:29.854573555] [445] INFO IPAProxy ipa_proxy.cpp:184 Using tuning file /usr/share/libcamera/ipa/mali-c55/imx708.yaml > [0:00:29.956683555] [445] INFO Awb awb.cpp:213 No AWB algorithm specified, using grey world > [0:00:29.957733514] [445] WARN Awb awb_grey.cpp:49 Failed to parse 'colourGains' parameter from tuning file; manual colour temperature will not work properly > [0:00:29.982099139] [445] INFO Camera camera_manager.cpp:223 Adding camera 'imx708' for pipeline handler mali-c55 > Using camera imx708 as cam0 > [0:00:29.985870889] [442] INFO Camera camera.cpp:1216 configuring streams: (0) 1920x1080-RGB565/Unset > [0:00:29.988612764] [445] INFO Awb awb_grey.cpp:107 No gains curve defined, unable to interpolate gains to colour temperature > [0:00:29.989058347] [445] WARN LscTable lsc_table.h:36 Tabular LSC data doesn't support resampling > cam0: Capture 10 frames > 30.191157 (0.00 fps) cam0-stream0 seq: 000000 bytesused: 4147200 > 30.203420 (81.55 fps) cam0-stream0 seq: 000001 bytesused: 4147200 > 30.221362 (55.74 fps) cam0-stream0 seq: 000002 bytesused: 4147200 > 30.239138 (56.26 fps) cam0-stream0 seq: 000003 bytesused: 4147200 > 30.257534 (54.36 fps) cam0-stream0 seq: 000004 bytesused: 4147200 > 30.275430 (55.88 fps) cam0-stream0 seq: 000005 bytesused: 4147200 > 30.293636 (54.93 fps) cam0-stream0 seq: 000006 bytesused: 4147200 > 30.311780 (55.11 fps) cam0-stream0 seq: 000007 bytesused: 4147200 > 30.329709 (55.78 fps) cam0-stream0 seq: 000008 bytesused: 4147200 > 30.347744 (55.45 fps) cam0-stream0 seq: 000009 bytesused: 4147200 > root@192:~# > > > Maybe can you also create a patch to add imx708.yaml into data folder please, so that we can test this setup out of the box. Good question. My imx708 tuning file has been in part generated by Dan with tuning scripts which are not yet mainlined, and partly by hand porting data from other sensors/platforms. I'm not sure what qualifies a tuning file as "good enough" for upstreaming though.. > > Cheers, > Prabhakar > > > diff --git a/src/ipa/mali-c55/algorithms/lsc.cpp b/src/ipa/mali- > > c55/algorithms/lsc.cpp > > index a79d8c80fa9f..e65e2a1807b1 100644 > > --- a/src/ipa/mali-c55/algorithms/lsc.cpp > > +++ b/src/ipa/mali-c55/algorithms/lsc.cpp > > @@ -91,7 +91,7 @@ int Lsc::configure(IPAContext &context, const > > IPACameraSensorInfo &configInfo) > > /* Only 32x32 tables of coefficients are accepted. */ > > ASSERT(rTable.size() == kGridSize && > > gTable.size() == kGridSize && > > - bTable.size() != kGridSize); > > + bTable.size() == kGridSize); > > > > if (colourTemperatures_.size() >= kMaxColourTemperatures) { > > LOG(MaliC55Lsc, Error) > > > > --- > > base-commit: 06c3e2d719490aad8ce789fb5d2ad4dfa1459bfb > > change-id: 20261013-mali-lsc-fix-5bead282bc1d > > > > Best regards, > > -- > > Jacopo Mondi <jacopo.mondi@ideasonboard.com> >
Hi Jacopo, > From: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > Sent: 13 October 2026 11:35 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: jacopo.mondi <jacopo.mondi@ideasonboard.com>; libcamera- > devel@lists.libcamera.org > Subject: Re: [PATCH] ipa: mali-c55: Fix LSC tables size check > > Hi Prabhakar > > On Tue, Oct 13, 2026 at 10:20:56AM +0000, Prabhakar Mahadev Lad wrote: > > Hi Jacopo, > > > > Thank you for the patch. > > > > > From: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > > Sent: 13 October 2026 10:46 > > > To: libcamera-devel@lists.libcamera.org > > > Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; > > > jacopo.mondi <jacopo.mondi@ideasonboard.com> > > > Subject: [PATCH] ipa: mali-c55: Fix LSC tables size check > > > > > > The conversion of Mali-C55 LSC algorithm to libipa introduced a > > > wrong assertion check on the size of the blue channel table which > > > breaks capture > > > operations: > > > > > > FATAL default lsc.cpp:92 assertion "rTable.size() == kGridSize && > > > gTable.size() == kGridSize && bTable.size() != kGridSize" failed in > > > configure() > > > > > > Fix the assertion check to restore capture operations. > > > > > > Fixes: 95efc3c17bcd ("ipa: mali-c55: Port to use LscAlgorithm") > > > Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > > --- > > > src/ipa/mali-c55/algorithms/lsc.cpp | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Thank you! > > > > > Tested on RZ/V2H EVK. > > > > root@192:~# cam -c2 -C10 > > [0:00:29.774997889] [442] INFO Camera camera_manager.cpp:340 > > libcamera v0.7.2+164-1a7f9a3a-dirty (2026-10-13T10:59:07BST) > > [0:00:29.814081055] [445] INFO Camera camera_manager.cpp:223 Adding > > camera 'mali-c55 tpg' for pipeline handler mali-c55 > > [0:00:29.820373014] [445] WARN CameraSensor > > camera_sensor_legacy.cpp:358 'imx708': Recommended V4L2 control > > 0x009a0922 not supported [0:00:29.820578389] [445] WARN CameraSensor > > camera_sensor_legacy.cpp:442 'imx708': The sensor kernel driver needs > > to be fixed [0:00:29.820635305] [445] WARN CameraSensor > > camera_sensor_legacy.cpp:444 'imx708': See > > Documentation/sensor_driver_requirements.rst in the libcamera sources > > for more information [0:00:29.824458930] [445] WARN CameraSensor > > camera_sensor_legacy.cpp:611 'imx708': Failed to retrieve the camera > > location [0:00:29.824542389] [445] WARN CameraSensor > > camera_sensor_legacy.cpp:633 'imx708': Rotation control not available, > > default to 0 degrees [0:00:29.854573555] [445] INFO IPAProxy > > ipa_proxy.cpp:184 Using tuning file > > /usr/share/libcamera/ipa/mali-c55/imx708.yaml > > [0:00:29.956683555] [445] INFO Awb awb.cpp:213 No AWB algorithm > > specified, using grey world [0:00:29.957733514] [445] WARN Awb > > awb_grey.cpp:49 Failed to parse 'colourGains' parameter from tuning > > file; manual colour temperature will not work properly > > [0:00:29.982099139] [445] INFO Camera camera_manager.cpp:223 Adding > > camera 'imx708' for pipeline handler mali-c55 Using camera imx708 as > > cam0 [0:00:29.985870889] [442] INFO Camera camera.cpp:1216 > > configuring streams: (0) 1920x1080-RGB565/Unset [0:00:29.988612764] > > [445] INFO Awb awb_grey.cpp:107 No gains curve defined, unable to > > interpolate gains to colour temperature [0:00:29.989058347] [445] > > WARN LscTable lsc_table.h:36 Tabular LSC data doesn't support > > resampling > > cam0: Capture 10 frames > > 30.191157 (0.00 fps) cam0-stream0 seq: 000000 bytesused: 4147200 > > 30.203420 (81.55 fps) cam0-stream0 seq: 000001 bytesused: 4147200 > > 30.221362 (55.74 fps) cam0-stream0 seq: 000002 bytesused: 4147200 > > 30.239138 (56.26 fps) cam0-stream0 seq: 000003 bytesused: 4147200 > > 30.257534 (54.36 fps) cam0-stream0 seq: 000004 bytesused: 4147200 > > 30.275430 (55.88 fps) cam0-stream0 seq: 000005 bytesused: 4147200 > > 30.293636 (54.93 fps) cam0-stream0 seq: 000006 bytesused: 4147200 > > 30.311780 (55.11 fps) cam0-stream0 seq: 000007 bytesused: 4147200 > > 30.329709 (55.78 fps) cam0-stream0 seq: 000008 bytesused: 4147200 > > 30.347744 (55.45 fps) cam0-stream0 seq: 000009 bytesused: 4147200 > > root@192:~# > > > > > > Maybe can you also create a patch to add imx708.yaml into data folder > please, so that we can test this setup out of the box. > > Good question. > > My imx708 tuning file has been in part generated by Dan with tuning > scripts which are not yet mainlined, and partly by hand porting data from > other sensors/platforms. > > I'm not sure what qualifies a tuning file as "good enough" for upstreaming > though.. > Ok we can wait until we have the scripts mainlined/good enough tunning file. For now its not stopping me form testing so good for now. Cheers, Prabhakar
diff --git a/src/ipa/mali-c55/algorithms/lsc.cpp b/src/ipa/mali-c55/algorithms/lsc.cpp index a79d8c80fa9f..e65e2a1807b1 100644 --- a/src/ipa/mali-c55/algorithms/lsc.cpp +++ b/src/ipa/mali-c55/algorithms/lsc.cpp @@ -91,7 +91,7 @@ int Lsc::configure(IPAContext &context, const IPACameraSensorInfo &configInfo) /* Only 32x32 tables of coefficients are accepted. */ ASSERT(rTable.size() == kGridSize && gTable.size() == kGridSize && - bTable.size() != kGridSize); + bTable.size() == kGridSize); if (colourTemperatures_.size() >= kMaxColourTemperatures) { LOG(MaliC55Lsc, Error)
The conversion of Mali-C55 LSC algorithm to libipa introduced a wrong assertion check on the size of the blue channel table which breaks capture operations: FATAL default lsc.cpp:92 assertion "rTable.size() == kGridSize && gTable.size() == kGridSize && bTable.size() != kGridSize" failed in configure() Fix the assertion check to restore capture operations. Fixes: 95efc3c17bcd ("ipa: mali-c55: Port to use LscAlgorithm") Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> --- src/ipa/mali-c55/algorithms/lsc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 06c3e2d719490aad8ce789fb5d2ad4dfa1459bfb change-id: 20261013-mali-lsc-fix-5bead282bc1d Best regards, -- Jacopo Mondi <jacopo.mondi@ideasonboard.com>