From patchwork Tue Oct 13 09:45:38 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 28440 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2B96ABDCB6 for ; Tue, 13 Oct 2026 09:46:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4D035689C3; Tue, 13 Oct 2026 11:45:59 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Af3WYoqi"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8779D689C3 for ; Tue, 13 Oct 2026 11:45:57 +0200 (CEST) Received: from [192.168.1.7] (unknown [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C1246230; Tue, 13 Oct 2026 11:43:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1791884635; bh=pDSOk9FpXxW+n9zRBVlhvFxYb1alaaMl3d1+ZIuGY9c=; h=From:Date:Subject:To:Cc:From; b=Af3WYoqiQ4bgnqli5rcJTtKgAroTm5756rDEKBguhpZ9chQqJqpJXntJiNYHMiwmk 1vTHEVTJAHjxHTCoZl+LqTFLgFXAUpN2u+ju1gk6Pg9MVANVDLN40LjGRx3zbV2dGx K7mETP8h/VTYxzo0Ui5NE5nv6vEX7hwYV8W6EXHU= From: Jacopo Mondi Date: Tue, 13 Oct 2026 11:45:38 +0200 Subject: [PATCH] ipa: mali-c55: Fix LSC tables size check MIME-Version: 1.0 Message-Id: <20261013-mali-lsc-fix-v1-1-65e948ef8d36@ideasonboard.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzNDA0Nj3dzEnEzdnOJk3bTMCl3TpNTEFCMLo6RkwxQloJaColSgMNi46Fg Iv7g0KSs1uQRkhlJtLQCCRQ/lcAAAAA== X-Change-ID: 20261013-mali-lsc-fix-5bead282bc1d To: libcamera-devel@lists.libcamera.org Cc: Lad Prabhakar , Jacopo Mondi X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1471; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=pDSOk9FpXxW+n9zRBVlhvFxYb1alaaMl3d1+ZIuGY9c=; b=owEBbAKT/ZANAwAKAXI0Bo8WoVY8AcsmYgBqzf3UboEqZn8XXDjudkNlpED7PaWY4GUvk9czZ XwBZ8D/XYGJAjIEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCas391AAKCRByNAaPFqFW PJTxD/YhU60rYu0o4+PtsoTb1GX84P5FMZH6iTJwIxU8OFQUbYLD7rKOuNSnUY8TPRLc/Z68mLV 0I/mhv3WkpUuhEXcqeqxyKcASqh9C2+BErYyls0A1DPHPe2o/gCDLGIQDnI7Rlbsm4yX5K/HKWT 45ozpWkfip4dYV3fSBHMbtFxLEMj7nQjw+DGfwYD0U1GN4QWHDLjrk0kr0UxUMi717b4OZfTmTg R05VurejZrk0qxeFHvieceJcdy+95IpdQJTX8zxWMlXqvSzJnUwYSVQhVHWlFaL7oVyEHWai8Tl lE8XzjO/o7qW2jioG+JaTS5VGpCsaf/IkxLP+hUgTmSrMkltAS8fOQPxVRdS8sWdLvavaR8ZwnN cFqA1vQZQeDuIZQ8HFRQtQnaOmf7O3LXnnMnjVm3BNxg4W/d7lkWncRY4Mcz9UX1K5QIuaR4ZhX wMvcJJjQKAIcnP/94ateuwhZy4K6ppXVJvGfLORd0fxdIadiD6fewKLKBNfHemj63KF7zVgPHmP m/HAv5IybBWcaUxF0as2jsoeWzptD313YzR2vj+u5FlZPAPgrs5gLL3JObhlw1i1F8cuPuJXy1a 9tODsklANmFOKOw/uzipMZNjmfbAcoepXUZZEBMudrkDhqv2UiAsySxJqRE+j4gLBV4WNx/e7sK dMwR7B7cndQ2m X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The conversion of Mali-C55 LSC algorithm to libipa introduced a wrong assertion check on the size of the blue channel table which breaks capture operations: FATAL default lsc.cpp:92 assertion "rTable.size() == kGridSize && gTable.size() == kGridSize && bTable.size() != kGridSize" failed in configure() Fix the assertion check to restore capture operations. Fixes: 95efc3c17bcd ("ipa: mali-c55: Port to use LscAlgorithm") Reported-by: Lad Prabhakar Signed-off-by: Jacopo Mondi Reviewed-by: Kieran Bingham Reviewed-by: Daniel Scally Tested-by: Lad Prabhakar --- src/ipa/mali-c55/algorithms/lsc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 06c3e2d719490aad8ce789fb5d2ad4dfa1459bfb change-id: 20261013-mali-lsc-fix-5bead282bc1d Best regards, -- Jacopo Mondi diff --git a/src/ipa/mali-c55/algorithms/lsc.cpp b/src/ipa/mali-c55/algorithms/lsc.cpp index a79d8c80fa9f..e65e2a1807b1 100644 --- a/src/ipa/mali-c55/algorithms/lsc.cpp +++ b/src/ipa/mali-c55/algorithms/lsc.cpp @@ -91,7 +91,7 @@ int Lsc::configure(IPAContext &context, const IPACameraSensorInfo &configInfo) /* Only 32x32 tables of coefficients are accepted. */ ASSERT(rTable.size() == kGridSize && gTable.size() == kGridSize && - bTable.size() != kGridSize); + bTable.size() == kGridSize); if (colourTemperatures_.size() >= kMaxColourTemperatures) { LOG(MaliC55Lsc, Error)