[v1,3/3] libcamera: converter: Small fix in parameter documentation
diff mbox series

Message ID 20261008165113.67511-4-stefan.klug@ideasonboard.com
State Superseded
Headers show
Series
  • rkisp1: Fix dewarper when one pipeline handles multiple cameras
Related show

Commit Message

Stefan Klug Oct. 8, 2026, 4:50 p.m. UTC 
The outputCfgs parameter is an input parameter. Adjust the documentation
accordingly.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 src/libcamera/converter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Oct. 8, 2026, 9:37 p.m. UTC | #1 
Quoting Stefan Klug (2026-10-08 17:50:48)
> The outputCfgs parameter is an input parameter. Adjust the documentation
> accordingly.
> 

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> ---
>  src/libcamera/converter.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp
> index ec0a6db6c035..67e02cce0b72 100644
> --- a/src/libcamera/converter.cpp
> +++ b/src/libcamera/converter.cpp
> @@ -163,7 +163,7 @@ Converter::~Converter()
>   * \fn Converter::configure()
>   * \brief Configure a set of output stream conversion from an input stream
>   * \param[in] inputCfg Input stream configuration
> - * \param[out] outputCfgs A list of output stream configurations
> + * \param[in] outputCfgs A list of output stream configurations
>   * \return 0 on success or a negative error code otherwise
>   */
>  
> -- 
> 2.53.0
>
Dan Scally Oct. 9, 2026, 8:04 a.m. UTC | #2 
On 08/10/2026 17:50, Stefan Klug wrote:
> The outputCfgs parameter is an input parameter. Adjust the documentation
> accordingly.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>> ---
>   src/libcamera/converter.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp
> index ec0a6db6c035..67e02cce0b72 100644
> --- a/src/libcamera/converter.cpp
> +++ b/src/libcamera/converter.cpp
> @@ -163,7 +163,7 @@ Converter::~Converter()
>    * \fn Converter::configure()
>    * \brief Configure a set of output stream conversion from an input stream
>    * \param[in] inputCfg Input stream configuration
> - * \param[out] outputCfgs A list of output stream configurations
> + * \param[in] outputCfgs A list of output stream configurations
>    * \return 0 on success or a negative error code otherwise
>    */
>

Patch
diff mbox series 

diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp
index ec0a6db6c035..67e02cce0b72 100644
--- a/src/libcamera/converter.cpp
+++ b/src/libcamera/converter.cpp
@@ -163,7 +163,7 @@  Converter::~Converter()
  * \fn Converter::configure()
  * \brief Configure a set of output stream conversion from an input stream
  * \param[in] inputCfg Input stream configuration
- * \param[out] outputCfgs A list of output stream configurations
+ * \param[in] outputCfgs A list of output stream configurations
  * \return 0 on success or a negative error code otherwise
  */