| Message ID | 20261008165113.67511-2-stefan.klug@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Stefan Klug (2026-10-08 17:50:46) > When analyzing issues with the dewarper it is very helpful to be able to > get a log of the complete dewarper parameter set. Add the missing lens > dewarp parameters. > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- > .../converter/converter_dw100_vertexmap.cpp | 22 ++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/src/libcamera/converter/converter_dw100_vertexmap.cpp b/src/libcamera/converter/converter_dw100_vertexmap.cpp > index 5b813435706e..b36814c80a19 100644 > --- a/src/libcamera/converter/converter_dw100_vertexmap.cpp > +++ b/src/libcamera/converter/converter_dw100_vertexmap.cpp > @@ -578,7 +578,27 @@ std::vector<uint32_t> Dw100VertexMap::getVertexMap() > << " scaleX: " << effectiveScaleX_ > << " scaleY: " << effectiveScaleX_ > << " rotation: " << rotation_ > - << " offset: " << effectiveOffset_; > + << " offset: " << effectiveOffset_ > + << " lensDewarpEnable: " << lensDewarpEnable_; > + > + if (dewarpParams_.has_value()) > + LOG(Converter, Debug) > + << "Lens dewarp parameters cm: " << dewarpParams_->cm > + << " coeffs: [" << dewarpParams_->coefficients.k1 > + << ", " << dewarpParams_->coefficients.k2 > + << ", " << dewarpParams_->coefficients.p1 > + << ", " << dewarpParams_->coefficients.p2 > + << ", " << dewarpParams_->coefficients.k3 > + << ", " << dewarpParams_->coefficients.k4 > + << ", " << dewarpParams_->coefficients.k5 > + << ", " << dewarpParams_->coefficients.k6 > + << ", " << dewarpParams_->coefficients.s1 > + << ", " << dewarpParams_->coefficients.s2 > + << ", " << dewarpParams_->coefficients.s3 > + << ", " << dewarpParams_->coefficients.s4 > + << "]"; > + else > + LOG(Converter, Debug) << "Lens dewarp parameters: None"; Ack, Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Matrix3x3 outputToSensor = Matrix3x3::identity(); > /* Move to center of output */ > -- > 2.53.0 >
diff --git a/src/libcamera/converter/converter_dw100_vertexmap.cpp b/src/libcamera/converter/converter_dw100_vertexmap.cpp index 5b813435706e..b36814c80a19 100644 --- a/src/libcamera/converter/converter_dw100_vertexmap.cpp +++ b/src/libcamera/converter/converter_dw100_vertexmap.cpp @@ -578,7 +578,27 @@ std::vector<uint32_t> Dw100VertexMap::getVertexMap() << " scaleX: " << effectiveScaleX_ << " scaleY: " << effectiveScaleX_ << " rotation: " << rotation_ - << " offset: " << effectiveOffset_; + << " offset: " << effectiveOffset_ + << " lensDewarpEnable: " << lensDewarpEnable_; + + if (dewarpParams_.has_value()) + LOG(Converter, Debug) + << "Lens dewarp parameters cm: " << dewarpParams_->cm + << " coeffs: [" << dewarpParams_->coefficients.k1 + << ", " << dewarpParams_->coefficients.k2 + << ", " << dewarpParams_->coefficients.p1 + << ", " << dewarpParams_->coefficients.p2 + << ", " << dewarpParams_->coefficients.k3 + << ", " << dewarpParams_->coefficients.k4 + << ", " << dewarpParams_->coefficients.k5 + << ", " << dewarpParams_->coefficients.k6 + << ", " << dewarpParams_->coefficients.s1 + << ", " << dewarpParams_->coefficients.s2 + << ", " << dewarpParams_->coefficients.s3 + << ", " << dewarpParams_->coefficients.s4 + << "]"; + else + LOG(Converter, Debug) << "Lens dewarp parameters: None"; Matrix3x3 outputToSensor = Matrix3x3::identity(); /* Move to center of output */
When analyzing issues with the dewarper it is very helpful to be able to get a log of the complete dewarper parameter set. Add the missing lens dewarp parameters. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- .../converter/converter_dw100_vertexmap.cpp | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)