From patchwork Thu Oct 8 16:50:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 28415 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A0158BDCB2 for ; Thu, 8 Oct 2026 16:51:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4E56668E22; Thu, 8 Oct 2026 18:51:40 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NuZ2jXrh"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EF8BB689EA for ; Thu, 8 Oct 2026 18:51:38 +0200 (CEST) Received: from ideasonboard.com (dynamic-2a00-1028-8389-0276-ea41-93be-167f-9761.ipv6.o2.cz [IPv6:2a00:1028:8389:276:ea41:93be:167f:9761]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AFBC4F1; Thu, 8 Oct 2026 18:49:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1791478181; bh=Lve9kGyX11SlzCTjmok2C0KBDtAQmeGP8ZzcTeCl+sM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NuZ2jXrh2LgyZecaxf9qmORVy6D8hLmtowOrHYpmrP2exoBTSSq71EvjaD5tH2zpw jKwYZoEQn1zCTX2bu6Athp/z4sCR1fw41i5MysZq1sl9+0Ui7SK5+CTlEMtirlfauv /4Sg9PXWzB3qOTp0XhFAuwDeKBYOloNk1ZO0gnj8= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v1 1/3] libcamera: converter: dw100_vertexmap: Add debug logging of dewarp parameters Date: Thu, 8 Oct 2026 18:50:46 +0200 Message-ID: <20261008165113.67511-2-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261008165113.67511-1-stefan.klug@ideasonboard.com> References: <20261008165113.67511-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When analyzing issues with the dewarper it is very helpful to be able to get a log of the complete dewarper parameter set. Add the missing lens dewarp parameters. Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham --- .../converter/converter_dw100_vertexmap.cpp | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/libcamera/converter/converter_dw100_vertexmap.cpp b/src/libcamera/converter/converter_dw100_vertexmap.cpp index 5b813435706e..b36814c80a19 100644 --- a/src/libcamera/converter/converter_dw100_vertexmap.cpp +++ b/src/libcamera/converter/converter_dw100_vertexmap.cpp @@ -578,7 +578,27 @@ std::vector Dw100VertexMap::getVertexMap() << " scaleX: " << effectiveScaleX_ << " scaleY: " << effectiveScaleX_ << " rotation: " << rotation_ - << " offset: " << effectiveOffset_; + << " offset: " << effectiveOffset_ + << " lensDewarpEnable: " << lensDewarpEnable_; + + if (dewarpParams_.has_value()) + LOG(Converter, Debug) + << "Lens dewarp parameters cm: " << dewarpParams_->cm + << " coeffs: [" << dewarpParams_->coefficients.k1 + << ", " << dewarpParams_->coefficients.k2 + << ", " << dewarpParams_->coefficients.p1 + << ", " << dewarpParams_->coefficients.p2 + << ", " << dewarpParams_->coefficients.k3 + << ", " << dewarpParams_->coefficients.k4 + << ", " << dewarpParams_->coefficients.k5 + << ", " << dewarpParams_->coefficients.k6 + << ", " << dewarpParams_->coefficients.s1 + << ", " << dewarpParams_->coefficients.s2 + << ", " << dewarpParams_->coefficients.s3 + << ", " << dewarpParams_->coefficients.s4 + << "]"; + else + LOG(Converter, Debug) << "Lens dewarp parameters: None"; Matrix3x3 outputToSensor = Matrix3x3::identity(); /* Move to center of output */