[4/4] ipa: rpi: Update colour temperature curve for IMX662
diff mbox series

Message ID 20260803123012.10175-5-david.plowman@raspberrypi.com
State Superseded
Headers show
Series
  • Black level and other fixes for IMX662
Related show

Commit Message

David Plowman Aug. 3, 2026, 12:07 p.m. UTC 
The CT (colour temperature) curve is extended at the bottom end, so
that low light halogen images are less orange.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
---
 src/ipa/rpi/pisp/data/imx662.json | 4 +++-
 src/ipa/rpi/vc4/data/imx662.json  | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)

Comments

Naushir Patuck Aug. 5, 2026, 11:57 a.m. UTC | #1 
Hi David,

On Mon, 3 Aug 2026 at 13:30, David Plowman <david.plowman@raspberrypi.com>
wrote:

> The CT (colour temperature) curve is extended at the bottom end, so
> that low light halogen images are less orange.
>
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
>

Reviewed-by: Naushir Patuck <naush@raspberrypi.com>


---
>  src/ipa/rpi/pisp/data/imx662.json | 4 +++-
>  src/ipa/rpi/vc4/data/imx662.json  | 3 ++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/ipa/rpi/pisp/data/imx662.json
> b/src/ipa/rpi/pisp/data/imx662.json
> index 1aa5cf533..8491452b1 100644
> --- a/src/ipa/rpi/pisp/data/imx662.json
> +++ b/src/ipa/rpi/pisp/data/imx662.json
> @@ -155,7 +155,7 @@
>                  {
>                      "auto":
>                      {
> -                        "lo": 2910.0,
> +                        "lo": 2500.0,
>                          "hi": 5535.0
>                      },
>                      "incandescent":
> @@ -192,6 +192,7 @@
>                  "bayes": 1,
>                  "ct_curve":
>                  [
> +                    2500.0, 0.6632, 0.2893,
>                      2910.0, 0.5579, 0.3553,
>                      3600.0, 0.4693, 0.4364,
>                      4490.0, 0.3855, 0.5469,
> @@ -250,6 +251,7 @@
>                  "enable_nn": 1,
>                  "ct_curve":
>                  [
> +                    2500.0, 0.6632, 0.2893,
>                      2910.0, 0.5579, 0.3553,
>                      3600.0, 0.4693, 0.4364,
>                      4490.0, 0.3855, 0.5469,
> diff --git a/src/ipa/rpi/vc4/data/imx662.json
> b/src/ipa/rpi/vc4/data/imx662.json
> index dc28b53c4..aafccaced 100644
> --- a/src/ipa/rpi/vc4/data/imx662.json
> +++ b/src/ipa/rpi/vc4/data/imx662.json
> @@ -86,7 +86,7 @@
>                  {
>                      "auto":
>                      {
> -                        "lo": 2910.0,
> +                        "lo": 2500.0,
>                          "hi": 5535.0
>                      },
>                      "incandescent":
> @@ -123,6 +123,7 @@
>                  "bayes": 1,
>                  "ct_curve":
>                  [
> +                    2500.0, 0.6632, 0.2893,
>                      2910.0, 0.5583, 0.3541,
>                      3600.0, 0.4695, 0.4348,
>                      4490.0, 0.3856, 0.5447,
> --
> 2.47.3
>
>
Jacopo Mondi Aug. 6, 2026, 7:52 a.m. UTC | #2 
Hi David

On Mon, Aug 03, 2026 at 01:07:55PM +0100, David Plowman wrote:
> The CT (colour temperature) curve is extended at the bottom end, so
> that low light halogen images are less orange.
>
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>

Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> ---
>  src/ipa/rpi/pisp/data/imx662.json | 4 +++-
>  src/ipa/rpi/vc4/data/imx662.json  | 3 ++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/ipa/rpi/pisp/data/imx662.json b/src/ipa/rpi/pisp/data/imx662.json
> index 1aa5cf533..8491452b1 100644
> --- a/src/ipa/rpi/pisp/data/imx662.json
> +++ b/src/ipa/rpi/pisp/data/imx662.json
> @@ -155,7 +155,7 @@
>                  {
>                      "auto":
>                      {
> -                        "lo": 2910.0,
> +                        "lo": 2500.0,
>                          "hi": 5535.0
>                      },
>                      "incandescent":
> @@ -192,6 +192,7 @@
>                  "bayes": 1,
>                  "ct_curve":
>                  [
> +                    2500.0, 0.6632, 0.2893,
>                      2910.0, 0.5579, 0.3553,
>                      3600.0, 0.4693, 0.4364,
>                      4490.0, 0.3855, 0.5469,
> @@ -250,6 +251,7 @@
>                  "enable_nn": 1,
>                  "ct_curve":
>                  [
> +                    2500.0, 0.6632, 0.2893,
>                      2910.0, 0.5579, 0.3553,
>                      3600.0, 0.4693, 0.4364,
>                      4490.0, 0.3855, 0.5469,
> diff --git a/src/ipa/rpi/vc4/data/imx662.json b/src/ipa/rpi/vc4/data/imx662.json
> index dc28b53c4..aafccaced 100644
> --- a/src/ipa/rpi/vc4/data/imx662.json
> +++ b/src/ipa/rpi/vc4/data/imx662.json
> @@ -86,7 +86,7 @@
>                  {
>                      "auto":
>                      {
> -                        "lo": 2910.0,
> +                        "lo": 2500.0,
>                          "hi": 5535.0
>                      },
>                      "incandescent":
> @@ -123,6 +123,7 @@
>                  "bayes": 1,
>                  "ct_curve":
>                  [
> +                    2500.0, 0.6632, 0.2893,
>                      2910.0, 0.5583, 0.3541,
>                      3600.0, 0.4695, 0.4348,
>                      4490.0, 0.3856, 0.5447,
> --
> 2.47.3
>

Patch
diff mbox series 

diff --git a/src/ipa/rpi/pisp/data/imx662.json b/src/ipa/rpi/pisp/data/imx662.json
index 1aa5cf533..8491452b1 100644
--- a/src/ipa/rpi/pisp/data/imx662.json
+++ b/src/ipa/rpi/pisp/data/imx662.json
@@ -155,7 +155,7 @@ 
                 {
                     "auto":
                     {
-                        "lo": 2910.0,
+                        "lo": 2500.0,
                         "hi": 5535.0
                     },
                     "incandescent":
@@ -192,6 +192,7 @@ 
                 "bayes": 1,
                 "ct_curve":
                 [
+                    2500.0, 0.6632, 0.2893,
                     2910.0, 0.5579, 0.3553,
                     3600.0, 0.4693, 0.4364,
                     4490.0, 0.3855, 0.5469,
@@ -250,6 +251,7 @@ 
                 "enable_nn": 1,
                 "ct_curve":
                 [
+                    2500.0, 0.6632, 0.2893,
                     2910.0, 0.5579, 0.3553,
                     3600.0, 0.4693, 0.4364,
                     4490.0, 0.3855, 0.5469,
diff --git a/src/ipa/rpi/vc4/data/imx662.json b/src/ipa/rpi/vc4/data/imx662.json
index dc28b53c4..aafccaced 100644
--- a/src/ipa/rpi/vc4/data/imx662.json
+++ b/src/ipa/rpi/vc4/data/imx662.json
@@ -86,7 +86,7 @@ 
                 {
                     "auto":
                     {
-                        "lo": 2910.0,
+                        "lo": 2500.0,
                         "hi": 5535.0
                     },
                     "incandescent":
@@ -123,6 +123,7 @@ 
                 "bayes": 1,
                 "ct_curve":
                 [
+                    2500.0, 0.6632, 0.2893,
                     2910.0, 0.5583, 0.3541,
                     3600.0, 0.4695, 0.4348,
                     4490.0, 0.3856, 0.5447,