| Message ID | 20260803123012.10175-4-david.plowman@raspberrypi.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi David, On Mon, 3 Aug 2026 at 13:30, David Plowman <david.plowman@raspberrypi.com> wrote: > At very high gains, the measured black level increases noticeably > from the nominal value of 3200. > > Signed-off-by: David Plowman <david.plowman@raspberrypi.com> > Reviewed-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/ipa/rpi/pisp/data/imx662.json | 11 ++++++++++- > src/ipa/rpi/vc4/data/imx662.json | 11 ++++++++++- > 2 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/src/ipa/rpi/pisp/data/imx662.json > b/src/ipa/rpi/pisp/data/imx662.json > index b146d6b59..1aa5cf533 100644 > --- a/src/ipa/rpi/pisp/data/imx662.json > +++ b/src/ipa/rpi/pisp/data/imx662.json > @@ -5,7 +5,16 @@ > { > "rpi.black_level": > { > - "black_level": 3200 > + "black_level_func": > + [ > + 1.0, 3200, > + 192.0, 3200, > + 256.0, 3245, > + 320.0, 3331, > + 384.0, 3443, > + 480.0, 3606, > + 512.0, 3623 > + ] > } > }, > { > diff --git a/src/ipa/rpi/vc4/data/imx662.json > b/src/ipa/rpi/vc4/data/imx662.json > index cec937d62..dc28b53c4 100644 > --- a/src/ipa/rpi/vc4/data/imx662.json > +++ b/src/ipa/rpi/vc4/data/imx662.json > @@ -5,7 +5,16 @@ > { > "rpi.black_level": > { > - "black_level": 3200 > + "black_level_func": > + [ > + 1.0, 3200, > + 192.0, 3200, > + 256.0, 3245, > + 320.0, 3331, > + 384.0, 3443, > + 480.0, 3606, > + 512.0, 3623 > + ] > } > }, > { > -- > 2.47.3 > >
Hi David On Mon, Aug 03, 2026 at 01:07:54PM +0100, David Plowman wrote: > At very high gains, the measured black level increases noticeably > from the nominal value of 3200. > > Signed-off-by: David Plowman <david.plowman@raspberrypi.com> Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/ipa/rpi/pisp/data/imx662.json | 11 ++++++++++- > src/ipa/rpi/vc4/data/imx662.json | 11 ++++++++++- > 2 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/src/ipa/rpi/pisp/data/imx662.json b/src/ipa/rpi/pisp/data/imx662.json > index b146d6b59..1aa5cf533 100644 > --- a/src/ipa/rpi/pisp/data/imx662.json > +++ b/src/ipa/rpi/pisp/data/imx662.json > @@ -5,7 +5,16 @@ > { > "rpi.black_level": > { > - "black_level": 3200 > + "black_level_func": > + [ > + 1.0, 3200, > + 192.0, 3200, > + 256.0, 3245, > + 320.0, 3331, > + 384.0, 3443, > + 480.0, 3606, > + 512.0, 3623 > + ] > } > }, > { > diff --git a/src/ipa/rpi/vc4/data/imx662.json b/src/ipa/rpi/vc4/data/imx662.json > index cec937d62..dc28b53c4 100644 > --- a/src/ipa/rpi/vc4/data/imx662.json > +++ b/src/ipa/rpi/vc4/data/imx662.json > @@ -5,7 +5,16 @@ > { > "rpi.black_level": > { > - "black_level": 3200 > + "black_level_func": > + [ > + 1.0, 3200, > + 192.0, 3200, > + 256.0, 3245, > + 320.0, 3331, > + 384.0, 3443, > + 480.0, 3606, > + 512.0, 3623 > + ] > } > }, > { > -- > 2.47.3 >
diff --git a/src/ipa/rpi/pisp/data/imx662.json b/src/ipa/rpi/pisp/data/imx662.json index b146d6b59..1aa5cf533 100644 --- a/src/ipa/rpi/pisp/data/imx662.json +++ b/src/ipa/rpi/pisp/data/imx662.json @@ -5,7 +5,16 @@ { "rpi.black_level": { - "black_level": 3200 + "black_level_func": + [ + 1.0, 3200, + 192.0, 3200, + 256.0, 3245, + 320.0, 3331, + 384.0, 3443, + 480.0, 3606, + 512.0, 3623 + ] } }, { diff --git a/src/ipa/rpi/vc4/data/imx662.json b/src/ipa/rpi/vc4/data/imx662.json index cec937d62..dc28b53c4 100644 --- a/src/ipa/rpi/vc4/data/imx662.json +++ b/src/ipa/rpi/vc4/data/imx662.json @@ -5,7 +5,16 @@ { "rpi.black_level": { - "black_level": 3200 + "black_level_func": + [ + 1.0, 3200, + 192.0, 3200, + 256.0, 3245, + 320.0, 3331, + 384.0, 3443, + 480.0, 3606, + 512.0, 3623 + ] } }, {
At very high gains, the measured black level increases noticeably from the nominal value of 3200. Signed-off-by: David Plowman <david.plowman@raspberrypi.com> --- src/ipa/rpi/pisp/data/imx662.json | 11 ++++++++++- src/ipa/rpi/vc4/data/imx662.json | 11 ++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-)