From patchwork Mon Aug 3 12:07:54 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 27546 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8BDB6C3264 for ; Mon, 3 Aug 2026 12:30:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id F38DE6806A; Mon, 3 Aug 2026 14:30:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="DUJ1puxV"; dkim-atps=neutral Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8565A67EE4 for ; Mon, 3 Aug 2026 14:30:27 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4980fe6b3beso9532145e9.0 for ; Mon, 03 Aug 2026 05:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1785760227; x=1786365027; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2jDGBVvc7JL72mgs7Hyf6RrZ4unICd74+eDb1x+i5PQ=; b=DUJ1puxVJTILA2MF777HbgEaxYDQIPz6aqWdeSxA2Fd1PxDfoButA4oJaNuw3gnzNT R0ODgIlt10hJIlB4m1AijGqg1UfCnnVxBQJGUTNtyll6gfLiv7mKOWeR8plVfj6C0Rnk eFk5Hfcp3FYLQ20kAM+ybNEcmnVwNNtl3oKJZc8VMEWNzklUAOuPFjkW2nbOiqZYrsr7 XAcsVZYzdGXxD1T93vAwLtYwhxwhndSfjsALm8jt2nkCfFt4OQhQqxGOWlCFfGEMGZu2 u2/XLv6/gGt9TucVQ2Lodw+ZDWO600dZL+NuN/PXotY9Hj71AGYVQhBh4Ys2xiLf1MvS cl/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785760227; x=1786365027; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=2jDGBVvc7JL72mgs7Hyf6RrZ4unICd74+eDb1x+i5PQ=; b=bFIXQkwUqq6tIBnFVvn5fpGgu780YEQhltxA+2XE5KgHbfOllxylcGIG3dt3UDAiQn dH13LP7TLrRMO2rOO0GNvIKt7tIywfkw7PKOKlJT6R7+P0EBNBwunmaSTg/Vrr3E2YVe UZIxyKLUYXUpI2h2CqjxrllZ8cR+D1ulLK5Ygo+ZgDJvSuR56Wp2IQNYYVe9+8PbWIBW eRcbz1Gbhffjp3qam34r88twWdDPRWT+SSNzcBlG82RmC9gaJLLM5fIVBsQfu6s22i9b r8uqaTGDPnCiLJNphpbmuN7RY54wRr/bJHfPvCeuPt9vnFqasO/HnUTkLKLK9rYu0rPw I3jw== X-Gm-Message-State: AOJu0YyAyOSNm7aJP0WwtYp3cBHB3ODi4/L+yaL923ZxStIL+xA3e9/1 JFeYVFy8iNniyNBCFx2FDhr4IQmK7V9gT95O12NGu1QaBY5l6PomZdB8Py1mGF9K+1miauZdd37 U+DPT X-Gm-Gg: AR+sD11oX4EiZ24g65+SgFiZkM+18F+bXaSsI/TwTB4Qz911zbr6lQbYHT3hqXMPq7I KTfvIEYjALXgG/fVZHb/8xBlC8fuiMd6ArfhqA3woQ09SLKLfY+z19PDaNdMJfZeboj0oUkL37X 5Cf0iQQssvDBLoWMZ6F3zkORTMTiQXqur5zdvrfipLBAXYqUpLGb5g76ZaKHbE2wZ2A7Ys8noNo HkH03jl41N5IBY7Jtol5FcuO4ke/pDCDOgW3gP8AAGF0aZkUKkhzfftp6RGygwqfvgadClU4CYn fJNOz2VAyfyj66nQw0nma9jJCoYIGdf9Nhg5caFweBOwML+EyAgYqw65TX/L3agvQWrIvnkF/Ce 6CBPN1MppNR7AZJtHnr8Vfc0hMMmf0lJs77W9TaNwPDbuMiYXAbg6ipNqJ3hYkbeXVOacrEn9li OJmR07TVSDLJsZlPdBLVjw1O+uj1H1eLegM5UkMkJqlC2MM34Wc1gPB5/l66TrtotQZw3CNofm/ ZYdjuMMq82H3grzJW6lN0iSF2+IZx6qdibQ+zrLZjMI3NUcGgil0TU2oVHPo/qDNUm3K64UobJR K4gH X-Received: by 2002:a05:600c:1990:b0:493:f783:c46a with SMTP id 5b1f17b1804b1-4980eb9b432mr172688635e9.6.1785760219591; Mon, 03 Aug 2026 05:30:19 -0700 (PDT) Received: from davidp-pi5.pitowers.org ([2a00:1098:3142:1f:4706:89ee:c47e:1087]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49808690ffbsm256452635e9.10.2026.08.03.05.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 05:30:19 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Cc: David Plowman Subject: [PATCH 3/4] ipa: rpi: Update black level tuning for IMX662 Date: Mon, 3 Aug 2026 13:07:54 +0100 Message-ID: <20260803123012.10175-4-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260803123012.10175-1-david.plowman@raspberrypi.com> References: <20260803123012.10175-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" At very high gains, the measured black level increases noticeably from the nominal value of 3200. Signed-off-by: David Plowman --- src/ipa/rpi/pisp/data/imx662.json | 11 ++++++++++- src/ipa/rpi/vc4/data/imx662.json | 11 ++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/src/ipa/rpi/pisp/data/imx662.json b/src/ipa/rpi/pisp/data/imx662.json index b146d6b59..1aa5cf533 100644 --- a/src/ipa/rpi/pisp/data/imx662.json +++ b/src/ipa/rpi/pisp/data/imx662.json @@ -5,7 +5,16 @@ { "rpi.black_level": { - "black_level": 3200 + "black_level_func": + [ + 1.0, 3200, + 192.0, 3200, + 256.0, 3245, + 320.0, 3331, + 384.0, 3443, + 480.0, 3606, + 512.0, 3623 + ] } }, { diff --git a/src/ipa/rpi/vc4/data/imx662.json b/src/ipa/rpi/vc4/data/imx662.json index cec937d62..dc28b53c4 100644 --- a/src/ipa/rpi/vc4/data/imx662.json +++ b/src/ipa/rpi/vc4/data/imx662.json @@ -5,7 +5,16 @@ { "rpi.black_level": { - "black_level": 3200 + "black_level_func": + [ + 1.0, 3200, + 192.0, 3200, + 256.0, 3245, + 320.0, 3331, + 384.0, 3443, + 480.0, 3606, + 512.0, 3623 + ] } }, {