| Message ID | 20260723154327.1357866-25-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
On Thu, Jul 23, 2026 at 05:43:07PM +0200, Barnabás Pőcze wrote: > Currently the default value for `FrameDurationLimits` is meaningless > because the full range is used by default. So advertise the full range. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > --- > src/ipa/libipa/agc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp > index 49b3034746..edcbab1e0b 100644 > --- a/src/ipa/libipa/agc.cpp > +++ b/src/ipa/libipa/agc.cpp > @@ -326,7 +326,7 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state, cons > config.ctrlMap[&controls::FrameDurationLimits] = ControlInfo{ > frameDurations[0], > frameDurations[1], > - Span<const int64_t, 2>{ { frameDurations[2], frameDurations[2] } }, > + Span<const int64_t, 2>{ { frameDurations[0], frameDurations[1] } }, true, we should probably report frameDurations[2] in metadata, but the limits should indeed be full range Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > }; > > session.minFrameDuration = std::chrono::microseconds(frameDurations[0]); > -- > 2.55.0 >
diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp index 49b3034746..edcbab1e0b 100644 --- a/src/ipa/libipa/agc.cpp +++ b/src/ipa/libipa/agc.cpp @@ -326,7 +326,7 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state, cons config.ctrlMap[&controls::FrameDurationLimits] = ControlInfo{ frameDurations[0], frameDurations[1], - Span<const int64_t, 2>{ { frameDurations[2], frameDurations[2] } }, + Span<const int64_t, 2>{ { frameDurations[0], frameDurations[1] } }, }; session.minFrameDuration = std::chrono::microseconds(frameDurations[0]);
Currently the default value for `FrameDurationLimits` is meaningless because the full range is used by default. So advertise the full range. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/ipa/libipa/agc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)