[v2,02/12] ipu3: awb: Remove CCM settings from Awb algorithm
diff mbox series

Message ID 20260626-ipu3-libipa-rework-v2-2-41546e23de3e@ideasonboard.com
State New
Headers show
Series
  • libipa: Re-work IPU3 IPA to use libipa algorithms
Related show

Commit Message

Dan Scally June 26, 2026, 1:05 p.m. UTC 
The IPU3 AWB algorithm currently defines a CCM matrix that is just
a no-op. Remove the settings entirely; they need really to go in to
a dedicated CCM algorithm.

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
---
Changes in v2:

        - None
---
 src/ipa/ipu3/algorithms/awb.cpp | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Kieran Bingham June 29, 2026, 10 a.m. UTC | #1 
Quoting Daniel Scally (2026-06-26 14:05:49)
> The IPU3 AWB algorithm currently defines a CCM matrix that is just
> a no-op. Remove the settings entirely; they need really to go in to
> a dedicated CCM algorithm.
> 
> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
> ---
> Changes in v2:
> 
>         - None
> ---
>  src/ipa/ipu3/algorithms/awb.cpp | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp
> index 6b4418aa6f3add0a41cae77000c1f5f67897111a..613bdbbf51cd127e03906571813260a6857067dc 100644
> --- a/src/ipa/ipu3/algorithms/awb.cpp
> +++ b/src/ipa/ipu3/algorithms/awb.cpp
> @@ -112,13 +112,6 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {
>         .opt_center_sqr = { 419904, 133956 },
>  };
>  
> -/* Default color correction matrix defined as an identity matrix */
> -static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = {
> -       8191, 0, 0, 0,
> -       0, 8191, 0, 0,
> -       0, 0, 8191, 0
> -};
> -
>  /**
>   * \class Awb
>   * \brief A Grey world white balance correction algorithm
> @@ -293,12 +286,9 @@ void Awb::prepare(IPAContext &context,
>  
>         LOG(IPU3Awb, Debug) << "Color temperature estimated: " << asyncResults_.temperatureK;
>  
> -       /* The CCM matrix may change when color temperature will be used */
> -       params->acc_param.ccm = imguCssCcmDefault;
>  
>         params->use.acc_awb = 1;
>         params->use.acc_bnr = 1;
> -       params->use.acc_ccm = 1;
>  }
>  
>  /* Generate an RGB vector with the average values for each zone */
> 
> -- 
> 2.43.0
>
Jacopo Mondi July 8, 2026, 3:14 p.m. UTC | #2 
Hi Dan

On Fri, Jun 26, 2026 at 02:05:49PM +0100, Daniel Scally wrote:
> The IPU3 AWB algorithm currently defines a CCM matrix that is just
> a no-op. Remove the settings entirely; they need really to go in to
> a dedicated CCM algorithm.
>
> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

> ---
> Changes in v2:
>
>         - None
> ---
>  src/ipa/ipu3/algorithms/awb.cpp | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp
> index 6b4418aa6f3add0a41cae77000c1f5f67897111a..613bdbbf51cd127e03906571813260a6857067dc 100644
> --- a/src/ipa/ipu3/algorithms/awb.cpp
> +++ b/src/ipa/ipu3/algorithms/awb.cpp
> @@ -112,13 +112,6 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {
>  	.opt_center_sqr = { 419904, 133956 },
>  };
>
> -/* Default color correction matrix defined as an identity matrix */
> -static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = {
> -	8191, 0, 0, 0,
> -	0, 8191, 0, 0,
> -	0, 0, 8191, 0
> -};
> -
>  /**
>   * \class Awb
>   * \brief A Grey world white balance correction algorithm
> @@ -293,12 +286,9 @@ void Awb::prepare(IPAContext &context,
>
>  	LOG(IPU3Awb, Debug) << "Color temperature estimated: " << asyncResults_.temperatureK;
>
> -	/* The CCM matrix may change when color temperature will be used */
> -	params->acc_param.ccm = imguCssCcmDefault;
>
>  	params->use.acc_awb = 1;
>  	params->use.acc_bnr = 1;
> -	params->use.acc_ccm = 1;
>  }
>
>  /* Generate an RGB vector with the average values for each zone */
>
> --
> 2.43.0
>

Patch
diff mbox series 

diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp
index 6b4418aa6f3add0a41cae77000c1f5f67897111a..613bdbbf51cd127e03906571813260a6857067dc 100644
--- a/src/ipa/ipu3/algorithms/awb.cpp
+++ b/src/ipa/ipu3/algorithms/awb.cpp
@@ -112,13 +112,6 @@  static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {
 	.opt_center_sqr = { 419904, 133956 },
 };
 
-/* Default color correction matrix defined as an identity matrix */
-static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = {
-	8191, 0, 0, 0,
-	0, 8191, 0, 0,
-	0, 0, 8191, 0
-};
-
 /**
  * \class Awb
  * \brief A Grey world white balance correction algorithm
@@ -293,12 +286,9 @@  void Awb::prepare(IPAContext &context,
 
 	LOG(IPU3Awb, Debug) << "Color temperature estimated: " << asyncResults_.temperatureK;
 
-	/* The CCM matrix may change when color temperature will be used */
-	params->acc_param.ccm = imguCssCcmDefault;
 
 	params->use.acc_awb = 1;
 	params->use.acc_bnr = 1;
-	params->use.acc_ccm = 1;
 }
 
 /* Generate an RGB vector with the average values for each zone */