From patchwork Fri Jun 26 13:05:49 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 27062 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7EF85C3302 for ; Fri, 26 Jun 2026 13:06:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2C5BE65EFC; Fri, 26 Jun 2026 15:06:09 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="AI91Hf46"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 30D8A65878 for ; Fri, 26 Jun 2026 15:06:05 +0200 (CEST) Received: from [127.0.1.1] (chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net [82.19.20.230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 388631438; Fri, 26 Jun 2026 15:05:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782479124; bh=Pd82DKCym4GNm+qhZLWfJ/wUXOexPxja3Fmk9clyA+8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=AI91Hf46dXe2hvokniyM6iNhtA5nDNem6JUh65p/vp7O1EcW+3zkGX6NsOkSqcDQO ecSBZDJXRRgUyJNpKQBkaEAwlahbIJ+gbV9dJaT7tYoq3mrM59eaZWcHUVto9luoNR jOVAY9zGe5yHyYv9ReRFP5QUU3tBdEKLlcEtXKwU= From: Daniel Scally Date: Fri, 26 Jun 2026 14:05:49 +0100 Subject: [PATCH v2 02/12] ipu3: awb: Remove CCM settings from Awb algorithm MIME-Version: 1.0 Message-Id: <20260626-ipu3-libipa-rework-v2-2-41546e23de3e@ideasonboard.com> References: <20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com> In-Reply-To: <20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally , =?utf-8?q?Barnab=C3=A1s_?= =?utf-8?b?UMWRY3pl?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1552; i=dan.scally@ideasonboard.com; h=from:subject:message-id; bh=Pd82DKCym4GNm+qhZLWfJ/wUXOexPxja3Fmk9clyA+8=; b=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqPnk5VN/fZ4OasjtS5p87+TQnoCcSuiY+PSYLj tI7A51lVv6JAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCaj55OQAKCRDISVd6bEV1 MtWuD/4+Zy8cgnPlJ3aI61KtapPFQTaGF4v9Beo5OOWTXdGvKqUnY58WW2Ps35uEjaTNlF/LSjR ub60J7eVXF1HT/J1Kh2sNd1b0V+NQtWSovCHYZ0PdkoIUcTenHYV7WcyJrbcSGN0Lw5Rexa1m5Z 5/O8xtv4IXtIfM52pGRgoNTgMwBNceC48Ooow3XzokBZKuE1YQz9wiNtM97HqwKRU6HO7wkRreT FxGRL3I5+uIn38d1lHJe1gv+/x4idrFe7+Onn5lMEaBIjmb1bYwJJYrVyzzR56cMQhnWdRzSjib bqdII025rmNvRzkBsWIMmGBUZQGmga1Pd+EP+etHPwoZkptEN4/bDXa5Icf1DY+XduZP9Au8kXu BXNUtmxoQyrTgHil/ba08iH10f33bAOCAG255+hpTZ+yUzUN3hZhtPOxFXO7kOBH/1Q/wJP0yhz 2Z0e8TPYveMbn1tlStTPvj6Hd+/hUhlWFmLF/dj0HZque21yuODmk6IsUpVbWAqNpO7Y94aMznh +iVELMkXb3T3fx+G3Kl+8fl5kMUoiahooIlF5ycBOxpyvmO/5so0rUhIQQjrVqyUkj+plqOTdNc U08C3v3h/3O+hu4Ywo4SV0Q+sqnH397wxsXHtDklHrvJ+sYhFjMRumPBprHoTYZ3Krks7GZ8YDv C4TEdGGgirYVSQQ== X-Developer-Key: i=dan.scally@ideasonboard.com; a=openpgp; fpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IPU3 AWB algorithm currently defines a CCM matrix that is just a no-op. Remove the settings entirely; they need really to go in to a dedicated CCM algorithm. Reviewed-by: Barnabás Pőcze Signed-off-by: Daniel Scally --- Changes in v2: - None --- src/ipa/ipu3/algorithms/awb.cpp | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp index 6b4418aa6f3add0a41cae77000c1f5f67897111a..613bdbbf51cd127e03906571813260a6857067dc 100644 --- a/src/ipa/ipu3/algorithms/awb.cpp +++ b/src/ipa/ipu3/algorithms/awb.cpp @@ -112,13 +112,6 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = { .opt_center_sqr = { 419904, 133956 }, }; -/* Default color correction matrix defined as an identity matrix */ -static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = { - 8191, 0, 0, 0, - 0, 8191, 0, 0, - 0, 0, 8191, 0 -}; - /** * \class Awb * \brief A Grey world white balance correction algorithm @@ -293,12 +286,9 @@ void Awb::prepare(IPAContext &context, LOG(IPU3Awb, Debug) << "Color temperature estimated: " << asyncResults_.temperatureK; - /* The CCM matrix may change when color temperature will be used */ - params->acc_param.ccm = imguCssCcmDefault; params->use.acc_awb = 1; params->use.acc_bnr = 1; - params->use.acc_ccm = 1; } /* Generate an RGB vector with the average values for each zone */