| Message ID | 20260626120041.627376-4-naush@raspberrypi.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Naush, Thank you for the patch. On Fri, Jun 26, 2026 at 12:54:03PM +0100, Naushir Patuck wrote: > Add the NV12MT_COL128 (NV12 8-bit) and NV12MT_10_COL128 (P030 10-bit) > column layout pixel formats available from the PiSP Backend hardware. > > Map the matching V4L2 FourCCs to the libcamera::formats conversion table. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/libcamera/formats.yaml | 6 ++++++ Please also update formats.cpp. > src/libcamera/v4l2_pixelformat.cpp | 4 ++++ > 2 files changed, 10 insertions(+) > > diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml > index 2d54d391ca01..3bf010c47aa6 100644 > --- a/src/libcamera/formats.yaml > +++ b/src/libcamera/formats.yaml > @@ -73,6 +73,12 @@ formats: > fourcc: DRM_FORMAT_NV24 > - NV42: > fourcc: DRM_FORMAT_NV42 > + - NV12MT_COL128: > + fourcc: DRM_FORMAT_NV12 > + mod: DRM_FORMAT_MOD_BROADCOM_SAND128 > + - NV12MT_10_COL128: > + fourcc: DRM_FORMAT_P030 > + mod: DRM_FORMAT_MOD_BROADCOM_SAND128 > > - YUV420: > fourcc: DRM_FORMAT_YUV420 > diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp > index e8b3eb9c1394..bfd662b0de47 100644 > --- a/src/libcamera/v4l2_pixelformat.cpp > +++ b/src/libcamera/v4l2_pixelformat.cpp > @@ -103,6 +103,10 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{ > { formats::NV12, "Y/CbCr 4:2:0" } }, > { V4L2PixelFormat(V4L2_PIX_FMT_NV12M), > { formats::NV12, "Y/CbCr 4:2:0 (N-C)" } }, > + { V4L2PixelFormat(V4L2_PIX_FMT_NV12MT_COL128), > + { formats::NV12MT_COL128, "Y/CbCr 4:2:0 (128 col)" } }, > + { V4L2PixelFormat(V4L2_PIX_FMT_NV12MT_10_COL128), > + { formats::NV12MT_10_COL128, "10-bit Y/CbCr 4:2:0 (128 col)" } }, > { V4L2PixelFormat(V4L2_PIX_FMT_NV21), > { formats::NV21, "Y/CrCb 4:2:0" } }, > { V4L2PixelFormat(V4L2_PIX_FMT_NV21M),
diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml index 2d54d391ca01..3bf010c47aa6 100644 --- a/src/libcamera/formats.yaml +++ b/src/libcamera/formats.yaml @@ -73,6 +73,12 @@ formats: fourcc: DRM_FORMAT_NV24 - NV42: fourcc: DRM_FORMAT_NV42 + - NV12MT_COL128: + fourcc: DRM_FORMAT_NV12 + mod: DRM_FORMAT_MOD_BROADCOM_SAND128 + - NV12MT_10_COL128: + fourcc: DRM_FORMAT_P030 + mod: DRM_FORMAT_MOD_BROADCOM_SAND128 - YUV420: fourcc: DRM_FORMAT_YUV420 diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp index e8b3eb9c1394..bfd662b0de47 100644 --- a/src/libcamera/v4l2_pixelformat.cpp +++ b/src/libcamera/v4l2_pixelformat.cpp @@ -103,6 +103,10 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{ { formats::NV12, "Y/CbCr 4:2:0" } }, { V4L2PixelFormat(V4L2_PIX_FMT_NV12M), { formats::NV12, "Y/CbCr 4:2:0 (N-C)" } }, + { V4L2PixelFormat(V4L2_PIX_FMT_NV12MT_COL128), + { formats::NV12MT_COL128, "Y/CbCr 4:2:0 (128 col)" } }, + { V4L2PixelFormat(V4L2_PIX_FMT_NV12MT_10_COL128), + { formats::NV12MT_10_COL128, "10-bit Y/CbCr 4:2:0 (128 col)" } }, { V4L2PixelFormat(V4L2_PIX_FMT_NV21), { formats::NV21, "Y/CrCb 4:2:0" } }, { V4L2PixelFormat(V4L2_PIX_FMT_NV21M),
Add the NV12MT_COL128 (NV12 8-bit) and NV12MT_10_COL128 (P030 10-bit) column layout pixel formats available from the PiSP Backend hardware. Map the matching V4L2 FourCCs to the libcamera::formats conversion table. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/libcamera/formats.yaml | 6 ++++++ src/libcamera/v4l2_pixelformat.cpp | 4 ++++ 2 files changed, 10 insertions(+)