From patchwork Fri Jun 26 11:54:01 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 27057 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 58BD0C3301 for ; Fri, 26 Jun 2026 12:00:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 524BA658FA; Fri, 26 Jun 2026 14:00:50 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="PZaBmfJ4"; dkim-atps=neutral Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 24C75658F2 for ; Fri, 26 Jun 2026 14:00:48 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-49254e68922so230735e9.0 for ; Fri, 26 Jun 2026 05:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1782475248; x=1783080048; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YJ2j2YFI2gtwpHQ6GxpM81KxZWVYfpTifYHhAI9CDqg=; b=PZaBmfJ4KMhYMMTqAeCjb5eOmRu/pbhiUJX0Xj1E8DmulYspeb0IkkOj+HUdNT/dEo 2tZOY1HC/r6sNctxRttxg4Y/qp/2kiBw2B7Ok7u//VxqNoQ9eEFeTwFR0Z5W187upMEs DBJC6gmuUq66lEdmo+h0/x2tiQqqDXdy4PXMjsE/q316rzfR+JzxDtfB02FnMI9LaO/O Y6qpYV6rniEvavAbsFvC52O0Mwsxa3ckWuIjQDdn1WV1NUcqQKmmH3yugEoOCxNbLk4Q McVpPPTvcXC1gbIvFrP4nM2qJkHEXtNlHLMr5AH41RRGMhvejd+7VHPMKk5R10/8TDTj st2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782475248; x=1783080048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YJ2j2YFI2gtwpHQ6GxpM81KxZWVYfpTifYHhAI9CDqg=; b=H72l54l46WykvSRu85dN5I5NyMyyvAARp0wKN0I248yVdOz76FdbbZUmg+d1xlxxf7 ub0mDF1fZyAuspfoR2IbCaD+AGwdxTN14F6B8VHoYVDY/N6MwS1a15slmrbNJNdUEYvg 46VueLtzCcsLsxZ2CgJX/9F8m03eBFrCGfgXapxsizxRs+dVgACtH793aRZezlKKSRxg +FrrP5mux4q9nNDBF443UGEvQqfTBvRmHZJjSEbe/OIdKVqr3KbFJiyPVKNChjUnSGWw EyqUWeZ42AutMH4/iCkXcxNsDLrO9AIf0hDsOjl/sRxWo8bPeqVV04HAfFQqtCWCFop3 jXag== X-Gm-Message-State: AOJu0YxuIiDyFHFefkbkRc0v/fWyuPXAhMZelHBAkvnWCOw5yi44cHCf NVVRbidYUOKEwV1cnTbAjLW+FsLjP5c/dcAC3jEyJ1hxvV5KtdO2hUAFLztqtB6yp0iTnVm/wOb VpP74khw= X-Gm-Gg: AfdE7clau2W7ZzlpnCZOXoMwPaqebuXFqF3uoBBiu0MNXFAem6vsNrngDiwj/VUMs/2 qvyIYvUm1bF1DZfEDF+zYCcNoihUuzi5su2+z1Gl6CmqJQQJWCUdM5kPypfMccBCr4T2MoZ2gFY dzMlqOrZdoz/DnK1GWH0Go+LqqzmFFzBbB0EyxbAVJeAXL8VSivd8dLZvG6LF4NNjIZLq1E0DCX k3wtWWsZN7zok/EsLzz0kMwX9vkMnTsGeyLHxL78R3SRDrDD1jjfDv9XBBSWLAXYFhMlcLO5ylO wLNfRTSCj8yWZCo3naYC897ZRrv74eWDTE2qKe0YdJtnj8FIgGmlWpFgD6UJLM+TMATbk2broKa EIidEvwZzAZTW2ECibjqEGwLHO6ErI044NWNW3INgKLW+6A2dF1nRvo6XDH88QaT5c42M3BC8QG IBxMVWq1Bn38IAarmPFlr2H/UWMdKDPMXq3lyjdQZVOeiYi1Gk+6ShsGdlRk4cUTjN/KnmDqOxu gJivMa9XCgsafvHEy0iD/vyEL8y/fuMo2NKtNnFyjbO53Pzh4zOgXxziHmd9W/42Fr3g+RxRJUX PITk3MY0TN57hl3FFV3SLgHkxR8+cIQ= X-Received: by 2002:a05:600c:83c4:b0:492:6f90:d92a with SMTP id 5b1f17b1804b1-4926f90d94bmr5510385e9.4.1782475247549; Fri, 26 Jun 2026 05:00:47 -0700 (PDT) Received: from naush-dell.pitowers.org ([2a00:1098:3142:1f:9337:c770:257e:d321]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4926c02088dsm39163015e9.0.2026.06.26.05.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 05:00:47 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck Subject: [PATCH 1/3] utils: codegen: gen-formats: Resolve Broadcom SAND modifiers Date: Fri, 26 Jun 2026 12:54:01 +0100 Message-ID: <20260626120041.627376-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260626120041.627376-1-naush@raspberrypi.com> References: <20260626120041.627376-1-naush@raspberrypi.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The Broadcom SAND (coloumn mode) modifiers are defined through the fourcc_mod_broadcom_code() column-height helper rather than a plain fourcc_mod_code(), so the generator script cannot not resolve them. Collapse line continuations and match the helper form so formats may reference the DRM_FORMAT_MOD_BROADCOM_SAND* modifiers. Signed-off-by: Naushir Patuck --- utils/codegen/gen-formats.py | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/utils/codegen/gen-formats.py b/utils/codegen/gen-formats.py index 740790e8f1a6..add04558f65f 100755 --- a/utils/codegen/gen-formats.py +++ b/utils/codegen/gen-formats.py @@ -18,13 +18,22 @@ class DRMFourCC(object): format_regex = re.compile(r"#define (DRM_FORMAT_[A-Z0-9_]+)[ \t]+fourcc_code\(('.', '.', '.', '.')\)") mod_vendor_regex = re.compile(r"#define DRM_FORMAT_MOD_VENDOR_([A-Z0-9_]+)[ \t]+([0-9a-fA-Fx]+)") mod_regex = re.compile(r"#define ([A-Za-z0-9_]+)[ \t]+fourcc_mod_code\(([A-Z0-9_]+), ([0-9a-fA-Fx]+)\)") + # Broadcom SAND modifiers are defined indirectly via a _COL_HEIGHT(v) helper + # that wraps fourcc_mod_broadcom_code(, v) (which injects the BROADCOM + # vendor). Match that helper, strip _COL_HEIGHT to recover the convenience + # macro name, and use as the value - valid as the convenience macro is + # the height-0 case, which contributes nothing to it. + mod_brcm_regex = re.compile(r"#define (DRM_FORMAT_MOD_BROADCOM_SAND[0-9]+)_COL_HEIGHT\(v\)" + r"[ \t]+fourcc_mod_broadcom_code\(([0-9]+), v\)") def __init__(self, file): self.formats = {} self.vendors = {} self.mods = {} - for line in file: + # Collapse line continuations so multi-line macros match on one line. + lines = re.sub(r'\\[ \t]*\n', ' ', file.read()).splitlines() + for line in lines: match = DRMFourCC.format_regex.match(line) if match: format, fourcc = match.groups() @@ -43,6 +52,12 @@ class DRMFourCC(object): self.mods[mod] = (vendor, int(value, 0)) continue + match = DRMFourCC.mod_brcm_regex.match(line) + if match: + mod, code = match.groups() + self.mods[mod] = ('BROADCOM', int(code)) + continue + def fourcc(self, name): return self.formats[name] From patchwork Fri Jun 26 11:54:02 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 27058 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 35BEEC3302 for ; Fri, 26 Jun 2026 12:00:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7A54565EDB; Fri, 26 Jun 2026 14:00:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="MZz6a6oR"; dkim-atps=neutral Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A1736658FA for ; Fri, 26 Jun 2026 14:00:48 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-490d6730461so872195e9.3 for ; Fri, 26 Jun 2026 05:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1782475248; x=1783080048; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jjn/Cv38r0CBDn6xvS/obDVXTgG4SR205+YKmG/PUv0=; b=MZz6a6oRSMrwSBwRG0Il87Bfk73xIThDVbbeFwKU0lE1R7wtaM6GaDxdbsVnPHy3QF euUSYSFB0iMujOqrrTwEt0YW6AGRzDZ4xCeKI20EiSX2HVYNLiduebvuo8f4ID0uysZa iFlXcJ96GywX6XcQZHci3OVK/r1QeWtXUaEDoE0M+DpbJTUOq+HMz5EfTE3U7mjDevkT UQNmlSyFbFSE0gLVTavzkMrmEHN/8GNNXavoTmKqap03dvmZRNUKns+Olcxg8elP7Us6 57QKX5cYzpT06t2d+zmas1OTaAyPNGGj03XyKjx/AouaHNzkUr6vfm9cNq8SUKAQUKHP pGgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782475248; x=1783080048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jjn/Cv38r0CBDn6xvS/obDVXTgG4SR205+YKmG/PUv0=; b=amb9OoUi/2MU1D8nCAVd+2Ahz7qn7b3z/YIT73KFzYyXjWe5hWFkzV1n7ZOIWagebF eYewkFeC60KTDkGxWgd0Xv6U7VsNW6Rm0yG3mU0XmDizJASoxF5YQ8XQTb6FZ07sgVBs x9FdiBp6xLy5L1bl5j/VpBq093ibTDytjesIPp6tIvDGQJcHRmxFF2zPs0rKnITndTpY oo2gJFyFI6KMQeOAiMJdxL2MW8XBBd+mdv2ax0jcTwyazDVHjIbrLRGxR6VnMrkjEdT8 dxB56kOUYUgOQmTGuvNGlwIw/h1uKY0kzGtP/PXh+lWEOpP7e17O/V0V6uTHZ3ZLQ6qS v5PQ== X-Gm-Message-State: AOJu0YxUNmQ3E3LSEacj2i9Xv3JsBK5MsmbNKJeD3/Q6P8ftPoa0t5IO 6Dl5yZx68Fd6QQ5JVvO8IOuY0Pr9HM3w/a3aKtH3j63aRx85YAQT3Qa1417KtlOidyecxbVbpJ2 uGO7nUBc= X-Gm-Gg: AfdE7ckOvEV6CYXz56tDzG14wfo/jRvGl18nqXA86PuSXi9jWYA6HhGJCAuRDUpQERZ iIIwRoG6Yzxq/kF2PQvxKsvU4wGcU3/sZf1+EVgnvRWQFzG+EgsroKNPVMtPwAOAYSPWcwmmH4O o7FxTM/w8+LXBjcI7yss1X6qExdW+Ml3kIhTj7n57PSpGjZko+Xjul7GVW2W/ELRSKCwSubBR92 25rDvEm3eEl8l8WinwWMHQMILexelhwlOBXbFsPR7s0n/CVy3oXlq4iNw41IfyZ1fFwO80Fj8F/ tWmkR2SjMV2qthvbjJayOaoRKHzZCnqvlLJZaXEB4wdeOYelHSZGf2CuR+H1z9rGG7C0CJNgHFo sQSLDx3m3P+MQbuB/zvLVljWW8+AcxSZ+Jn8hoHvbfIK9qOz9TDGOgTfx6jYVs6hNalMTn4W02c NhfjpCzzW/+zf/dALyfXQAa3LLh/vnhTPk/LZ/Ep7HHRZswPaVl/oqaz3aIdiZTsHBm93QxqrpT EJNQi67RDMQPwcounO3qlLPwh1yUg2Bi6lfr04PNgjIrd0o5+3mW4sBxVIPsHh0k5PXCc2v2wXL YSEK5fFC5sZ6fGlZ72Yr X-Received: by 2002:a05:600c:e547:20b0:492:2ea0:c1cd with SMTP id 5b1f17b1804b1-492668934admr35266995e9.5.1782475248156; Fri, 26 Jun 2026 05:00:48 -0700 (PDT) Received: from naush-dell.pitowers.org ([2a00:1098:3142:1f:9337:c770:257e:d321]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4926c02088dsm39163015e9.0.2026.06.26.05.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 05:00:47 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck Subject: [PATCH 2/3] include: linux: videodev2: Add NV12MT_COL128 8/10-bit pixel formats Date: Fri, 26 Jun 2026 12:54:02 +0100 Message-ID: <20260626120041.627376-3-naush@raspberrypi.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260626120041.627376-1-naush@raspberrypi.com> References: <20260626120041.627376-1-naush@raspberrypi.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add the V4L2_PIX_FMT_NV12MT_COL128 and V4L2_PIX_FMT_NV12MT_10_COL128 4CCs. These formats are available from the PiSP Backend hardware. Signed-off-by: Naushir Patuck --- include/linux/videodev2.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 8bccad84ff83..0c6c4c6831d9 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@ -670,6 +670,9 @@ struct v4l2_pix_format { #define V4L2_PIX_FMT_NV12MT_16X16 v4l2_fourcc('V', 'M', '1', '2') /* 12 Y/CbCr 4:2:0 16x16 tiles */ #define V4L2_PIX_FMT_NV12M_8L128 v4l2_fourcc('N', 'A', '1', '2') /* Y/CbCr 4:2:0 8x128 tiles */ #define V4L2_PIX_FMT_NV12M_10BE_8L128 v4l2_fourcc_be('N', 'T', '1', '2') /* Y/CbCr 4:2:0 10-bit 8x128 tiles */ +#define V4L2_PIX_FMT_NV12MT_COL128 v4l2_fourcc('N', 'c', '1', '2') /* 12 Y/CbCr 4:2:0 128 pixel wide column */ +#define V4L2_PIX_FMT_NV12MT_10_COL128 v4l2_fourcc('N', 'c', '3', '0') + /* Y/CbCr 4:2:0 10bpc, 3x10 packed as 4 bytes in a 128 bytes / 96 pixel wide column */ /* Bayer formats - see http://www.siliconimaging.com/RGB%20Bayer.htm */ #define V4L2_PIX_FMT_SBGGR8 v4l2_fourcc('B', 'A', '8', '1') /* 8 BGBG.. GRGR.. */ From patchwork Fri Jun 26 11:54:03 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 27059 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0950DC3303 for ; Fri, 26 Jun 2026 12:00:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 670AB6590C; Fri, 26 Jun 2026 14:00:54 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="RBrzFJlt"; dkim-atps=neutral Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6020865ED6 for ; Fri, 26 Jun 2026 14:00:49 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4926e31093dso283215e9.1 for ; Fri, 26 Jun 2026 05:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1782475249; x=1783080049; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uxLmtANUz+sijmDERS7OTwf5C2UyljPMW81HUU2XYr4=; b=RBrzFJlt3v2o65YpDUL34XuE95RJeJtv07E/BQoGMor1XoMJxVH2Z913sflddIIy19 yHHvoYztSOJ7HJ7+sqDC/uK0eowon0dMD2ur8jN99o9PPXibFL+IzOZYcOdB9gsD8Q7W dPdDaiQw+rGrShtaMB9QtzRDhYaIaG/54Vy6o/biESThuRH6EA0c26B3WOHZxz82z7tv QXi8XdmvvGDDDXLuvU43p7AWhD6tEiHld9hqvQnvaa05lo3Cy9hrs8oiWcInx3t4dsGt eeb6rUdZgKC8/XfnXeSRIbv57MeCMkhv7SSY9hMHGryGgfukcXf0AfOkQfKiHztejJ85 j25g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782475249; x=1783080049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=uxLmtANUz+sijmDERS7OTwf5C2UyljPMW81HUU2XYr4=; b=jDDq5UqREHbknJXNX6rK4YOaIvPASBfqn1CyTDMsbrabcsoPrGnSprjMUOfzJlK/UQ S4GlALv1+cu2m201RtrT+mvvnYWxNZOwqvSkxU2bWbvbyWJVQp9fIehbUW1LOMBPeRN8 toq9kmwrmZPRxQjeehJ/uChoE2AWgyR8zF5REhSrnhWY29KSWtc2oGgbhJa5l2q1v5uG 5DoBljuEXFaSxt2nuPaVjPw9CVI7rtBV63m8P0pF5eaacQmqatFAJ8nC+LJoLu/K/mFE gAa6XtYc+oPzXlnBF7UNetLDRcaCQv1y6L4naw8JUXMTkS8QNrwVblxfluALy2kFd6hh SyIw== X-Gm-Message-State: AOJu0Yzrlcm5U/tBgvx9O7MN3VOkt7h82LD9V+n4KUvSvLGOy+xP9vX/ ZJzRlw8hG3oBF/E9M76IH7BLdEWDJZAjJ2DQFpkZ/wW7TtVx7dcUyX+zLG6Ki+st78IBFh3LyCX mZNF0tVE= X-Gm-Gg: AfdE7cltbNKTU82wLeJQ4os6BxOdFSnEM6jusHDrQ/0CiEw9HL7T8yLeT3eO78qmR7v dJitBja7zEoWhuH1SnNcgpfYfMh2x+FdWxQ109MrlLOyPfegrIAYhi1sVDgFDfAUT4utecYnbMa Np1R0H17aaMnsBrl4WzC4Ds6WgyqOwmdNV9nCp0HirDbvNbkkUsg30OO+/a7IlLv+RJTeWs7GP8 2zYAzGfoLXS0A+ZB8tmTjKLmFkER6fG9mePPOftLmNEX6SBtR/wjKLBpgQYIPy7t+fdoHfMHokB zPKvb/l0aRG6f7pKaZV3pBlJTJEwEC9AMhiaLpigphfKPBmwfBqOg/c3R2R9oYbxQHwI3mfL6nT x3L6AWRrwKhvT1wNMn4M0JbnvyPb+oqjxgobQxxlbZg5WIwy+H7ON28pQ6Su9Nhg8lUagVP0eBl LRAjbQa7C7/Mo8kd3EXMWugIh8EhHcxpqMVfdN2pQP62YJi0ByxRK8TxxMV67l2ZB4wj1drGnPt 4p2GEftS2873/BYCXbDbOzVXruHJDsRKOrhR8kdh8APXF9xoVC3//rC5Rl4I54PMK2qPx8I7gwZ n9To8Lbcw1bBD86gaWzD X-Received: by 2002:a05:600c:1f8d:b0:492:506a:f48c with SMTP id 5b1f17b1804b1-49266885a01mr50773075e9.4.1782475248792; Fri, 26 Jun 2026 05:00:48 -0700 (PDT) Received: from naush-dell.pitowers.org ([2a00:1098:3142:1f:9337:c770:257e:d321]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4926c02088dsm39163015e9.0.2026.06.26.05.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 05:00:48 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck Subject: [PATCH 3/3] libcamera: v4l2_pixelformat: Add NV12MT_COL128 8/10-bit pixel formats Date: Fri, 26 Jun 2026 12:54:03 +0100 Message-ID: <20260626120041.627376-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260626120041.627376-1-naush@raspberrypi.com> References: <20260626120041.627376-1-naush@raspberrypi.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add the NV12MT_COL128 (NV12 8-bit) and NV12MT_10_COL128 (P030 10-bit) column layout pixel formats available from the PiSP Backend hardware. Map the matching V4L2 FourCCs to the libcamera::formats conversion table. Signed-off-by: Naushir Patuck --- src/libcamera/formats.yaml | 6 ++++++ src/libcamera/v4l2_pixelformat.cpp | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml index 2d54d391ca01..3bf010c47aa6 100644 --- a/src/libcamera/formats.yaml +++ b/src/libcamera/formats.yaml @@ -73,6 +73,12 @@ formats: fourcc: DRM_FORMAT_NV24 - NV42: fourcc: DRM_FORMAT_NV42 + - NV12MT_COL128: + fourcc: DRM_FORMAT_NV12 + mod: DRM_FORMAT_MOD_BROADCOM_SAND128 + - NV12MT_10_COL128: + fourcc: DRM_FORMAT_P030 + mod: DRM_FORMAT_MOD_BROADCOM_SAND128 - YUV420: fourcc: DRM_FORMAT_YUV420 diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp index e8b3eb9c1394..bfd662b0de47 100644 --- a/src/libcamera/v4l2_pixelformat.cpp +++ b/src/libcamera/v4l2_pixelformat.cpp @@ -103,6 +103,10 @@ const std::map vpf2pf{ { formats::NV12, "Y/CbCr 4:2:0" } }, { V4L2PixelFormat(V4L2_PIX_FMT_NV12M), { formats::NV12, "Y/CbCr 4:2:0 (N-C)" } }, + { V4L2PixelFormat(V4L2_PIX_FMT_NV12MT_COL128), + { formats::NV12MT_COL128, "Y/CbCr 4:2:0 (128 col)" } }, + { V4L2PixelFormat(V4L2_PIX_FMT_NV12MT_10_COL128), + { formats::NV12MT_10_COL128, "10-bit Y/CbCr 4:2:0 (128 col)" } }, { V4L2PixelFormat(V4L2_PIX_FMT_NV21), { formats::NV21, "Y/CrCb 4:2:0" } }, { V4L2PixelFormat(V4L2_PIX_FMT_NV21M),