| Message ID | 20260618123844.656396-6-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Barnabás On Thu, Jun 18, 2026 at 02:38:22PM +0200, Barnabás Pőcze wrote: > Instead of manually setting `FrameMetadata::status`, simply call the > appropriate `cancel()` method. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/libcamera/software_isp/software_isp.cpp | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp > index 1b316c54c6..c73a16ce0a 100644 > --- a/src/libcamera/software_isp/software_isp.cpp > +++ b/src/libcamera/software_isp/software_isp.cpp > @@ -406,15 +406,13 @@ void SoftwareIsp::stop() > ipa_->stop(); > > for (auto buffer : queuedOutputBuffers_) { > - FrameMetadata &metadata = buffer->_d()->metadata(); > - metadata.status = FrameMetadata::FrameCancelled; > + buffer->_d()->cancel(); > outputBufferReady.emit(buffer); > } > queuedOutputBuffers_.clear(); > > for (auto buffer : queuedInputBuffers_) { > - FrameMetadata &metadata = buffer->_d()->metadata(); > - metadata.status = FrameMetadata::FrameCancelled; > + buffer->_d()->cancel(); > inputBufferReady.emit(buffer); > } > queuedInputBuffers_.clear(); > -- > 2.54.0 >
On Thu, Jun 18, 2026 at 02:38:22PM +0200, Barnabás Pőcze wrote: > Instead of manually setting `FrameMetadata::status`, simply call the > appropriate `cancel()` method. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/software_isp/software_isp.cpp | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp > index 1b316c54c6..c73a16ce0a 100644 > --- a/src/libcamera/software_isp/software_isp.cpp > +++ b/src/libcamera/software_isp/software_isp.cpp > @@ -406,15 +406,13 @@ void SoftwareIsp::stop() > ipa_->stop(); > > for (auto buffer : queuedOutputBuffers_) { > - FrameMetadata &metadata = buffer->_d()->metadata(); > - metadata.status = FrameMetadata::FrameCancelled; > + buffer->_d()->cancel(); > outputBufferReady.emit(buffer); > } > queuedOutputBuffers_.clear(); > > for (auto buffer : queuedInputBuffers_) { > - FrameMetadata &metadata = buffer->_d()->metadata(); > - metadata.status = FrameMetadata::FrameCancelled; > + buffer->_d()->cancel(); > inputBufferReady.emit(buffer); > } > queuedInputBuffers_.clear();
diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index 1b316c54c6..c73a16ce0a 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -406,15 +406,13 @@ void SoftwareIsp::stop() ipa_->stop(); for (auto buffer : queuedOutputBuffers_) { - FrameMetadata &metadata = buffer->_d()->metadata(); - metadata.status = FrameMetadata::FrameCancelled; + buffer->_d()->cancel(); outputBufferReady.emit(buffer); } queuedOutputBuffers_.clear(); for (auto buffer : queuedInputBuffers_) { - FrameMetadata &metadata = buffer->_d()->metadata(); - metadata.status = FrameMetadata::FrameCancelled; + buffer->_d()->cancel(); inputBufferReady.emit(buffer); } queuedInputBuffers_.clear();
Instead of manually setting `FrameMetadata::status`, simply call the appropriate `cancel()` method. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/libcamera/software_isp/software_isp.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)