From patchwork Thu Jun 18 12:38:22 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26969 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 731AEC3302 for ; Thu, 18 Jun 2026 12:39:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 622A3656FB; Thu, 18 Jun 2026 14:38:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UKkEGHma"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 71EE262B32 for ; Thu, 18 Jun 2026 14:38:49 +0200 (CEST) Received: from pb-laptop.local (185.182.214.63.nat.pool.zt.hu [185.182.214.63]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8E1CF2F8 for ; Thu, 18 Jun 2026 14:38:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781786294; bh=7pk2akcIO+LKapSx5LH2m1u6MaKxxgke+i79MVQIb/I=; h=From:To:Subject:Date:In-Reply-To:References:From; b=UKkEGHmauLG8/BH+N451VSynDZMgTDNSS9rvIH/XcMoniugJF+J5iYadwTWJeqI38 gm2Oib7H7ouZilgCA3cgPxvruVKAQXrllg5W8EYV5+qJKd2Ihe95vG+CFzctrtxpaU fGeDf7UaBdo8ulfTcntC1UgYhEn6BgaDzNSPdl1I= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 05/27] libcamera: software_isp: Replace open-coded buffer cancellation Date: Thu, 18 Jun 2026 14:38:22 +0200 Message-ID: <20260618123844.656396-6-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> References: <20260618123844.656396-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Instead of manually setting `FrameMetadata::status`, simply call the appropriate `cancel()` method. Signed-off-by: Barnabás Pőcze --- src/libcamera/software_isp/software_isp.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index 1b316c54c6..c73a16ce0a 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -406,15 +406,13 @@ void SoftwareIsp::stop() ipa_->stop(); for (auto buffer : queuedOutputBuffers_) { - FrameMetadata &metadata = buffer->_d()->metadata(); - metadata.status = FrameMetadata::FrameCancelled; + buffer->_d()->cancel(); outputBufferReady.emit(buffer); } queuedOutputBuffers_.clear(); for (auto buffer : queuedInputBuffers_) { - FrameMetadata &metadata = buffer->_d()->metadata(); - metadata.status = FrameMetadata::FrameCancelled; + buffer->_d()->cancel(); inputBufferReady.emit(buffer); } queuedInputBuffers_.clear();