| Message ID | 20260423230059.3180987-25-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
2026. 04. 24. 1:00 keltezéssel, Laurent Pinchart írta: > The unit test contains a few typos in error messages. Fix them. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > test/yaml-parser.cpp | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp > index e8fd9ad61cd0..a4b26c17e1f9 100644 > --- a/test/yaml-parser.cpp > +++ b/test/yaml-parser.cpp > @@ -71,13 +71,13 @@ protected: > /* Test parsing invalid YAML file. */ > File file{ invalidYamlFile_ }; > if (!file.open(File::OpenModeFlag::ReadOnly)) { > - std::cerr << "Fail to open invalid YAML file" << std::endl; > + std::cerr << "Failed to open invalid YAML file" << std::endl; > return TestFail; > } > > std::unique_ptr<ValueNode> root = YamlParser::parse(file); > if (root) { > - std::cerr << "Invalid YAML file parse successfully" << std::endl; > + std::cerr << "Invalid YAML file parsed successfully" << std::endl; > return TestFail; > } > > @@ -199,14 +199,14 @@ protected: > auto &level1Obj = (*root)["level1"]; > > if (!level1Obj.isDictionary()) { > - std::cerr << "level1 object fail to parse as Dictionary" << std::endl; > + std::cerr << "level1 object failed to parse as Dictionary" << std::endl; > return TestFail; > } > > auto &level2Obj = level1Obj["level2"]; > > if (!level2Obj.isList() || level2Obj.size() != 2) { > - std::cerr << "level2 object should be a 2 elements list" << std::endl; > + std::cerr << "level2 object should be a 2 element list" << std::endl; > return TestFail; > } > > @@ -215,7 +215,7 @@ protected: > firstElement.size() != 2 || > firstElement[0].get<int32_t>(0) != 1 || > firstElement[1].get<int32_t>(0) != 2) { > - std::cerr << "The first element of level2 object fail to parse as integer list" << std::endl; > + std::cerr << "The first element of level2 object failed to parse as integer list" << std::endl; > return TestFail; > } > > @@ -231,7 +231,7 @@ protected: > !secondElement.contains("two") || > secondElement["one"].get<int32_t>(0) != 1 || > secondElement["two"].get<int32_t>(0) != 2) { > - std::cerr << "The second element of level2 object fail to parse as dictionary" << std::endl; > + std::cerr << "The second element of level2 object failed to parse as dictionary" << std::endl; > return TestFail; > } > > -- > Regards, > > Laurent Pinchart >
Hi Laurent, Quoting Laurent Pinchart (2026-04-24 00:00:46) > The unit test contains a few typos in error messages. Fix them. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > test/yaml-parser.cpp | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp > index e8fd9ad61cd0..a4b26c17e1f9 100644 > --- a/test/yaml-parser.cpp > +++ b/test/yaml-parser.cpp > @@ -71,13 +71,13 @@ protected: > /* Test parsing invalid YAML file. */ > File file{ invalidYamlFile_ }; > if (!file.open(File::OpenModeFlag::ReadOnly)) { > - std::cerr << "Fail to open invalid YAML file" << std::endl; > + std::cerr << "Failed to open invalid YAML file" << std::endl; > return TestFail; > } > > std::unique_ptr<ValueNode> root = YamlParser::parse(file); > if (root) { > - std::cerr << "Invalid YAML file parse successfully" << std::endl; > + std::cerr << "Invalid YAML file parsed successfully" << std::endl; > return TestFail; > } > > @@ -199,14 +199,14 @@ protected: > auto &level1Obj = (*root)["level1"]; > > if (!level1Obj.isDictionary()) { > - std::cerr << "level1 object fail to parse as Dictionary" << std::endl; > + std::cerr << "level1 object failed to parse as Dictionary" << std::endl; > return TestFail; > } > > auto &level2Obj = level1Obj["level2"]; > > if (!level2Obj.isList() || level2Obj.size() != 2) { > - std::cerr << "level2 object should be a 2 elements list" << std::endl; > + std::cerr << "level2 object should be a 2 element list" << std::endl; > return TestFail; > } > > @@ -215,7 +215,7 @@ protected: > firstElement.size() != 2 || > firstElement[0].get<int32_t>(0) != 1 || > firstElement[1].get<int32_t>(0) != 2) { > - std::cerr << "The first element of level2 object fail to parse as integer list" << std::endl; > + std::cerr << "The first element of level2 object failed to parse as integer list" << std::endl; > return TestFail; > } > > @@ -231,7 +231,7 @@ protected: > !secondElement.contains("two") || > secondElement["one"].get<int32_t>(0) != 1 || > secondElement["two"].get<int32_t>(0) != 2) { > - std::cerr << "The second element of level2 object fail to parse as dictionary" << std::endl; > + std::cerr << "The second element of level2 object failed to parse as dictionary" << std::endl; Thanks for doing this, Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com> > return TestFail; > } > > -- > Regards, > > Laurent Pinchart >
diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp index e8fd9ad61cd0..a4b26c17e1f9 100644 --- a/test/yaml-parser.cpp +++ b/test/yaml-parser.cpp @@ -71,13 +71,13 @@ protected: /* Test parsing invalid YAML file. */ File file{ invalidYamlFile_ }; if (!file.open(File::OpenModeFlag::ReadOnly)) { - std::cerr << "Fail to open invalid YAML file" << std::endl; + std::cerr << "Failed to open invalid YAML file" << std::endl; return TestFail; } std::unique_ptr<ValueNode> root = YamlParser::parse(file); if (root) { - std::cerr << "Invalid YAML file parse successfully" << std::endl; + std::cerr << "Invalid YAML file parsed successfully" << std::endl; return TestFail; } @@ -199,14 +199,14 @@ protected: auto &level1Obj = (*root)["level1"]; if (!level1Obj.isDictionary()) { - std::cerr << "level1 object fail to parse as Dictionary" << std::endl; + std::cerr << "level1 object failed to parse as Dictionary" << std::endl; return TestFail; } auto &level2Obj = level1Obj["level2"]; if (!level2Obj.isList() || level2Obj.size() != 2) { - std::cerr << "level2 object should be a 2 elements list" << std::endl; + std::cerr << "level2 object should be a 2 element list" << std::endl; return TestFail; } @@ -215,7 +215,7 @@ protected: firstElement.size() != 2 || firstElement[0].get<int32_t>(0) != 1 || firstElement[1].get<int32_t>(0) != 2) { - std::cerr << "The first element of level2 object fail to parse as integer list" << std::endl; + std::cerr << "The first element of level2 object failed to parse as integer list" << std::endl; return TestFail; } @@ -231,7 +231,7 @@ protected: !secondElement.contains("two") || secondElement["one"].get<int32_t>(0) != 1 || secondElement["two"].get<int32_t>(0) != 2) { - std::cerr << "The second element of level2 object fail to parse as dictionary" << std::endl; + std::cerr << "The second element of level2 object failed to parse as dictionary" << std::endl; return TestFail; }
The unit test contains a few typos in error messages. Fix them. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- test/yaml-parser.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)