[v3,14/37] libcamera: value_node: Add constructor with value
diff mbox series

Message ID 20260423230059.3180987-15-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • libcamera: Global configuration file improvements
Related show

Commit Message

Laurent Pinchart April 23, 2026, 11 p.m. UTC 
The new constructor takes a value, allowing creation of a leaf ValueNode
with a value in a single operation instead of having to call set() on an
empty node.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>
---
Changes since v1:

- Initialize type_ to Empty
---
 include/libcamera/internal/value_node.h | 8 ++++++++
 src/libcamera/value_node.cpp            | 7 +++++++
 2 files changed, 15 insertions(+)

Patch
diff mbox series 

diff --git a/include/libcamera/internal/value_node.h b/include/libcamera/internal/value_node.h
index d4533df1a643..bcf2c8ecc90e 100644
--- a/include/libcamera/internal/value_node.h
+++ b/include/libcamera/internal/value_node.h
@@ -143,6 +143,14 @@  public:
 #endif /* __DOXYGEN__ */
 
 	ValueNode();
+
+	template<typename T>
+	ValueNode(T &&value)
+		: type_(Type::Empty)
+	{
+		set(std::forward<T>(value));
+	}
+
 	~ValueNode();
 
 	bool isValue() const
diff --git a/src/libcamera/value_node.cpp b/src/libcamera/value_node.cpp
index 2d1642c2dd06..324419f02bb6 100644
--- a/src/libcamera/value_node.cpp
+++ b/src/libcamera/value_node.cpp
@@ -44,6 +44,13 @@  ValueNode::ValueNode()
 {
 }
 
+/**
+ * \fn template<typename T> ValueNode::ValueNode(T &&value)
+ * \brief Construct a ValueNode instance with a value
+ * \tparam T Type of the value
+ * \param[in] value The value
+ */
+
 ValueNode::~ValueNode() = default;
 
 /**