[v1,2/3] libcamera: software_isp: debayer: Add missing `override`

26517 diff mbox series

Add the missing `override` specifiers in the derived classes of `Debayer`.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/software_isp/debayer_cpu.h | 18 +++++++++---------
 src/libcamera/software_isp/debayer_egl.h | 18 +++++++++---------
 2 files changed, 18 insertions(+), 18 deletions(-)

Quoting Barnabás Pőcze (2026-04-13 12:47:12)
> Add the missing `override` specifiers in the derived classes of `Debayer`.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/software_isp/debayer_cpu.h | 18 +++++++++---------
>  src/libcamera/software_isp/debayer_egl.h | 18 +++++++++---------
>  2 files changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h
> index 05fecc8fe..39a0ea6ea 100644
> --- a/src/libcamera/software_isp/debayer_cpu.h
> +++ b/src/libcamera/software_isp/debayer_cpu.h
> @@ -36,16 +36,16 @@ public:
>  
>         int configure(const StreamConfiguration &inputCfg,
>                       const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,
> -                     bool ccmEnabled);
> -       Size patternSize(PixelFormat inputFormat);
> -       std::vector<PixelFormat> formats(PixelFormat input);
> +                     bool ccmEnabled) override;
> +       Size patternSize(PixelFormat inputFormat) override;
> +       std::vector<PixelFormat> formats(PixelFormat input) override;
>         std::tuple<unsigned int, unsigned int>
> -       strideAndFrameSize(const PixelFormat &outputFormat, const Size &size);
> -       void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams &params);
> -       int start();
> -       void stop();
> -       SizeRange sizes(PixelFormat inputFormat, const Size &inputSize);
> -       const SharedFD &getStatsFD() { return stats_->getStatsFD(); }
> +       strideAndFrameSize(const PixelFormat &outputFormat, const Size &size) override;
> +       void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams &params) override;
> +       int start() override;
> +       void stop() override;
> +       SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) override;
> +       const SharedFD &getStatsFD() override { return stats_->getStatsFD(); }
>  
>  private:
>         friend class DebayerCpuThread;
> diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h
> index bdde676f2..d563bfa55 100644
> --- a/src/libcamera/software_isp/debayer_egl.h
> +++ b/src/libcamera/software_isp/debayer_egl.h
> @@ -43,20 +43,20 @@ public:
>  
>         int configure(const StreamConfiguration &inputCfg,
>                       const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,
> -                     bool ccmEnabled);
> +                     bool ccmEnabled) override;
>  
> -       Size patternSize(PixelFormat inputFormat);
> +       Size patternSize(PixelFormat inputFormat) override;
>  
> -       std::vector<PixelFormat> formats(PixelFormat input);
> -       std::tuple<unsigned int, unsigned int> strideAndFrameSize(const PixelFormat &outputFormat, const Size &size);
> +       std::vector<PixelFormat> formats(PixelFormat input) override;
> +       std::tuple<unsigned int, unsigned int> strideAndFrameSize(const PixelFormat &outputFormat, const Size &size) override;
>  
> -       void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams &params);
> -       int start();
> -       void stop();
> +       void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams &params) override;
> +       int start() override;
> +       void stop() override;
>  
> -       const SharedFD &getStatsFD() { return stats_->getStatsFD(); }
> +       const SharedFD &getStatsFD() override { return stats_->getStatsFD(); }
>  
> -       SizeRange sizes(PixelFormat inputFormat, const Size &inputSize);
> +       SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) override;
>  
>  private:
>         static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);
> -- 
> 2.53.0
>