From patchwork Mon Apr 13 11:47:12 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 26517 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1FD8CC32F6 for ; Mon, 13 Apr 2026 11:47:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 75B6562E95; Mon, 13 Apr 2026 13:47:20 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MQT1dJyF"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B44FE62E7F for ; Mon, 13 Apr 2026 13:47:16 +0200 (CEST) Received: from pb-laptop.local (185.182.214.8.nat.pool.zt.hu [185.182.214.8]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D44927FE for ; Mon, 13 Apr 2026 13:45:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1776080744; bh=GPaHluTYFpcJK9VAXq+rFZ4cZl9SHze8WpG44US1exw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=MQT1dJyFkLXDMgCqMLUKh7BKasX5i/ExCSyPee7rhlC0z8Ba6Lg8pl5uyTW4q1Wyf dvSFE1EQP7PtcXZWB6EDPy7Rljf/49vtQrLSe6PMiE5m+SSj7OP9yoYBeJBMtN8Zjv gA+gS5tkYgu6v4dJ8Z23BWh5AIIhyiSdMkCoIELQ= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1 2/3] libcamera: software_isp: debayer: Add missing `override` Date: Mon, 13 Apr 2026 13:47:12 +0200 Message-ID: <20260413114713.426459-2-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413114713.426459-1-barnabas.pocze@ideasonboard.com> References: <20260413114713.426459-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add the missing `override` specifiers in the derived classes of `Debayer`. Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- src/libcamera/software_isp/debayer_cpu.h | 18 +++++++++--------- src/libcamera/software_isp/debayer_egl.h | 18 +++++++++--------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h index 05fecc8fe..39a0ea6ea 100644 --- a/src/libcamera/software_isp/debayer_cpu.h +++ b/src/libcamera/software_isp/debayer_cpu.h @@ -36,16 +36,16 @@ public: int configure(const StreamConfiguration &inputCfg, const std::vector> &outputCfgs, - bool ccmEnabled); - Size patternSize(PixelFormat inputFormat); - std::vector formats(PixelFormat input); + bool ccmEnabled) override; + Size patternSize(PixelFormat inputFormat) override; + std::vector formats(PixelFormat input) override; std::tuple - strideAndFrameSize(const PixelFormat &outputFormat, const Size &size); - void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms); - int start(); - void stop(); - SizeRange sizes(PixelFormat inputFormat, const Size &inputSize); - const SharedFD &getStatsFD() { return stats_->getStatsFD(); } + strideAndFrameSize(const PixelFormat &outputFormat, const Size &size) override; + void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms) override; + int start() override; + void stop() override; + SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) override; + const SharedFD &getStatsFD() override { return stats_->getStatsFD(); } private: friend class DebayerCpuThread; diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h index bdde676f2..d563bfa55 100644 --- a/src/libcamera/software_isp/debayer_egl.h +++ b/src/libcamera/software_isp/debayer_egl.h @@ -43,20 +43,20 @@ public: int configure(const StreamConfiguration &inputCfg, const std::vector> &outputCfgs, - bool ccmEnabled); + bool ccmEnabled) override; - Size patternSize(PixelFormat inputFormat); + Size patternSize(PixelFormat inputFormat) override; - std::vector formats(PixelFormat input); - std::tuple strideAndFrameSize(const PixelFormat &outputFormat, const Size &size); + std::vector formats(PixelFormat input) override; + std::tuple strideAndFrameSize(const PixelFormat &outputFormat, const Size &size) override; - void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms); - int start(); - void stop(); + void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms) override; + int start() override; + void stop() override; - const SharedFD &getStatsFD() { return stats_->getStatsFD(); } + const SharedFD &getStatsFD() override { return stats_->getStatsFD(); } - SizeRange sizes(PixelFormat inputFormat, const Size &inputSize); + SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) override; private: static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);