| Message ID | 20260405191443.1209948-4-laurent.pinchart@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent On Sun, Apr 05, 2026 at 10:14:35PM +0300, Laurent Pinchart wrote: > libcamera use the nlohmann_json wrap indirectly through libpisp. This > causes the nlohmann_json.wrap being copied to /subprojects at configure > time, and nlohmann_json being downloaded to /nlohmann_json-3.11.2. Add > corresponding entries to .gitignore. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > subprojects/.gitignore | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/subprojects/.gitignore b/subprojects/.gitignore > index d2ba90074717..1ca3e141b22e 100644 > --- a/subprojects/.gitignore > +++ b/subprojects/.gitignore > @@ -3,5 +3,7 @@ > /googletest-release* > /libpisp > /libyuv > +/nlohmann_json-3.11.2 This would need to be updated whenever the version required by libpisp changes. Should we use a wildcard for this entry ? > +/nlohmann_json.wrap > /packagecache > /yaml-0.2.5 > -- > Regards, > > Laurent Pinchart >
On Tue, Apr 07, 2026 at 02:30:26PM +0200, Jacopo Mondi wrote: > On Sun, Apr 05, 2026 at 10:14:35PM +0300, Laurent Pinchart wrote: > > libcamera use the nlohmann_json wrap indirectly through libpisp. This > > causes the nlohmann_json.wrap being copied to /subprojects at configure > > time, and nlohmann_json being downloaded to /nlohmann_json-3.11.2. Add > > corresponding entries to .gitignore. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > subprojects/.gitignore | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/subprojects/.gitignore b/subprojects/.gitignore > > index d2ba90074717..1ca3e141b22e 100644 > > --- a/subprojects/.gitignore > > +++ b/subprojects/.gitignore > > @@ -3,5 +3,7 @@ > > /googletest-release* > > /libpisp > > /libyuv > > +/nlohmann_json-3.11.2 > > This would need to be updated whenever the version required by libpisp > changes. Should we use a wildcard for this entry ? Good point. I'll replace it with /nlohmann_json-* > > +/nlohmann_json.wrap > > /packagecache > > /yaml-0.2.5
On Tue, Apr 07, 2026 at 03:34:52PM +0300, Laurent Pinchart wrote: > On Tue, Apr 07, 2026 at 02:30:26PM +0200, Jacopo Mondi wrote: > > On Sun, Apr 05, 2026 at 10:14:35PM +0300, Laurent Pinchart wrote: > > > libcamera use the nlohmann_json wrap indirectly through libpisp. This > > > causes the nlohmann_json.wrap being copied to /subprojects at configure > > > time, and nlohmann_json being downloaded to /nlohmann_json-3.11.2. Add > > > corresponding entries to .gitignore. > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > > subprojects/.gitignore | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/subprojects/.gitignore b/subprojects/.gitignore > > > index d2ba90074717..1ca3e141b22e 100644 > > > --- a/subprojects/.gitignore > > > +++ b/subprojects/.gitignore > > > @@ -3,5 +3,7 @@ > > > /googletest-release* > > > /libpisp > > > /libyuv > > > +/nlohmann_json-3.11.2 > > > > This would need to be updated whenever the version required by libpisp > > changes. Should we use a wildcard for this entry ? > > Good point. I'll replace it with > > /nlohmann_json-* Actually, with /nlohmann_json* and I'll drop the next line as the wild card will cover both. > > > +/nlohmann_json.wrap > > > /packagecache > > > /yaml-0.2.5
2026. 04. 07. 14:35 keltezéssel, Laurent Pinchart írta: > On Tue, Apr 07, 2026 at 03:34:52PM +0300, Laurent Pinchart wrote: >> On Tue, Apr 07, 2026 at 02:30:26PM +0200, Jacopo Mondi wrote: >>> On Sun, Apr 05, 2026 at 10:14:35PM +0300, Laurent Pinchart wrote: >>>> libcamera use the nlohmann_json wrap indirectly through libpisp. This >>>> causes the nlohmann_json.wrap being copied to /subprojects at configure >>>> time, and nlohmann_json being downloaded to /nlohmann_json-3.11.2. Add >>>> corresponding entries to .gitignore. >>>> >>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>>> --- >>>> subprojects/.gitignore | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/subprojects/.gitignore b/subprojects/.gitignore >>>> index d2ba90074717..1ca3e141b22e 100644 >>>> --- a/subprojects/.gitignore >>>> +++ b/subprojects/.gitignore >>>> @@ -3,5 +3,7 @@ >>>> /googletest-release* >>>> /libpisp >>>> /libyuv >>>> +/nlohmann_json-3.11.2 >>> >>> This would need to be updated whenever the version required by libpisp >>> changes. Should we use a wildcard for this entry ? >> >> Good point. I'll replace it with >> >> /nlohmann_json-* > > Actually, with > > /nlohmann_json* > > and I'll drop the next line as the wild card will cover both. Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> for the above, with the wildcard. > >>>> +/nlohmann_json.wrap >>>> /packagecache >>>> /yaml-0.2.5 >
diff --git a/subprojects/.gitignore b/subprojects/.gitignore index d2ba90074717..1ca3e141b22e 100644 --- a/subprojects/.gitignore +++ b/subprojects/.gitignore @@ -3,5 +3,7 @@ /googletest-release* /libpisp /libyuv +/nlohmann_json-3.11.2 +/nlohmann_json.wrap /packagecache /yaml-0.2.5
libcamera use the nlohmann_json wrap indirectly through libpisp. This causes the nlohmann_json.wrap being copied to /subprojects at configure time, and nlohmann_json being downloaded to /nlohmann_json-3.11.2. Add corresponding entries to .gitignore. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- subprojects/.gitignore | 2 ++ 1 file changed, 2 insertions(+)