| Message ID | 20260405191443.1209948-10-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
2026. 04. 05. 21:14 keltezéssel, Laurent Pinchart írta: > Multiple files in libcamera are missing SPDX headers. Add them with the > following licenses: > > - CC-BY-SA-4.0 for documentation > > - CC0-1.0 for build system, development tool configuration files and > TODO lists, as we consider them non-copyrightable, and for example > configuration files to facilitate their use > > - BSD-2-Clause for a file copied from the Raspberry Pi tuning tool (and > add the corresponding copyright information) > > While at it, add a missing blank line to > src/libcamera/pipeline/virtual/README.md. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Looks ok to me, but haven't checked if it covers all missing files. Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > .b4-config | 2 ++ > Documentation/mainpage.dox | 2 ++ > Documentation/thread-safety.dox | 2 ++ > src/libcamera/pipeline/virtual/README.md | 3 +++ > src/libcamera/pipeline/virtual/data/meson.build | 2 ++ > src/libcamera/software_isp/TODO.md | 2 ++ > utils/tuning/config-example.yaml | 1 + > utils/tuning/libtuning/ctt_colors.py | 5 +++++ > utils/tuning/requirements.txt | 1 + > 9 files changed, 20 insertions(+) > > diff --git a/.b4-config b/.b4-config > index 371e3e9c2485..99d0361ce453 100644 > --- a/.b4-config > +++ b/.b4-config > @@ -1,2 +1,4 @@ > +# SPDX-License-Identifier: CC0-1.0 > + > [b4] > send-series-to = libcamera-devel@lists.libcamera.org > diff --git a/Documentation/mainpage.dox b/Documentation/mainpage.dox > index 99e67e7ab13d..b651788ee918 100644 > --- a/Documentation/mainpage.dox > +++ b/Documentation/mainpage.dox > @@ -1,3 +1,5 @@ > +// SPDX-License-Identifier: CC-BY-SA-4.0 > + > /** > \if internal > \mainpage libcamera internal API reference > diff --git a/Documentation/thread-safety.dox b/Documentation/thread-safety.dox > index df4c457c89d6..0bc02bfc071f 100644 > --- a/Documentation/thread-safety.dox > +++ b/Documentation/thread-safety.dox > @@ -1,3 +1,5 @@ > +// SPDX-License-Identifier: CC-BY-SA-4.0 > + > /** > * \page thread-safety Reentrancy and Thread-Safety > * > diff --git a/src/libcamera/pipeline/virtual/README.md b/src/libcamera/pipeline/virtual/README.md > index a9f39c15172b..0b2f03d8d719 100644 > --- a/src/libcamera/pipeline/virtual/README.md > +++ b/src/libcamera/pipeline/virtual/README.md > @@ -1,3 +1,5 @@ > +<!-- SPDX-License-Identifier: CC-BY-SA-4.0 --> > + > # Virtual Pipeline Handler > > Virtual pipeline handler emulates fake external camera(s) for testing. > @@ -9,6 +11,7 @@ Virtual pipeline handler emulates fake external camera(s) for testing. > `share/libcamera/pipeline/virtual/virtual.yaml`. > > ### Config File Format > + > The config file contains the information about cameras' properties to register. > The config file should be a yaml file with dictionary of the cameraIds > associated with their properties as top level. The default value will be applied > diff --git a/src/libcamera/pipeline/virtual/data/meson.build b/src/libcamera/pipeline/virtual/data/meson.build > index ce63f9a27d43..0cade65bfa15 100644 > --- a/src/libcamera/pipeline/virtual/data/meson.build > +++ b/src/libcamera/pipeline/virtual/data/meson.build > @@ -1,3 +1,5 @@ > +# SPDX-License-Identifier: CC0-1.0 > + > install_data('virtual.yaml', > install_dir : pipeline_data_dir / 'virtual', > install_tag : 'runtime', > diff --git a/src/libcamera/software_isp/TODO.md b/src/libcamera/software_isp/TODO.md > index 036cf2b7f9ce..0f27da2d243f 100644 > --- a/src/libcamera/software_isp/TODO.md > +++ b/src/libcamera/software_isp/TODO.md > @@ -1,3 +1,5 @@ > +<!-- SPDX-License-Identifier: CC0-1.0 --> > + > # Software ISP TODO list > > This file contains the TODO list for the software ISP. > diff --git a/utils/tuning/config-example.yaml b/utils/tuning/config-example.yaml > index 680f9213b269..0929d90ef747 100644 > --- a/utils/tuning/config-example.yaml > +++ b/utils/tuning/config-example.yaml > @@ -1,3 +1,4 @@ > +# SPDX-License-Identifier: CC0-1.0 > general: > disable: [] > plot: [] > diff --git a/utils/tuning/libtuning/ctt_colors.py b/utils/tuning/libtuning/ctt_colors.py > index cb4d236b04d7..7e9ba646fa5b 100644 > --- a/utils/tuning/libtuning/ctt_colors.py > +++ b/utils/tuning/libtuning/ctt_colors.py > @@ -1,4 +1,9 @@ > +# SPDX-License-Identifier: BSD-2-Clause > +# > +# Copyright (C) 2023, Raspberry Pi Ltd > +# > # Program to convert from RGB to LAB color space > + > def RGB_to_LAB(RGB): # where RGB is a 1x3 array. e.g RGB = [100, 255, 230] > num = 0 > XYZ = [0, 0, 0] > diff --git a/utils/tuning/requirements.txt b/utils/tuning/requirements.txt > index 3705769be7ff..8e14ce0911da 100644 > --- a/utils/tuning/requirements.txt > +++ b/utils/tuning/requirements.txt > @@ -1,3 +1,4 @@ > +# SPDX-License-Identifier: CC0-1.0 > coloredlogs > matplotlib > numpy
diff --git a/.b4-config b/.b4-config index 371e3e9c2485..99d0361ce453 100644 --- a/.b4-config +++ b/.b4-config @@ -1,2 +1,4 @@ +# SPDX-License-Identifier: CC0-1.0 + [b4] send-series-to = libcamera-devel@lists.libcamera.org diff --git a/Documentation/mainpage.dox b/Documentation/mainpage.dox index 99e67e7ab13d..b651788ee918 100644 --- a/Documentation/mainpage.dox +++ b/Documentation/mainpage.dox @@ -1,3 +1,5 @@ +// SPDX-License-Identifier: CC-BY-SA-4.0 + /** \if internal \mainpage libcamera internal API reference diff --git a/Documentation/thread-safety.dox b/Documentation/thread-safety.dox index df4c457c89d6..0bc02bfc071f 100644 --- a/Documentation/thread-safety.dox +++ b/Documentation/thread-safety.dox @@ -1,3 +1,5 @@ +// SPDX-License-Identifier: CC-BY-SA-4.0 + /** * \page thread-safety Reentrancy and Thread-Safety * diff --git a/src/libcamera/pipeline/virtual/README.md b/src/libcamera/pipeline/virtual/README.md index a9f39c15172b..0b2f03d8d719 100644 --- a/src/libcamera/pipeline/virtual/README.md +++ b/src/libcamera/pipeline/virtual/README.md @@ -1,3 +1,5 @@ +<!-- SPDX-License-Identifier: CC-BY-SA-4.0 --> + # Virtual Pipeline Handler Virtual pipeline handler emulates fake external camera(s) for testing. @@ -9,6 +11,7 @@ Virtual pipeline handler emulates fake external camera(s) for testing. `share/libcamera/pipeline/virtual/virtual.yaml`. ### Config File Format + The config file contains the information about cameras' properties to register. The config file should be a yaml file with dictionary of the cameraIds associated with their properties as top level. The default value will be applied diff --git a/src/libcamera/pipeline/virtual/data/meson.build b/src/libcamera/pipeline/virtual/data/meson.build index ce63f9a27d43..0cade65bfa15 100644 --- a/src/libcamera/pipeline/virtual/data/meson.build +++ b/src/libcamera/pipeline/virtual/data/meson.build @@ -1,3 +1,5 @@ +# SPDX-License-Identifier: CC0-1.0 + install_data('virtual.yaml', install_dir : pipeline_data_dir / 'virtual', install_tag : 'runtime', diff --git a/src/libcamera/software_isp/TODO.md b/src/libcamera/software_isp/TODO.md index 036cf2b7f9ce..0f27da2d243f 100644 --- a/src/libcamera/software_isp/TODO.md +++ b/src/libcamera/software_isp/TODO.md @@ -1,3 +1,5 @@ +<!-- SPDX-License-Identifier: CC0-1.0 --> + # Software ISP TODO list This file contains the TODO list for the software ISP. diff --git a/utils/tuning/config-example.yaml b/utils/tuning/config-example.yaml index 680f9213b269..0929d90ef747 100644 --- a/utils/tuning/config-example.yaml +++ b/utils/tuning/config-example.yaml @@ -1,3 +1,4 @@ +# SPDX-License-Identifier: CC0-1.0 general: disable: [] plot: [] diff --git a/utils/tuning/libtuning/ctt_colors.py b/utils/tuning/libtuning/ctt_colors.py index cb4d236b04d7..7e9ba646fa5b 100644 --- a/utils/tuning/libtuning/ctt_colors.py +++ b/utils/tuning/libtuning/ctt_colors.py @@ -1,4 +1,9 @@ +# SPDX-License-Identifier: BSD-2-Clause +# +# Copyright (C) 2023, Raspberry Pi Ltd +# # Program to convert from RGB to LAB color space + def RGB_to_LAB(RGB): # where RGB is a 1x3 array. e.g RGB = [100, 255, 230] num = 0 XYZ = [0, 0, 0] diff --git a/utils/tuning/requirements.txt b/utils/tuning/requirements.txt index 3705769be7ff..8e14ce0911da 100644 --- a/utils/tuning/requirements.txt +++ b/utils/tuning/requirements.txt @@ -1,3 +1,4 @@ +# SPDX-License-Identifier: CC0-1.0 coloredlogs matplotlib numpy
Multiple files in libcamera are missing SPDX headers. Add them with the following licenses: - CC-BY-SA-4.0 for documentation - CC0-1.0 for build system, development tool configuration files and TODO lists, as we consider them non-copyrightable, and for example configuration files to facilitate their use - BSD-2-Clause for a file copied from the Raspberry Pi tuning tool (and add the corresponding copyright information) While at it, add a missing blank line to src/libcamera/pipeline/virtual/README.md. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .b4-config | 2 ++ Documentation/mainpage.dox | 2 ++ Documentation/thread-safety.dox | 2 ++ src/libcamera/pipeline/virtual/README.md | 3 +++ src/libcamera/pipeline/virtual/data/meson.build | 2 ++ src/libcamera/software_isp/TODO.md | 2 ++ utils/tuning/config-example.yaml | 1 + utils/tuning/libtuning/ctt_colors.py | 5 +++++ utils/tuning/requirements.txt | 1 + 9 files changed, 20 insertions(+)