| Message ID | 20260405191443.1209948-11-laurent.pinchart@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
This is fine with me, but maybe someone from RPi should send a tag as well On Sun, Apr 05, 2026 at 10:14:42PM +0300, Laurent Pinchart wrote: > Multiple files in the Raspberry Pi pipeline handler and IPA module are > missing SPDX headers. Add them with the following licenses: > > - For code and documentation, use the BSD-2-Clause license, as for the > rest of the Raspberry Pi code. > > - For the example pipeline handler configuration files, use the CC0-1.0 > license to facilitate their usage. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/ipa/rpi/controller/decompand_status.h | 1 + > src/ipa/rpi/controller/rpi/decompand.cpp | 2 ++ > src/ipa/rpi/controller/rpi/decompand.h | 1 + > src/libcamera/pipeline/rpi/pisp/data/example.yaml | 1 + > src/libcamera/pipeline/rpi/vc4/data/example.yaml | 1 + > utils/raspberrypi/ctt/README.md | 2 ++ > 6 files changed, 8 insertions(+) > > diff --git a/src/ipa/rpi/controller/decompand_status.h b/src/ipa/rpi/controller/decompand_status.h > index 2d9888dca4f3..d024fe71936d 100644 > --- a/src/ipa/rpi/controller/decompand_status.h > +++ b/src/ipa/rpi/controller/decompand_status.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: BSD-2-Clause */ > #pragma once > > #include "libipa/pwl.h" > diff --git a/src/ipa/rpi/controller/rpi/decompand.cpp b/src/ipa/rpi/controller/rpi/decompand.cpp > index 2d457926c060..b93e5c0b1974 100644 > --- a/src/ipa/rpi/controller/rpi/decompand.cpp > +++ b/src/ipa/rpi/controller/rpi/decompand.cpp > @@ -1,3 +1,5 @@ > +/* SPDX-License-Identifier: BSD-2-Clause */ > + > #include "decompand.h" > > #include <libcamera/base/log.h> > diff --git a/src/ipa/rpi/controller/rpi/decompand.h b/src/ipa/rpi/controller/rpi/decompand.h > index 6db779c359a8..fdb4d733adda 100644 > --- a/src/ipa/rpi/controller/rpi/decompand.h > +++ b/src/ipa/rpi/controller/rpi/decompand.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: BSD-2-Clause */ > #pragma once > > #include <libipa/pwl.h> > diff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml > index c5edbba074e8..4b0742452cf1 100644 > --- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml > +++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml > @@ -1,3 +1,4 @@ > +# SPDX-License-Identifier: CC0-1.0 > { > "version": 1.0, > "target": "pisp", > diff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml > index 2ee2b864d55f..9e8d0fdb225f 100644 > --- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml > +++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml > @@ -1,3 +1,4 @@ > +# SPDX-License-Identifier: CC0-1.0 > { > "version": 1.0, > "target": "bcm2835", > diff --git a/utils/raspberrypi/ctt/README.md b/utils/raspberrypi/ctt/README.md > index c3a738ad01ad..aa78274667b6 100644 > --- a/utils/raspberrypi/ctt/README.md > +++ b/utils/raspberrypi/ctt/README.md > @@ -1,3 +1,5 @@ > +.. SPDX-License-Identifier: BSD-2-Clause > + > The Raspberry Pi CTT has moved from this location to the following GitHub > repository: > > -- > Regards, > > Laurent Pinchart >
Hi Laurent, Thanks for the fixes. On Sun, 5 Apr 2026 at 20:15, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Multiple files in the Raspberry Pi pipeline handler and IPA module are > missing SPDX headers. Add them with the following licenses: > > - For code and documentation, use the BSD-2-Clause license, as for the > rest of the Raspberry Pi code. > > - For the example pipeline handler configuration files, use the CC0-1.0 > license to facilitate their usage. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Naushir Patuck <naush@raspberrypi.com> Should we update all the tuning files in src/ipa/rpi/[vc4|pisp]/data/ as part of this change? Regards, Naush > --- > src/ipa/rpi/controller/decompand_status.h | 1 + > src/ipa/rpi/controller/rpi/decompand.cpp | 2 ++ > src/ipa/rpi/controller/rpi/decompand.h | 1 + > src/libcamera/pipeline/rpi/pisp/data/example.yaml | 1 + > src/libcamera/pipeline/rpi/vc4/data/example.yaml | 1 + > utils/raspberrypi/ctt/README.md | 2 ++ > 6 files changed, 8 insertions(+) > > diff --git a/src/ipa/rpi/controller/decompand_status.h b/src/ipa/rpi/controller/decompand_status.h > index 2d9888dca4f3..d024fe71936d 100644 > --- a/src/ipa/rpi/controller/decompand_status.h > +++ b/src/ipa/rpi/controller/decompand_status.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: BSD-2-Clause */ > #pragma once > > #include "libipa/pwl.h" > diff --git a/src/ipa/rpi/controller/rpi/decompand.cpp b/src/ipa/rpi/controller/rpi/decompand.cpp > index 2d457926c060..b93e5c0b1974 100644 > --- a/src/ipa/rpi/controller/rpi/decompand.cpp > +++ b/src/ipa/rpi/controller/rpi/decompand.cpp > @@ -1,3 +1,5 @@ > +/* SPDX-License-Identifier: BSD-2-Clause */ > + > #include "decompand.h" > > #include <libcamera/base/log.h> > diff --git a/src/ipa/rpi/controller/rpi/decompand.h b/src/ipa/rpi/controller/rpi/decompand.h > index 6db779c359a8..fdb4d733adda 100644 > --- a/src/ipa/rpi/controller/rpi/decompand.h > +++ b/src/ipa/rpi/controller/rpi/decompand.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: BSD-2-Clause */ > #pragma once > > #include <libipa/pwl.h> > diff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml > index c5edbba074e8..4b0742452cf1 100644 > --- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml > +++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml > @@ -1,3 +1,4 @@ > +# SPDX-License-Identifier: CC0-1.0 > { > "version": 1.0, > "target": "pisp", > diff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml > index 2ee2b864d55f..9e8d0fdb225f 100644 > --- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml > +++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml > @@ -1,3 +1,4 @@ > +# SPDX-License-Identifier: CC0-1.0 > { > "version": 1.0, > "target": "bcm2835", > diff --git a/utils/raspberrypi/ctt/README.md b/utils/raspberrypi/ctt/README.md > index c3a738ad01ad..aa78274667b6 100644 > --- a/utils/raspberrypi/ctt/README.md > +++ b/utils/raspberrypi/ctt/README.md > @@ -1,3 +1,5 @@ > +.. SPDX-License-Identifier: BSD-2-Clause > + > The Raspberry Pi CTT has moved from this location to the following GitHub > repository: > > -- > Regards, > > Laurent Pinchart >
Hi Naush, On Wed, Apr 08, 2026 at 08:59:40AM +0100, Naushir Patuck wrote: > On Sun, 5 Apr 2026 at 20:15, Laurent Pinchart wrote: > > > > Multiple files in the Raspberry Pi pipeline handler and IPA module are > > missing SPDX headers. Add them with the following licenses: > > > > - For code and documentation, use the BSD-2-Clause license, as for the > > rest of the Raspberry Pi code. > > > > - For the example pipeline handler configuration files, use the CC0-1.0 > > license to facilitate their usage. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Naushir Patuck <naush@raspberrypi.com> > > Should we update all the tuning files in src/ipa/rpi/[vc4|pisp]/data/ > as part of this change? The JSON files are covered by REUSE.toml (currently .reuse/dep5, converted to REUSE.toml as part of this series), because JSON technically does not support comments. Now, because we're using a YAML parser, we could add SPDX headers to the JSON tuning files and libcamera should be able to handle that. > > --- > > src/ipa/rpi/controller/decompand_status.h | 1 + > > src/ipa/rpi/controller/rpi/decompand.cpp | 2 ++ > > src/ipa/rpi/controller/rpi/decompand.h | 1 + > > src/libcamera/pipeline/rpi/pisp/data/example.yaml | 1 + > > src/libcamera/pipeline/rpi/vc4/data/example.yaml | 1 + > > utils/raspberrypi/ctt/README.md | 2 ++ > > 6 files changed, 8 insertions(+) > > > > diff --git a/src/ipa/rpi/controller/decompand_status.h b/src/ipa/rpi/controller/decompand_status.h > > index 2d9888dca4f3..d024fe71936d 100644 > > --- a/src/ipa/rpi/controller/decompand_status.h > > +++ b/src/ipa/rpi/controller/decompand_status.h > > @@ -1,3 +1,4 @@ > > +/* SPDX-License-Identifier: BSD-2-Clause */ > > #pragma once > > > > #include "libipa/pwl.h" > > diff --git a/src/ipa/rpi/controller/rpi/decompand.cpp b/src/ipa/rpi/controller/rpi/decompand.cpp > > index 2d457926c060..b93e5c0b1974 100644 > > --- a/src/ipa/rpi/controller/rpi/decompand.cpp > > +++ b/src/ipa/rpi/controller/rpi/decompand.cpp > > @@ -1,3 +1,5 @@ > > +/* SPDX-License-Identifier: BSD-2-Clause */ > > + > > #include "decompand.h" > > > > #include <libcamera/base/log.h> > > diff --git a/src/ipa/rpi/controller/rpi/decompand.h b/src/ipa/rpi/controller/rpi/decompand.h > > index 6db779c359a8..fdb4d733adda 100644 > > --- a/src/ipa/rpi/controller/rpi/decompand.h > > +++ b/src/ipa/rpi/controller/rpi/decompand.h > > @@ -1,3 +1,4 @@ > > +/* SPDX-License-Identifier: BSD-2-Clause */ > > #pragma once > > > > #include <libipa/pwl.h> > > diff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml > > index c5edbba074e8..4b0742452cf1 100644 > > --- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml > > +++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml > > @@ -1,3 +1,4 @@ > > +# SPDX-License-Identifier: CC0-1.0 > > { > > "version": 1.0, > > "target": "pisp", > > diff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml > > index 2ee2b864d55f..9e8d0fdb225f 100644 > > --- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml > > +++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml > > @@ -1,3 +1,4 @@ > > +# SPDX-License-Identifier: CC0-1.0 > > { > > "version": 1.0, > > "target": "bcm2835", > > diff --git a/utils/raspberrypi/ctt/README.md b/utils/raspberrypi/ctt/README.md > > index c3a738ad01ad..aa78274667b6 100644 > > --- a/utils/raspberrypi/ctt/README.md > > +++ b/utils/raspberrypi/ctt/README.md > > @@ -1,3 +1,5 @@ > > +.. SPDX-License-Identifier: BSD-2-Clause > > + > > The Raspberry Pi CTT has moved from this location to the following GitHub > > repository: > >
diff --git a/src/ipa/rpi/controller/decompand_status.h b/src/ipa/rpi/controller/decompand_status.h index 2d9888dca4f3..d024fe71936d 100644 --- a/src/ipa/rpi/controller/decompand_status.h +++ b/src/ipa/rpi/controller/decompand_status.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: BSD-2-Clause */ #pragma once #include "libipa/pwl.h" diff --git a/src/ipa/rpi/controller/rpi/decompand.cpp b/src/ipa/rpi/controller/rpi/decompand.cpp index 2d457926c060..b93e5c0b1974 100644 --- a/src/ipa/rpi/controller/rpi/decompand.cpp +++ b/src/ipa/rpi/controller/rpi/decompand.cpp @@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: BSD-2-Clause */ + #include "decompand.h" #include <libcamera/base/log.h> diff --git a/src/ipa/rpi/controller/rpi/decompand.h b/src/ipa/rpi/controller/rpi/decompand.h index 6db779c359a8..fdb4d733adda 100644 --- a/src/ipa/rpi/controller/rpi/decompand.h +++ b/src/ipa/rpi/controller/rpi/decompand.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: BSD-2-Clause */ #pragma once #include <libipa/pwl.h> diff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml index c5edbba074e8..4b0742452cf1 100644 --- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml +++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml @@ -1,3 +1,4 @@ +# SPDX-License-Identifier: CC0-1.0 { "version": 1.0, "target": "pisp", diff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml index 2ee2b864d55f..9e8d0fdb225f 100644 --- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml +++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml @@ -1,3 +1,4 @@ +# SPDX-License-Identifier: CC0-1.0 { "version": 1.0, "target": "bcm2835", diff --git a/utils/raspberrypi/ctt/README.md b/utils/raspberrypi/ctt/README.md index c3a738ad01ad..aa78274667b6 100644 --- a/utils/raspberrypi/ctt/README.md +++ b/utils/raspberrypi/ctt/README.md @@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: BSD-2-Clause + The Raspberry Pi CTT has moved from this location to the following GitHub repository:
Multiple files in the Raspberry Pi pipeline handler and IPA module are missing SPDX headers. Add them with the following licenses: - For code and documentation, use the BSD-2-Clause license, as for the rest of the Raspberry Pi code. - For the example pipeline handler configuration files, use the CC0-1.0 license to facilitate their usage. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/ipa/rpi/controller/decompand_status.h | 1 + src/ipa/rpi/controller/rpi/decompand.cpp | 2 ++ src/ipa/rpi/controller/rpi/decompand.h | 1 + src/libcamera/pipeline/rpi/pisp/data/example.yaml | 1 + src/libcamera/pipeline/rpi/vc4/data/example.yaml | 1 + utils/raspberrypi/ctt/README.md | 2 ++ 6 files changed, 8 insertions(+)