[v6,22/24] libcamera: software_isp: lut: Change default Gamma to 1.0/2.2
diff mbox series

Message ID 20251202134544.662446-23-bryan.odonoghue@linaro.org
State Superseded
Headers show
Series
  • Add GLES 2.0 GPUISP to libcamera
Related show

Commit Message

Bryan O'Donoghue Dec. 2, 2025, 1:45 p.m. UTC 
Change the default softisp Gamma from 0.5 to 1.0/2.2.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 src/ipa/simple/algorithms/lut.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hans de Goede Dec. 3, 2025, 10:20 a.m. UTC | #1 
Hi,

On 2-Dec-25 2:45 PM, Bryan O'Donoghue wrote:
> Change the default softisp Gamma from 0.5 to 1.0/2.2.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Thanks this indeed is a better default since monitors have
a default gamma of 2.2 (and this compensates for that):

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans



> ---
>  src/ipa/simple/algorithms/lut.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp
> index 9aaab54f1..7f223e812 100644
> --- a/src/ipa/simple/algorithms/lut.cpp
> +++ b/src/ipa/simple/algorithms/lut.cpp
> @@ -35,7 +35,7 @@ int Lut::configure(IPAContext &context,
>  		   [[maybe_unused]] const IPAConfigInfo &configInfo)
>  {
>  	/* Gamma value is fixed */
> -	context.configuration.gamma = 0.5;
> +	context.configuration.gamma = 1.0/2.2;
>  	context.activeState.knobs.contrast = std::optional<double>();
>  	updateGammaTable(context);
>
Milan Zamazal Dec. 3, 2025, 9:13 p.m. UTC | #2 
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:

> Change the default softisp Gamma from 0.5 to 1.0/2.2.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> ---
>  src/ipa/simple/algorithms/lut.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp
> index 9aaab54f1..7f223e812 100644
> --- a/src/ipa/simple/algorithms/lut.cpp
> +++ b/src/ipa/simple/algorithms/lut.cpp
> @@ -35,7 +35,7 @@ int Lut::configure(IPAContext &context,
>  		   [[maybe_unused]] const IPAConfigInfo &configInfo)
>  {
>  	/* Gamma value is fixed */
> -	context.configuration.gamma = 0.5;
> +	context.configuration.gamma = 1.0/2.2;
>  	context.activeState.knobs.contrast = std::optional<double>();
>  	updateGammaTable(context);

Patch
diff mbox series 

diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp
index 9aaab54f1..7f223e812 100644
--- a/src/ipa/simple/algorithms/lut.cpp
+++ b/src/ipa/simple/algorithms/lut.cpp
@@ -35,7 +35,7 @@  int Lut::configure(IPAContext &context,
 		   [[maybe_unused]] const IPAConfigInfo &configInfo)
 {
 	/* Gamma value is fixed */
-	context.configuration.gamma = 0.5;
+	context.configuration.gamma = 1.0/2.2;
 	context.activeState.knobs.contrast = std::optional<double>();
 	updateGammaTable(context);