[libcamera-devel,2/3] ipa: ipu3: Drive requestQueue when controls are accepted
diff mbox series

Message ID 20220916103713.21132-3-hpa@redhat.com
State New
Headers show
Series
  • Basic AF control for IPU3
Related show

Commit Message

Kate Hsuan Sept. 16, 2022, 10:37 a.m. UTC
Drive and dispatch the controls to the algorithms when the controls
are received.

Signed-off-by: Kate Hsuan <hpa@redhat.com>
---
 src/ipa/ipu3/ipu3.cpp | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jacopo Mondi Sept. 28, 2022, 6:34 a.m. UTC | #1
Hi Kate,

On Fri, Sep 16, 2022 at 06:37:12PM +0800, Kate Hsuan via libcamera-devel wrote:
> Drive and dispatch the controls to the algorithms when the controls
> are received.
>
> Signed-off-by: Kate Hsuan <hpa@redhat.com>
> ---
>  src/ipa/ipu3/ipu3.cpp | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index ac0c42a7..4f64a546 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -657,6 +657,9 @@ void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls)
>  {
>  	/* \todo Start processing for 'frame' based on 'controls'. */
>  	context_.frameContexts[frame % kMaxFrameContexts] = { frame, controls };
> +
> +	for (auto const &algo : algorithms())
> +		algo->queueRequest(context_, frame, controls);

Could you rebase on master now that
https://patchwork.libcamera.org/project/libcamera/list/?series=3506

has been merged and this part has been implemented already.

Also a nudge to Daniel (in cc) that was waiting for that series to get
in to progress with RkISP1 AF implementation.

Thanks
  j

>  }
>
>  /**
> --
> 2.37.3
>

Patch
diff mbox series

diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
index ac0c42a7..4f64a546 100644
--- a/src/ipa/ipu3/ipu3.cpp
+++ b/src/ipa/ipu3/ipu3.cpp
@@ -657,6 +657,9 @@  void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls)
 {
 	/* \todo Start processing for 'frame' based on 'controls'. */
 	context_.frameContexts[frame % kMaxFrameContexts] = { frame, controls };
+
+	for (auto const &algo : algorithms())
+		algo->queueRequest(context_, frame, controls);
 }
 
 /**