| Message ID | 20211022151218.111966-15-jeanmichel.hautbois@ideasonboard.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series |
|
| Related | show |
Hi Jean-Michel and Kieran, Thank you for the patch. On Fri, Oct 22, 2021 at 05:12:13PM +0200, Jean-Michel Hautbois wrote: > From: Kieran Bingham <kieran.bingham@ideasonboard.com> > > The struct RGB and struct AwbStatus are used only by the internal > implementation of the AWB algorithm module. > > Move them into the private class declaration. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/ipa/ipu3/algorithms/awb.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h > index 0c81e39e..b90782c1 100644 > --- a/src/ipa/ipu3/algorithms/awb.h > +++ b/src/ipa/ipu3/algorithms/awb.h > @@ -42,6 +42,7 @@ public: > void prepare(IPAContext &context, ipu3_uapi_params *params) override; > void process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override; > > +private: > /* \todo Make these structs available to all the ISPs ? */ > struct RGB { > RGB(double _R = 0, double _G = 0, double _B = 0)
On 25/10/2021 23:37, Laurent Pinchart wrote: > Hi Jean-Michel and Kieran, > > Thank you for the patch. > > On Fri, Oct 22, 2021 at 05:12:13PM +0200, Jean-Michel Hautbois wrote: >> From: Kieran Bingham <kieran.bingham@ideasonboard.com> >> >> The struct RGB and struct AwbStatus are used only by the internal >> implementation of the AWB algorithm module. >> >> Move them into the private class declaration. >> >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com> > >> --- >> src/ipa/ipu3/algorithms/awb.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h >> index 0c81e39e..b90782c1 100644 >> --- a/src/ipa/ipu3/algorithms/awb.h >> +++ b/src/ipa/ipu3/algorithms/awb.h >> @@ -42,6 +42,7 @@ public: >> void prepare(IPAContext &context, ipu3_uapi_params *params) override; >> void process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override; >> >> +private: >> /* \todo Make these structs available to all the ISPs ? */ >> struct RGB { >> RGB(double _R = 0, double _G = 0, double _B = 0) >
diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h index 0c81e39e..b90782c1 100644 --- a/src/ipa/ipu3/algorithms/awb.h +++ b/src/ipa/ipu3/algorithms/awb.h @@ -42,6 +42,7 @@ public: void prepare(IPAContext &context, ipu3_uapi_params *params) override; void process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override; +private: /* \todo Make these structs available to all the ISPs ? */ struct RGB { RGB(double _R = 0, double _G = 0, double _B = 0)