[libcamera-devel,v3,13/19] ipa: ipu3: Fix the IPU3 AWB doxygen references
diff mbox series

Message ID 20211022151218.111966-14-jeanmichel.hautbois@ideasonboard.com
State Changes Requested
Headers show
Series
  • Document IPU3 IPA
Related show

Commit Message

Jean-Michel Hautbois Oct. 22, 2021, 3:12 p.m. UTC 
From: Kieran Bingham <kieran.bingham@ideasonboard.com>

The AWB AwbStatus structure is contained within the Awb class.
Fix the Doxygen reference so that it can be found.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/ipa/ipu3/algorithms/awb.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart Oct. 25, 2021, 9:36 p.m. UTC | #1 
Hi Jean-Michel and Kieran,

Thank you for the patch.

On Fri, Oct 22, 2021 at 05:12:12PM +0200, Jean-Michel Hautbois wrote:
> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> The AWB AwbStatus structure is contained within the Awb class.
> Fix the Doxygen reference so that it can be found.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/ipu3/algorithms/awb.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp
> index 101d84ca..d36271b0 100644
> --- a/src/ipa/ipu3/algorithms/awb.cpp
> +++ b/src/ipa/ipu3/algorithms/awb.cpp
> @@ -71,7 +71,7 @@ static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 90 / 100;
>   */
>  
>  /**
> - * \struct AwbStatus
> + * \struct Awb::AwbStatus
>   * \brief AWB parameters calculated
>   *
>   * The AwbStatus structure is intended to store the AWB
Jean-Michel Hautbois Oct. 26, 2021, 6:34 a.m. UTC | #2 
On 25/10/2021 23:36, Laurent Pinchart wrote:
> Hi Jean-Michel and Kieran,
> 
> Thank you for the patch.
> 
> On Fri, Oct 22, 2021 at 05:12:12PM +0200, Jean-Michel Hautbois wrote:
>> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
>>
>> The AWB AwbStatus structure is contained within the Awb class.
>> Fix the Doxygen reference so that it can be found.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
> 
>> ---
>>   src/ipa/ipu3/algorithms/awb.cpp | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp
>> index 101d84ca..d36271b0 100644
>> --- a/src/ipa/ipu3/algorithms/awb.cpp
>> +++ b/src/ipa/ipu3/algorithms/awb.cpp
>> @@ -71,7 +71,7 @@ static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 90 / 100;
>>    */
>>   
>>   /**
>> - * \struct AwbStatus
>> + * \struct Awb::AwbStatus
>>    * \brief AWB parameters calculated
>>    *
>>    * The AwbStatus structure is intended to store the AWB
>

Patch
diff mbox series 

diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp
index 101d84ca..d36271b0 100644
--- a/src/ipa/ipu3/algorithms/awb.cpp
+++ b/src/ipa/ipu3/algorithms/awb.cpp
@@ -71,7 +71,7 @@  static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 90 / 100;
  */
 
 /**
- * \struct AwbStatus
+ * \struct Awb::AwbStatus
  * \brief AWB parameters calculated
  *
  * The AwbStatus structure is intended to store the AWB