| Message ID | 20210618103351.1642060-14-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Delegated to: | Paul Elder |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thank you for the patch. On Fri, Jun 18, 2021 at 07:33:50PM +0900, Paul Elder wrote: > Set the AwbMode ControlInfo in IPU3, to satisfy CTS FULL > requirements. > > Bug: https://bugs.libcamera.org/show_bug.cgi?id=44 > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index f315a411..32d0bc1c 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -50,6 +50,7 @@ static constexpr Size IPU3ViewfinderSize(1280, 720); > static const ControlInfoMap::Map IPU3Controls = { > { &controls::AeEnable, ControlInfo(false, true) }, > { &controls::AeLock, ControlInfo(false, true) }, > + { &controls::AwbMode, ControlInfo(controls::AwbModeValues) }, I'm OK with this as a first step, but shouldn't the supported values should come from the IPA module ? > { &controls::draft::MaxLatency, ControlInfo(0, 0, 0) }, > { &controls::draft::PipelineDepth, ControlInfo(2, 3) }, > };
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index f315a411..32d0bc1c 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -50,6 +50,7 @@ static constexpr Size IPU3ViewfinderSize(1280, 720); static const ControlInfoMap::Map IPU3Controls = { { &controls::AeEnable, ControlInfo(false, true) }, { &controls::AeLock, ControlInfo(false, true) }, + { &controls::AwbMode, ControlInfo(controls::AwbModeValues) }, { &controls::draft::MaxLatency, ControlInfo(0, 0, 0) }, { &controls::draft::PipelineDepth, ControlInfo(2, 3) }, };
Set the AwbMode ControlInfo in IPU3, to satisfy CTS FULL requirements. Bug: https://bugs.libcamera.org/show_bug.cgi?id=44 Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- src/libcamera/pipeline/ipu3/ipu3.cpp | 1 + 1 file changed, 1 insertion(+)