[libcamera-devel,RFC,14/14] FULL: pipeline: ipu3: Set AwbLock ControlInfo
diff mbox series

Message ID 20210618103351.1642060-15-paul.elder@ideasonboard.com
State Superseded
Delegated to: Paul Elder
Headers show
Series
  • Preliminary FULL plumbing
Related show

Commit Message

Paul Elder June 18, 2021, 10:33 a.m. UTC
Set the AwbLock ControlInfo in IPU3, to satisfy CTS FULL
requirements.

Bug: https://bugs.libcamera.org/show_bug.cgi?id=45
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart June 28, 2021, 1:56 a.m. UTC | #1
Hi Paul,

Thank you for the patch.

On Fri, Jun 18, 2021 at 07:33:51PM +0900, Paul Elder wrote:
> Set the AwbLock ControlInfo in IPU3, to satisfy CTS FULL
> requirements.
> 
> Bug: https://bugs.libcamera.org/show_bug.cgi?id=45
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index 32d0bc1c..7355edc0 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -50,6 +50,7 @@ static constexpr Size IPU3ViewfinderSize(1280, 720);
>  static const ControlInfoMap::Map IPU3Controls = {
>  	{ &controls::AeEnable, ControlInfo(false, true) },
>  	{ &controls::AeLock, ControlInfo(false, true) },
> +	{ &controls::AwbLock, ControlInfo(false, true) },

Assuming the discussions on 03/14 conclude it's the way to go, and with
the comments on 11/14 addressed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  	{ &controls::AwbMode, ControlInfo(controls::AwbModeValues) },
>  	{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },
>  	{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },

Patch
diff mbox series

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index 32d0bc1c..7355edc0 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -50,6 +50,7 @@  static constexpr Size IPU3ViewfinderSize(1280, 720);
 static const ControlInfoMap::Map IPU3Controls = {
 	{ &controls::AeEnable, ControlInfo(false, true) },
 	{ &controls::AeLock, ControlInfo(false, true) },
+	{ &controls::AwbLock, ControlInfo(false, true) },
 	{ &controls::AwbMode, ControlInfo(controls::AwbModeValues) },
 	{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },
 	{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },