[libcamera-devel,RFC,10/14] FULL: pipeline: ipu3: Set MaxLatency ControlInfo
diff mbox series

Message ID 20210618103351.1642060-11-paul.elder@ideasonboard.com
State Superseded
Delegated to: Paul Elder
Headers show
Series
  • Preliminary FULL plumbing
Related show

Commit Message

Paul Elder June 18, 2021, 10:33 a.m. UTC
Set the MaxLatency ControlInfo in IPU3, to satisfy CTS FULL
requirements.

Bug: https://bugs.libcamera.org/show_bug.cgi?id=50
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart June 28, 2021, 1:52 a.m. UTC | #1
Hi Paul,

Thank you for the patch.

On Fri, Jun 18, 2021 at 07:33:47PM +0900, Paul Elder wrote:
> Set the MaxLatency ControlInfo in IPU3, to satisfy CTS FULL
> requirements.
> 
> Bug: https://bugs.libcamera.org/show_bug.cgi?id=50
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index 6c93bc6d..1899f389 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -48,6 +48,7 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;
>  static constexpr Size IPU3ViewfinderSize(1280, 720);
>  
>  static const ControlInfoMap::Map IPU3Controls = {
> +	{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },

It's a bit of a future promise of course, but it's the right goal :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  	{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },
>  };
>

Patch
diff mbox series

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index 6c93bc6d..1899f389 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -48,6 +48,7 @@  static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;
 static constexpr Size IPU3ViewfinderSize(1280, 720);
 
 static const ControlInfoMap::Map IPU3Controls = {
+	{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },
 	{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },
 };