| Message ID | 20200813005246.3265807-2-niklas.soderlund@ragnatech.se |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Niklas, On Thu, Aug 13, 2020 at 02:52:34AM +0200, Niklas Söderlund wrote: > The function declaration is unnecessarily broken on two lines as it fits > on 80 characters, which makes reading the code nicer. > > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Pretty non-controversial! Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index 32fdaed7c661ae74..e2b703fc09f7afda 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -893,8 +893,7 @@ void PipelineHandlerRkISP1::stop(Camera *camera) > activeCamera_ = nullptr; > } > > -int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, > - Request *request) > +int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request) > { > RkISP1CameraData *data = cameraData(camera); > Stream *stream = &data->stream_; > -- > 2.28.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Niklas/Jacopo, On 20/08/2020 08:55, Jacopo Mondi wrote: > Hi Niklas, > > On Thu, Aug 13, 2020 at 02:52:34AM +0200, Niklas Söderlund wrote: >> The function declaration is unnecessarily broken on two lines as it fits >> on 80 characters, which makes reading the code nicer. >> >> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > > Pretty non-controversial! I'm not sure, I think it might be ;-) Oh ok maybe not. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> > > Thanks > j > >> --- >> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp >> index 32fdaed7c661ae74..e2b703fc09f7afda 100644 >> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp >> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp >> @@ -893,8 +893,7 @@ void PipelineHandlerRkISP1::stop(Camera *camera) >> activeCamera_ = nullptr; >> } >> >> -int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, >> - Request *request) >> +int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request) >> { >> RkISP1CameraData *data = cameraData(camera); >> Stream *stream = &data->stream_; >> -- >> 2.28.0 >> >> _______________________________________________ >> libcamera-devel mailing list >> libcamera-devel@lists.libcamera.org >> https://lists.libcamera.org/listinfo/libcamera-devel > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel >
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 32fdaed7c661ae74..e2b703fc09f7afda 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -893,8 +893,7 @@ void PipelineHandlerRkISP1::stop(Camera *camera) activeCamera_ = nullptr; } -int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, - Request *request) +int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request) { RkISP1CameraData *data = cameraData(camera); Stream *stream = &data->stream_;
The function declaration is unnecessarily broken on two lines as it fits on 80 characters, which makes reading the code nicer. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)