Patch Detail
Show a patch.
GET /api/patches/9487/?format=api
{ "id": 9487, "url": "https://patchwork.libcamera.org/api/patches/9487/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9487/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200904095148.844292-2-kieran.bingham@ideasonboard.com>", "date": "2020-09-04T09:51:45", "name": "[libcamera-devel,1/3] package/libcamera: Prevent builds on m68k", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "0d8b2ff707ee277454b6f59fcb4041b9cc9fa59e", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9487/mbox/", "series": [ { "id": 1264, "url": "https://patchwork.libcamera.org/api/series/1264/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1264", "date": "2020-09-04T09:51:44", "name": "libcamera: Fix and update libcamera package", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1264/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9487/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9487/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A77B1BF019\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 4 Sep 2020 09:52:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D99C8629DB;\n\tFri, 4 Sep 2020 11:52:01 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 674E060371\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Sep 2020 11:52:00 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E4B0F540;\n\tFri, 4 Sep 2020 11:51:59 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NiwpNhtv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599213120;\n\tbh=ntFLGig4LMiQcRh3AGf742haGi818lIkWo0HK3g5Ryg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NiwpNhtvJhdrdks/sE28aL6aa/s5Z4oXzsz0KWlD5XQychc8zOWS/+xAc4p2k8Teh\n\tOThujv0qXaRY7tetDmwLb6BZYgIZq3LM2cWIgg+6ikzSKPdkm+K6vqLknSa3xWpnpx\n\tTjO6/vN7w7yUyqEMM7nxOX3xT/UO0NP1HLaybVsc=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "buildroot@buildroot.org", "Date": "Fri, 4 Sep 2020 10:51:45 +0100", "Message-Id": "<20200904095148.844292-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200904095148.844292-1-kieran.bingham@ideasonboard.com>", "References": "<20200904095148.844292-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/3] package/libcamera: Prevent builds on\n\tm68k", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ControlValue structure is currently defined with a 16-bit hole\n(causing unaligned access to the numElements_ field, though that's a\nseparate topic).\n\nThis structure has a static assertion to ensure that its size does not\nchange without due care, as it forms part of our ABI and is used in\nSerialisation between the pipeline handlers and IPA componenents.\n\nThe m68k architecture is the only target which fails this assertion,\nwhich is likely because it can pack the structure more efficiently,\nproducing a different binary size.\n\nThis is likely an area we will tackle before stabilising our ABI, but\nuntil then, disable m68k builds as libcamera is not expected to be\nsupported on this target.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n package/libcamera/Config.in | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in\nindex 960d78b82e95..1ea747d1c57e 100644\n--- a/package/libcamera/Config.in\n+++ b/package/libcamera/Config.in\n@@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA\n \tdepends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14\n \tdepends on !BR2_STATIC_LIBS # gnutls\n \tdepends on BR2_USE_WCHAR # gnutls\n+\t# Invalid packing size of ControlValue struct on m68k\n+\tdepends on !BR2_m68k\n \tselect BR2_PACKAGE_GNUTLS\n \tselect BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE\n \thelp\n", "prefixes": [ "libcamera-devel", "1/3" ] }