From patchwork Fri Sep 4 09:51:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 9487 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A77B1BF019 for ; Fri, 4 Sep 2020 09:52:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D99C8629DB; Fri, 4 Sep 2020 11:52:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NiwpNhtv"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 674E060371 for ; Fri, 4 Sep 2020 11:52:00 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E4B0F540; Fri, 4 Sep 2020 11:51:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599213120; bh=ntFLGig4LMiQcRh3AGf742haGi818lIkWo0HK3g5Ryg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NiwpNhtvJhdrdks/sE28aL6aa/s5Z4oXzsz0KWlD5XQychc8zOWS/+xAc4p2k8Teh OThujv0qXaRY7tetDmwLb6BZYgIZq3LM2cWIgg+6ikzSKPdkm+K6vqLknSa3xWpnpx TjO6/vN7w7yUyqEMM7nxOX3xT/UO0NP1HLaybVsc= From: Kieran Bingham To: buildroot@buildroot.org Date: Fri, 4 Sep 2020 10:51:45 +0100 Message-Id: <20200904095148.844292-2-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200904095148.844292-1-kieran.bingham@ideasonboard.com> References: <20200904095148.844292-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] package/libcamera: Prevent builds on m68k X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libcamera devel Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The ControlValue structure is currently defined with a 16-bit hole (causing unaligned access to the numElements_ field, though that's a separate topic). This structure has a static assertion to ensure that its size does not change without due care, as it forms part of our ABI and is used in Serialisation between the pipeline handlers and IPA componenents. The m68k architecture is the only target which fails this assertion, which is likely because it can pack the structure more efficiently, producing a different binary size. This is likely an area we will tackle before stabilising our ABI, but until then, disable m68k builds as libcamera is not expected to be supported on this target. Signed-off-by: Kieran Bingham --- package/libcamera/Config.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in index 960d78b82e95..1ea747d1c57e 100644 --- a/package/libcamera/Config.in +++ b/package/libcamera/Config.in @@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14 depends on !BR2_STATIC_LIBS # gnutls depends on BR2_USE_WCHAR # gnutls + # Invalid packing size of ControlValue struct on m68k + depends on !BR2_m68k select BR2_PACKAGE_GNUTLS select BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE help From patchwork Fri Sep 4 09:51:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 9488 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 744E3BF019 for ; Fri, 4 Sep 2020 09:52:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3AF6F62B2F; Fri, 4 Sep 2020 11:52:04 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="vNeLuvs8"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 476D860371 for ; Fri, 4 Sep 2020 11:52:02 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD2A5BA5; Fri, 4 Sep 2020 11:52:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599213121; bh=RE8eSrOE7QqpZIUu7l63+RRpiB42yugehR5kywjNCSM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vNeLuvs8/SyCSH7/mq1VZTgBkOpCgLHivn4d6mLhf9z9BegiEbmXQhOhBC9jA9zqe ZkJZaDstjw7jZ8bXEMcqQZ/OhAgSsIHBbM7M326KF1EMTxp8jqh61C7bKI1ioEtee2 Qy8WMXzucXmP5wyRVFkuz42wpCz8z8BshutsWIVg= From: Kieran Bingham To: buildroot@buildroot.org Date: Fri, 4 Sep 2020 10:51:46 +0100 Message-Id: <20200904095148.844292-3-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200904095148.844292-1-kieran.bingham@ideasonboard.com> References: <20200904095148.844292-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/3] package/libcamera: Update requirements for C++17 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libcamera devel Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The libcamera project has moved to C++17. Update the toolchain requirements accordingly. Signed-off-by: Kieran Bingham --- package/libcamera/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in index 1ea747d1c57e..262ea49a0ead 100644 --- a/package/libcamera/Config.in +++ b/package/libcamera/Config.in @@ -2,7 +2,7 @@ menuconfig BR2_PACKAGE_LIBCAMERA bool "libcamera" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14 + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17 depends on !BR2_STATIC_LIBS # gnutls depends on BR2_USE_WCHAR # gnutls # Invalid packing size of ControlValue struct on m68k @@ -65,6 +65,6 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_VIMC endif # BR2_PACKAGE_LIBCAMERA -comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 5" +comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ - !BR2_TOOLCHAIN_GCC_AT_LEAST_5 || BR2_STATIC_LIBS || !BR2_USE_WCHAR + !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR From patchwork Fri Sep 4 09:51:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 9489 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C2F01BF019 for ; Fri, 4 Sep 2020 09:52:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8F786629C7; Fri, 4 Sep 2020 11:52:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KmfX6fZQ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 81AAB60371 for ; Fri, 4 Sep 2020 11:52:06 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AE34BD33; Fri, 4 Sep 2020 11:52:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599213122; bh=CIqXru3gJHh4V+qSuWJkjY1niyq6JEzxWBvg5LdYGq8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KmfX6fZQspLHbUR6abAf3Iy7EBcP7K7dbWPNa+QiDTUmizpSx+Jr5/v3EYXcaJZRp QXwgriys21h4M5baVqNWKXHk/+M3IINzIA/Xn6QeecDs2AZWMARn6ehPP7y2ZRaCmI wSyPLpblzZhUCqdSIcvTbqjRETP2dXaIZZAcdm9U= From: Kieran Bingham To: buildroot@buildroot.org Date: Fri, 4 Sep 2020 10:51:47 +0100 Message-Id: <20200904095148.844292-4-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200904095148.844292-1-kieran.bingham@ideasonboard.com> References: <20200904095148.844292-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/3] package/libcamera: bump version to e59713c6 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libcamera devel Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Kieran Bingham --- package/libcamera/libcamera.hash | 2 +- package/libcamera/libcamera.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package/libcamera/libcamera.hash b/package/libcamera/libcamera.hash index 676d3ac73907..bc9122315166 100644 --- a/package/libcamera/libcamera.hash +++ b/package/libcamera/libcamera.hash @@ -1,4 +1,4 @@ -sha256 55b7d7e5d8c70b2586b31544e6c4891a994c4e69c18d0ebd760e87b75277c348 libcamera-565f95d64ff92e8712e8090988180c343dd3bcb5.tar.gz +sha256 a7800b54584dee321874610ef70b1b7690c79d8340c5b134ea35176657681e29 libcamera-e59713c68678f3eb6b6ebe97cabdc88c7042567f.tar.gz # license files sha256 fd38b2c053c0cce46d9c5ef3545a6e34d157a240ba99c9b8dca5d37a8147da6c LICENSES/BSD-2-Clause.txt diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk index 4a4bc4ea90aa..e6cd71420774 100644 --- a/package/libcamera/libcamera.mk +++ b/package/libcamera/libcamera.mk @@ -5,7 +5,7 @@ ################################################################################ LIBCAMERA_SITE = https://git.linuxtv.org/libcamera.git -LIBCAMERA_VERSION = 565f95d64ff92e8712e8090988180c343dd3bcb5 +LIBCAMERA_VERSION = e59713c68678f3eb6b6ebe97cabdc88c7042567f LIBCAMERA_SITE_METHOD = git LIBCAMERA_DEPENDENCIES = \ host-openssl \