From patchwork Fri Sep 4 09:51:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 9487 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A77B1BF019 for ; Fri, 4 Sep 2020 09:52:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D99C8629DB; Fri, 4 Sep 2020 11:52:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NiwpNhtv"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 674E060371 for ; Fri, 4 Sep 2020 11:52:00 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E4B0F540; Fri, 4 Sep 2020 11:51:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599213120; bh=ntFLGig4LMiQcRh3AGf742haGi818lIkWo0HK3g5Ryg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NiwpNhtvJhdrdks/sE28aL6aa/s5Z4oXzsz0KWlD5XQychc8zOWS/+xAc4p2k8Teh OThujv0qXaRY7tetDmwLb6BZYgIZq3LM2cWIgg+6ikzSKPdkm+K6vqLknSa3xWpnpx TjO6/vN7w7yUyqEMM7nxOX3xT/UO0NP1HLaybVsc= From: Kieran Bingham To: buildroot@buildroot.org Date: Fri, 4 Sep 2020 10:51:45 +0100 Message-Id: <20200904095148.844292-2-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200904095148.844292-1-kieran.bingham@ideasonboard.com> References: <20200904095148.844292-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] package/libcamera: Prevent builds on m68k X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libcamera devel Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The ControlValue structure is currently defined with a 16-bit hole (causing unaligned access to the numElements_ field, though that's a separate topic). This structure has a static assertion to ensure that its size does not change without due care, as it forms part of our ABI and is used in Serialisation between the pipeline handlers and IPA componenents. The m68k architecture is the only target which fails this assertion, which is likely because it can pack the structure more efficiently, producing a different binary size. This is likely an area we will tackle before stabilising our ABI, but until then, disable m68k builds as libcamera is not expected to be supported on this target. Signed-off-by: Kieran Bingham --- package/libcamera/Config.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in index 960d78b82e95..1ea747d1c57e 100644 --- a/package/libcamera/Config.in +++ b/package/libcamera/Config.in @@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14 depends on !BR2_STATIC_LIBS # gnutls depends on BR2_USE_WCHAR # gnutls + # Invalid packing size of ControlValue struct on m68k + depends on !BR2_m68k select BR2_PACKAGE_GNUTLS select BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE help