Patch Detail
Show a patch.
GET /api/patches/27448/?format=api
{ "id": 27448, "url": "https://patchwork.libcamera.org/api/patches/27448/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27448/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260723071933.30933-1-robert.mader@collabora.com>", "date": "2026-07-23T07:19:33", "name": "[v2] software_isp: debayer_egl: Re-add log for failing DMABuf import", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0183f65adb9a8c397b6522498cd9239f7e1819ea", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27448/mbox/", "series": [ { "id": 6074, "url": "https://patchwork.libcamera.org/api/series/6074/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6074", "date": "2026-07-23T07:19:33", "name": "[v2] software_isp: debayer_egl: Re-add log for failing DMABuf import", "version": 2, "mbox": "https://patchwork.libcamera.org/series/6074/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27448/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27448/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2BF2CBE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Jul 2026 07:20:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E67867EB3;\n\tThu, 23 Jul 2026 09:20:14 +0200 (CEST)", "from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com\n\t[136.143.188.11])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9036E6604D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jul 2026 09:20:12 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1784791206963467.3697143795358;\n\tThu, 23 Jul 2026 00:20:06 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"c1Qx9yDh\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1784791208; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=IVLRHa5vP0Z3m6Gibfw4uMIhF6KxbcL1E6VvJw8t/HWKbTzL6W8Z//DSf17e9Dpjopc4trID+v5YKuvAZ0LREpZXNWfkn6nrqfiPg7G7Ql5kn2PQFT7YxUtSRGaNT2BiCwMY/jKnMT+b8dQYucKEla3dnweTgjQwf3P3QbEbVU8=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1784791208;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=1kOkdBdAkXaFZp6Q1z5BZluCw5bXw7R/KRn84ocX47s=; \n\tb=kvG6dvyEucbUq8ispabMxKZvInD8TGhAzgJy9CoTqvJWrZBo2TU8TNaWTHSSvAplXASTkfqwa4YbgMLkKqD821N+j9wkm10r0tuzDyPn+mgvIkL/38B9cdm2xt48XLWgW1dZ0dlvYuhtBOPxdB8H9ti4ozaVFc/I3VrvoQcxj38=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1784791208;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=1kOkdBdAkXaFZp6Q1z5BZluCw5bXw7R/KRn84ocX47s=;\n\tb=c1Qx9yDhwnS0rqQrGYpTVRA12sHJYZk0qA44v3OFGoVbfuCf6m0iuODIXuh3mZJP\n\tuFIQBXemYYw0p48Nv53thMoq3GJ2WHRJfGEVtzHJIa9fip28zattRcTpCMzw5dwEHuR\n\t7G3DZZNlRHxns9W6VguYraoT60IMvdT6EVoQmuiQ=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2] software_isp: debayer_egl: Re-add log for failing DMABuf\n\timport", "Date": "Thu, 23 Jul 2026 09:19:33 +0200", "Message-ID": "<20260723071933.30933-1-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.55.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The log was introduced in commit\n93f0db167a8d (\"debayer_egl: Implement dmabuf import for input buffers\")\nand dropped in the commit mentioned below. Let's readd it as failing\nimports majorly impact performance and indicate actionable issues in the\nV4L2 or GPU drivers. Ensure the log is only printed once, now that we use\nmultiple eGLImages.\n\nFixes: 13f7b921acdf (\"libcamera: software_isp: debayer_egl: Implement input/output frame caching mechanism\")\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\n\nChanges in v2:\n - Apply wording suggestion (Laurent)\n---\n src/libcamera/software_isp/debayer_egl.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 02651fe87922..09ab5a58c994 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -533,6 +533,9 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona\n \t\tif (egl_.createInputDMABufTexture2D(*eglImageIn, input->planes()[0].fd.get()) == 0)\n \t\t\treturn eglImageIn;\n \n+\t\tif (eglImageInCache_.size() == 1)\n+\t\t\tLOG(Debayer, Info)\n+\t\t\t\t<< \"Importing input DMABuf failed, falling back to upload\";\n \t} else if (!eglImageIn->dmabuf_import_failed_) {\n \t\tegl_.activateBindTexture(*eglImageIn);\n \t\treturn eglImageIn;\n", "prefixes": [ "v2" ] }