| Message ID | 20260723071933.30933-1-robert.mader@collabora.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp index 02651fe87922..09ab5a58c994 100644 --- a/src/libcamera/software_isp/debayer_egl.cpp +++ b/src/libcamera/software_isp/debayer_egl.cpp @@ -533,6 +533,9 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona if (egl_.createInputDMABufTexture2D(*eglImageIn, input->planes()[0].fd.get()) == 0) return eglImageIn; + if (eglImageInCache_.size() == 1) + LOG(Debayer, Info) + << "Importing input DMABuf failed, falling back to upload"; } else if (!eglImageIn->dmabuf_import_failed_) { egl_.activateBindTexture(*eglImageIn); return eglImageIn;
The log was introduced in commit 93f0db167a8d ("debayer_egl: Implement dmabuf import for input buffers") and dropped in the commit mentioned below. Let's readd it as failing imports majorly impact performance and indicate actionable issues in the V4L2 or GPU drivers. Ensure the log is only printed once, now that we use multiple eGLImages. Fixes: 13f7b921acdf ("libcamera: software_isp: debayer_egl: Implement input/output frame caching mechanism") Signed-off-by: Robert Mader <robert.mader@collabora.com> Reviewed-by: Milan Zamazal <mzamazal@redhat.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- Changes in v2: - Apply wording suggestion (Laurent) --- src/libcamera/software_isp/debayer_egl.cpp | 3 +++ 1 file changed, 3 insertions(+)