From patchwork Thu Jul 23 07:19:33 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 27448 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2BF2CBE080 for ; Thu, 23 Jul 2026 07:20:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2E67867EB3; Thu, 23 Jul 2026 09:20:14 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="c1Qx9yDh"; dkim-atps=neutral Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9036E6604D for ; Thu, 23 Jul 2026 09:20:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1784791208; cv=none; d=zohomail.com; s=zohoarc; b=IVLRHa5vP0Z3m6Gibfw4uMIhF6KxbcL1E6VvJw8t/HWKbTzL6W8Z//DSf17e9Dpjopc4trID+v5YKuvAZ0LREpZXNWfkn6nrqfiPg7G7Ql5kn2PQFT7YxUtSRGaNT2BiCwMY/jKnMT+b8dQYucKEla3dnweTgjQwf3P3QbEbVU8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784791208; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=1kOkdBdAkXaFZp6Q1z5BZluCw5bXw7R/KRn84ocX47s=; b=kvG6dvyEucbUq8ispabMxKZvInD8TGhAzgJy9CoTqvJWrZBo2TU8TNaWTHSSvAplXASTkfqwa4YbgMLkKqD821N+j9wkm10r0tuzDyPn+mgvIkL/38B9cdm2xt48XLWgW1dZ0dlvYuhtBOPxdB8H9ti4ozaVFc/I3VrvoQcxj38= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1784791208; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=1kOkdBdAkXaFZp6Q1z5BZluCw5bXw7R/KRn84ocX47s=; b=c1Qx9yDhwnS0rqQrGYpTVRA12sHJYZk0qA44v3OFGoVbfuCf6m0iuODIXuh3mZJP uFIQBXemYYw0p48Nv53thMoq3GJ2WHRJfGEVtzHJIa9fip28zattRcTpCMzw5dwEHuR 7G3DZZNlRHxns9W6VguYraoT60IMvdT6EVoQmuiQ= Received: by mx.zohomail.com with SMTPS id 1784791206963467.3697143795358; Thu, 23 Jul 2026 00:20:06 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader , Milan Zamazal , Kieran Bingham Subject: [PATCH v2] software_isp: debayer_egl: Re-add log for failing DMABuf import Date: Thu, 23 Jul 2026 09:19:33 +0200 Message-ID: <20260723071933.30933-1-robert.mader@collabora.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The log was introduced in commit 93f0db167a8d ("debayer_egl: Implement dmabuf import for input buffers") and dropped in the commit mentioned below. Let's readd it as failing imports majorly impact performance and indicate actionable issues in the V4L2 or GPU drivers. Ensure the log is only printed once, now that we use multiple eGLImages. Fixes: 13f7b921acdf ("libcamera: software_isp: debayer_egl: Implement input/output frame caching mechanism") Signed-off-by: Robert Mader Reviewed-by: Milan Zamazal Reviewed-by: Kieran Bingham --- Changes in v2: - Apply wording suggestion (Laurent) --- src/libcamera/software_isp/debayer_egl.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp index 02651fe87922..09ab5a58c994 100644 --- a/src/libcamera/software_isp/debayer_egl.cpp +++ b/src/libcamera/software_isp/debayer_egl.cpp @@ -533,6 +533,9 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona if (egl_.createInputDMABufTexture2D(*eglImageIn, input->planes()[0].fd.get()) == 0) return eglImageIn; + if (eglImageInCache_.size() == 1) + LOG(Debayer, Info) + << "Importing input DMABuf failed, falling back to upload"; } else if (!eglImageIn->dmabuf_import_failed_) { egl_.activateBindTexture(*eglImageIn); return eglImageIn;