Patch Detail
Show a patch.
GET /api/patches/27425/?format=api
{ "id": 27425, "url": "https://patchwork.libcamera.org/api/patches/27425/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27425/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260721130839.85262-1-robert.mader@collabora.com>", "date": "2026-07-21T13:08:39", "name": "[v1] software_isp: debayer_egl: Re-add log for failing DMABuf import", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b7c3073aa934d008723c281218c3334638685fe0", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27425/mbox/", "series": [ { "id": 6069, "url": "https://patchwork.libcamera.org/api/series/6069/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6069", "date": "2026-07-21T13:08:39", "name": "[v1] software_isp: debayer_egl: Re-add log for failing DMABuf import", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6069/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27425/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27425/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64873BDE4C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Jul 2026 13:09:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2042E67E65;\n\tTue, 21 Jul 2026 15:09:08 +0200 (CEST)", "from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com\n\t[136.143.188.11])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3819A6601C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Jul 2026 15:09:06 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1784639340695536.5559730578021;\n\tTue, 21 Jul 2026 06:09:00 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"KDoT+Civ\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1784639342; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=CepIekObBqPGGDGXqleaJJj4jRPuKASDt4Pbq7WatrVm+u/hCVtcMm31gdRikf/We3ekfDBKyOk2io8ee2m5grfIDPN+zozCa/CDZj4TbaijdsBc+cs56D+pjRVpCkQKVQgfRIaxDA/tmV5KvMtOLg4yYiuXnrRkELE3i0rjf+E=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1784639342;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=n00yPCcjoWt7zNCOoKKsBK99JUUJcH3kZodmHnMPe80=; \n\tb=ihB96p/Gpbty7QZrOwinOhaQcycKdl+xSowxWhnU5DjGR5PKfZ+xJNZ78bFA4uFiT0k+EVRfICJjmw8xQqkW4AvIlVAXvalSvhYiWhSImLzW/oNLoSc7OGqYLfjfuXEHsRc6+/tvtC77ZwFWieJhOT8TxcZ+Y1TKwl0M0xibN/c=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1784639342;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=n00yPCcjoWt7zNCOoKKsBK99JUUJcH3kZodmHnMPe80=;\n\tb=KDoT+CivDgxMqMgglV60lRqoD7hP0O2arwyIpI+FRDNYC5dKR9SCnKJKs0X24Fr8\n\tIpp6JQBTJoNYDfDEcrYC4qaS5S5KQMYnQIL/pWa5kj/miRcgnivH/xW7HJIrCEnCVsH\n\ts4Vx6KMPtBL7T/6FsNxjIBmYDN1QDQ+IWlQrx6xM=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH v1] software_isp: debayer_egl: Re-add log for failing DMABuf\n\timport", "Date": "Tue, 21 Jul 2026 15:08:39 +0200", "Message-ID": "<20260721130839.85262-1-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.55.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The log was introduced in commit\n93f0db167a8d (\"debayer_egl: Implement dmabuf import for input buffers\")\nand dropped in the commit mentioned below. Let's readd it as failing\nimports majorly impact performance and indicate actionable issues in the\nV4L2 or GPU drivers. Ensure the log is only printed once, now that we use\nmultiple eGLImages.\n\nFixes: 13f7b921acdf (\"libcamera: software_isp: debayer_egl: Implement input/output frame caching mechanism\")\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n---\n src/libcamera/software_isp/debayer_egl.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 02651fe87922..8e0a9b79dfa4 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -533,6 +533,8 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona\n \t\tif (egl_.createInputDMABufTexture2D(*eglImageIn, input->planes()[0].fd.get()) == 0)\n \t\t\treturn eglImageIn;\n \n+\t\tif (eglImageInCache_.size() == 1)\n+\t\t\tLOG(Debayer, Info) << \"Importing input buffer with DMABuf import failed, falling back to upload\";\n \t} else if (!eglImageIn->dmabuf_import_failed_) {\n \t\tegl_.activateBindTexture(*eglImageIn);\n \t\treturn eglImageIn;\n", "prefixes": [ "v1" ] }