[{"id":39777,"web_url":"https://patchwork.libcamera.org/comment/39777/","msgid":"","date":"2026-07-21T15:46:43","subject":"Re: [PATCH v1] software_isp: debayer_egl: Re-add log for failing\n\tDMABuf import","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"P.S.: this should also help with testing the CAMSS pipeline handler \n(https://patchwork.libcamera.org/cover/27426/), which *should* be able \nto accommodate requested strides - and thus always allow dmabuf import \n\\o/ (I haven't tested that yet, will try ASAP).\n\nOn 21.07.26 15:08, Robert Mader wrote:\n> The log was introduced in commit\n> 93f0db167a8d (\"debayer_egl: Implement dmabuf import for input buffers\")\n> and dropped in the commit mentioned below. Let's readd it as failing\n> imports majorly impact performance and indicate actionable issues in the\n> V4L2 or GPU drivers. Ensure the log is only printed once, now that we use\n> multiple eGLImages.\n>\n> Fixes: 13f7b921acdf (\"libcamera: software_isp: debayer_egl: Implement input/output frame caching mechanism\")\n> Signed-off-by: Robert Mader \n> ---\n> src/libcamera/software_isp/debayer_egl.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 02651fe87922..8e0a9b79dfa4 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -533,6 +533,8 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona\n> \t\tif (egl_.createInputDMABufTexture2D(*eglImageIn, input->planes()[0].fd.get()) == 0)\n> \t\t\treturn eglImageIn;\n> \n> +\t\tif (eglImageInCache_.size() == 1)\n> +\t\t\tLOG(Debayer, Info) << \"Importing input buffer with DMABuf import failed, falling back to upload\";\n> \t} else if (!eglImageIn->dmabuf_import_failed_) {\n> \t\tegl_.activateBindTexture(*eglImageIn);\n> \t\treturn eglImageIn;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEAC1BDE4C\n\tfor ;\n\tTue, 21 Jul 2026 15:46:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1A4C67E79;\n\tTue, 21 Jul 2026 17:46:56 +0200 (CEST)","from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com\n\t[136.143.188.11])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F4206601C\n\tfor ;\n\tTue, 21 Jul 2026 17:46:54 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1784648805379244.54303111044953; \n\tTue, 21 Jul 2026 08:46:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"VL+SOGvs\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1784648807; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=SuQcEVZiOf+vCnVHLRtgTpHsWiedbGBDxbR+nC8C1MctQ7yuT8rSFheoSimJCoTC2FmkB9+qB67H0VcPit8gs5FPblx1saXQgV4cEQWRT2UTaePK9IAFhYah0da1l/G807wxu/r8JmUAug4aVK073FE0oJ6zDam6UewBIKl55L0=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1784648807;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=D8PBYrQ4YPcunm4lLG2ndQFB30ddKR6a6PQEpXHHZvo=; \n\tb=mbavCgiFUEzVjufND+fq+hcTmQB/gaZkoYLSxFQ9u/uxK3CzzDxLeZ0kvUJ3UquO/iACq8OxzINOVQCzXzP+7fxB9iKFzail1dYb6lrIVfGoGU3rcO1Ft/moPSHJ8+HUDfVmZWRAjtJV+tyhzKHqVWUYXzAlhZD28EL1iqyegvA=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1784648807;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=D8PBYrQ4YPcunm4lLG2ndQFB30ddKR6a6PQEpXHHZvo=;\n\tb=VL+SOGvspcOOmvx+5W0aoZlv9Y5gE3X03fxPcjsuFbnO3gVKLe0MnfIFOyIpmY5L\n\tuV0U2/4IezPYTNT6CyRiEhtNChx9mVxqG3QXtcHktn0FhNdIUKFcUCxup6TUbO8AN53\n\tJrJ8hLmPdm51zm/O5C4rycA9Zgpx0i1pI2cmk7+o=","Message-ID":"","Date":"Tue, 21 Jul 2026 17:46:43 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] software_isp: debayer_egl: Re-add log for failing\n\tDMABuf import","To":"libcamera devel ,\n\tHans de Goede ","References":"<20260721130839.85262-1-robert.mader@collabora.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20260721130839.85262-1-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39779,"web_url":"https://patchwork.libcamera.org/comment/39779/","msgid":"<85zezkuyeb.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-07-21T15:59:24","subject":"Re: [PATCH v1] software_isp: debayer_egl: Re-add log for failing\n\tDMABuf import","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Robert Mader writes:\n\n> The log was introduced in commit\n> 93f0db167a8d (\"debayer_egl: Implement dmabuf import for input buffers\")\n> and dropped in the commit mentioned below. Let's readd it as failing\n> imports majorly impact performance and indicate actionable issues in the\n> V4L2 or GPU drivers. Ensure the log is only printed once, now that we use\n> multiple eGLImages.\n>\n> Fixes: 13f7b921acdf (\"libcamera: software_isp: debayer_egl: Implement input/output frame caching mechanism\")\n> Signed-off-by: Robert Mader \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/software_isp/debayer_egl.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 02651fe87922..8e0a9b79dfa4 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -533,6 +533,8 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona\n> \t\tif (egl_.createInputDMABufTexture2D(*eglImageIn, input->planes()[0].fd.get()) == 0)\n> \t\t\treturn eglImageIn;\n> \n> +\t\tif (eglImageInCache_.size() == 1)\n> +\t\t\tLOG(Debayer, Info) << \"Importing input buffer with DMABuf import failed, falling back to upload\";\n> \t} else if (!eglImageIn->dmabuf_import_failed_) {\n> \t\tegl_.activateBindTexture(*eglImageIn);\n> \t\treturn eglImageIn;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3F6BBDE4C\n\tfor ;\n\tTue, 21 Jul 2026 15:59:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CA1067E6F;\n\tTue, 21 Jul 2026 17:59:31 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B2AF6601C\n\tfor ;\n\tTue, 21 Jul 2026 17:59:30 +0200 (CEST)","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n\t[209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-418-b85ZCXMmO6Ox16pZLorvoA-1; Tue, 21 Jul 2026 11:59:27 -0400","by mail-wr1-f70.google.com with SMTP id\n\tffacd0b85a97d-473ac08a6a4so7484571f8f.0\n\tfor ;\n\tTue, 21 Jul 2026 08:59:27 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-4.net.vodafone.cz. [77.48.47.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-47f69e5eff1sm30894097f8f.19.2026.07.21.08.59.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 21 Jul 2026 08:59:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Up0W9+FW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1784649569;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=zOlmg4qr9XYdl8mNI51uvKIMiGSgG9+qiKjNwV9lqGk=;\n\tb=Up0W9+FWfmKsGYO0O6EZ1fPs53fDIiSHA/QKlzDdkT80H4qiNcYXq2QWgyrcuSQrhjVenm\n\tCHgLNGJzOusIX1nq3RVxK0xFR84FhrnCHz53GYfEOrtRcrcT5nYQQcCd605E8A0hkNNtQQ\n\tWMP3iFDdYKKhdNR2pJXa35J8eAlpNS8=","X-MC-Unique":"b85ZCXMmO6Ox16pZLorvoA-1","X-Mimecast-MFC-AGG-ID":"b85ZCXMmO6Ox16pZLorvoA_1784649566","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1784649566; x=1785254366;\n\th=content-type:mime-version:user-agent:message-id:date:references\n\t:in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to\n\t:cc:subject:date:message-id:reply-to:content-type;\n\tbh=zOlmg4qr9XYdl8mNI51uvKIMiGSgG9+qiKjNwV9lqGk=;\n\tb=leMbEac2IutMZ0cMJtFxv+mm14WliZEqFwMvt+kqjgHonnrSfHQ8pHTrZdMmjjKODK\n\tKBhwdFQbaeHVpShOYzYvfOeQQgnAy8QOx3cDWYrOjmdotJL1QATln9rg2+C4xDIyjOFC\n\te/1ZFJPT18YjBdxfIyxxLJsAB+WJzbAR+O3/liqGtJNemP09ikS0a9XKsvZn4RKkHr+X\n\tFUkjwYFDrVoP+CosjhyFJ+w5OLz1x+RI+GIq3rtOrmTR93BkQ82HmNADhH9MJXM/B1d0\n\tJetIjAJlDrqD6yJn8jNihO7tHcAOdiasiii5Y/yYAtHiI093S2XWanBkowUqbsGHOt+D\n\taipA==","X-Gm-Message-State":"AOJu0YyCj9WH8A57CuXZutc/m+2918fZPgT5lI8Vj8q+uabsS0QvhZ1M\n\t2x4eUo/7qu00triWBwCkFonTD5IXpA/ir5UJnWIwc1FLkfXaI6VxvNaQRR2upeYIxEkNNzqvUi4\n\tWfy4FEF+mG3RXowebO7lSxc/5EIjgMGP3C7QQhliUYQvKCwZvZg+u0sbCFC2P1UxQm+XaAM9FQ8\n\tO7Il74We7/D1GNzfCm9qtvLeoELXteBYRYIwwhz3OgBB6n1KnNruh/m7tguTM=","X-Gm-Gg":"AR+sD13liUmjZqFRePX+qGQwJzvAKv4FTj7yvGcmnzhj5WF3vYMiQNOda2woq8lBrMs\n\tTUv2Y/PIqMmIO4Lm6sVFiUEgK0WYzm4TpjM2ifW4rCpo1DDJl34sew+fR5ezFo/f8qWwkb5cXfa\n\tug6TW6LDSeH2EiUrRC0NoAO+aD/yfWNX50KsAWhl66m31tJhZ/McjUdMo2cdVSucTjsKw3BfOm+\n\tw9eiDhvTmM58VuYr3h/eC24ntEWuXmpEnE/V93VPk1euiObWHizJlNCUod1ajNE4Re363ooFals\n\tBduC47WfaRVC4CoRsdTrMs3LiwPbMyzzq1EvmH5dx+W1MODVUE2TrknxRnEqyWfJ14XK4vWDl4l\n\tzyzB8TB9XOW5skc5cmedYJEwkG8GPqOezXp1aZC7WUEhZZRzwnCNU+Q==","X-Received":["by 2002:a05:6000:1ac9:b0:47f:4ac9:98bc with SMTP id\n\tffacd0b85a97d-47f6230dc51mr24020857f8f.24.1784649566603; \n\tTue, 21 Jul 2026 08:59:26 -0700 (PDT)","by 2002:a05:6000:1ac9:b0:47f:4ac9:98bc with SMTP id\n\tffacd0b85a97d-47f6230dc51mr24020823f8f.24.1784649566216; \n\tTue, 21 Jul 2026 08:59:26 -0700 (PDT)"],"From":"Milan Zamazal ","To":"Robert Mader ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] software_isp: debayer_egl: Re-add log for failing\n\tDMABuf import","In-Reply-To":"<20260721130839.85262-1-robert.mader@collabora.com> (Robert\n\tMader's message of \"Tue, 21 Jul 2026 15:08:39 +0200\")","References":"<20260721130839.85262-1-robert.mader@collabora.com>","Date":"Tue, 21 Jul 2026 17:59:24 +0200","Message-ID":"<85zezkuyeb.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"ELA-BLOMGLvmqNxj7ozyt7Q_KiVae_4ESMaCuOYb5qg_1784649566","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39784,"web_url":"https://patchwork.libcamera.org/comment/39784/","msgid":"<178470765690.1444504.12433254662319393085@ping.linuxembedded.co.uk>","date":"2026-07-22T08:07:36","subject":"Re: [PATCH v1] software_isp: debayer_egl: Re-add log for failing\n\tDMABuf import","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2026-07-21 16:59:24)\n> Robert Mader writes:\n> \n> > The log was introduced in commit\n> > 93f0db167a8d (\"debayer_egl: Implement dmabuf import for input buffers\")\n> > and dropped in the commit mentioned below. Let's readd it as failing\n> > imports majorly impact performance and indicate actionable issues in the\n> > V4L2 or GPU drivers. Ensure the log is only printed once, now that we use\n> > multiple eGLImages.\n> >\n> > Fixes: 13f7b921acdf (\"libcamera: software_isp: debayer_egl: Implement input/output frame caching mechanism\")\n> > Signed-off-by: Robert Mader \n> \n> Reviewed-by: Milan Zamazal \n> \n> > ---\n> > src/libcamera/software_isp/debayer_egl.cpp | 2 ++\n> > 1 file changed, 2 insertions(+)\n> >\n> > diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> > index 02651fe87922..8e0a9b79dfa4 100644\n> > --- a/src/libcamera/software_isp/debayer_egl.cpp\n> > +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> > @@ -533,6 +533,8 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona\n> > if (egl_.createInputDMABufTexture2D(*eglImageIn, input->planes()[0].fd.get()) == 0)\n> > return eglImageIn;\n> > \n> > + if (eglImageInCache_.size() == 1)\n> > + LOG(Debayer, Info) << \"Importing input buffer with DMABuf import failed, falling back to upload\";\n\nThat's a long line, we usually push the << to the line below to reduce\nindentation in that case - and I'm on the fence whether this is Info or\nWarning, but it's all minor so either way:\n\nReviewed-by: Kieran Bingham \n\n\n\n\n> > } else if (!eglImageIn->dmabuf_import_failed_) {\n> > egl_.activateBindTexture(*eglImageIn);\n> > return eglImageIn;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CD60BDE17\n\tfor ;\n\tWed, 22 Jul 2026 08:07:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 492BD67E7C;\n\tWed, 22 Jul 2026 10:07:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66DFE61451\n\tfor ;\n\tWed, 22 Jul 2026 10:07:40 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E353447;\n\tWed, 22 Jul 2026 10:06:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rXTZaPSQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784707600;\n\tbh=ntY0AusQCXc0Wbk6TSQ4wAgkeZLH3o9DK+0fIQiPckk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=rXTZaPSQoWbZ1ojPtX/eJoQi+YQlOvlOobLw9LQg1ZH4NCIV/bRulCPM5QWznwwdU\n\t9kSZ2nk6dmH94066BADdPdK40QJyHqDCi+UhO6d49AkfH+5TL3qN8HdWjtLZ8Gq7sU\n\to9ateqRTd/I+o2Nxi8dez/2xCPC7eKp//I3P+OIU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<85zezkuyeb.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","References":"<20260721130839.85262-1-robert.mader@collabora.com>\n\t<85zezkuyeb.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Subject":"Re: [PATCH v1] software_isp: debayer_egl: Re-add log for failing\n\tDMABuf import","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Milan Zamazal ,\n\tRobert Mader ","Date":"Wed, 22 Jul 2026 09:07:36 +0100","Message-ID":"<178470765690.1444504.12433254662319393085@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39798,"web_url":"https://patchwork.libcamera.org/comment/39798/","msgid":"<20260722130740.GB648629@killaraus.ideasonboard.com>","date":"2026-07-22T13:07:40","subject":"Re: [PATCH v1] software_isp: debayer_egl: Re-add log for failing\n\tDMABuf import","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jul 22, 2026 at 09:07:36AM +0100, Kieran Bingham wrote:\n> Quoting Milan Zamazal (2026-07-21 16:59:24)\n> > Robert Mader writes:\n> > \n> > > The log was introduced in commit\n> > > 93f0db167a8d (\"debayer_egl: Implement dmabuf import for input buffers\")\n> > > and dropped in the commit mentioned below. Let's readd it as failing\n> > > imports majorly impact performance and indicate actionable issues in the\n> > > V4L2 or GPU drivers. Ensure the log is only printed once, now that we use\n> > > multiple eGLImages.\n> > >\n> > > Fixes: 13f7b921acdf (\"libcamera: software_isp: debayer_egl: Implement input/output frame caching mechanism\")\n> > > Signed-off-by: Robert Mader \n> > \n> > Reviewed-by: Milan Zamazal \n> > \n> > > ---\n> > > src/libcamera/software_isp/debayer_egl.cpp | 2 ++\n> > > 1 file changed, 2 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> > > index 02651fe87922..8e0a9b79dfa4 100644\n> > > --- a/src/libcamera/software_isp/debayer_egl.cpp\n> > > +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> > > @@ -533,6 +533,8 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona\n> > > if (egl_.createInputDMABufTexture2D(*eglImageIn, input->planes()[0].fd.get()) == 0)\n> > > return eglImageIn;\n> > > \n> > > + if (eglImageInCache_.size() == 1)\n> > > + LOG(Debayer, Info) << \"Importing input buffer with DMABuf import failed, falling back to upload\";\n> \n> That's a long line, we usually push the << to the line below to reduce\n> indentation in that case - and I'm on the fence whether this is Info or\n> Warning, but it's all minor so either way:\n\nThe message can be shortened a bit too:\n\n\t\t\tLOG(Debayer, Info)\n\t\t\t\t<< \"Importing input DMABuf failed, falling back to upload\";\n\n> \n> Reviewed-by: Kieran Bingham \n> \n> > > } else if (!eglImageIn->dmabuf_import_failed_) {\n> > > egl_.activateBindTexture(*eglImageIn);\n> > > return eglImageIn;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 698C5BDE4C\n\tfor ;\n\tWed, 22 Jul 2026 13:07:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B89DF67E9D;\n\tWed, 22 Jul 2026 15:07:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF09367E8A\n\tfor ;\n\tWed, 22 Jul 2026 15:07:41 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9290C227;\n\tWed, 22 Jul 2026 15:06:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wRNc1YFN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784725601;\n\tbh=LyeZv3QWAN8ME8xishMUT0pakdnuGapMWHmU4CDFMM4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wRNc1YFNAozZNpTzU8tcQM6ZGDZ3nRESjMPYOsyAQSnCC4+9gOo8wxpDu2k5FqobY\n\tbtirxhmesgQlH9d4kp8ivIbtmOhwBIk21ST8u01Tc3lfQcsKRemIVJHzF3QvbE7cKC\n\tOy+V5cwmh9MRFiBsGza6BXvAZE0HqCPBrZqkCugM=","Date":"Wed, 22 Jul 2026 16:07:40 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tRobert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] software_isp: debayer_egl: Re-add log for failing\n\tDMABuf import","Message-ID":"<20260722130740.GB648629@killaraus.ideasonboard.com>","References":"<20260721130839.85262-1-robert.mader@collabora.com>\n\t<85zezkuyeb.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<178470765690.1444504.12433254662319393085@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<178470765690.1444504.12433254662319393085@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39800,"web_url":"https://patchwork.libcamera.org/comment/39800/","msgid":"<77283513-b75d-4de5-a01e-64fd5a0540fd@collabora.com>","date":"2026-07-23T07:21:41","subject":"Re: [PATCH v1] software_isp: debayer_egl: Re-add log for failing\n\tDMABuf import","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"Hi Laurent\n\nOn 22.07.26 15:07, Laurent Pinchart wrote:\n> On Wed, Jul 22, 2026 at 09:07:36AM +0100, Kieran Bingham wrote:\n>> Quoting Milan Zamazal (2026-07-21 16:59:24)\n>>> Robert Mader writes:\n>>>\n>>>> The log was introduced in commit\n>>>> 93f0db167a8d (\"debayer_egl: Implement dmabuf import for input buffers\")\n>>>> and dropped in the commit mentioned below. Let's readd it as failing\n>>>> imports majorly impact performance and indicate actionable issues in the\n>>>> V4L2 or GPU drivers. Ensure the log is only printed once, now that we use\n>>>> multiple eGLImages.\n>>>>\n>>>> Fixes: 13f7b921acdf (\"libcamera: software_isp: debayer_egl: Implement input/output frame caching mechanism\")\n>>>> Signed-off-by: Robert Mader \n>>> Reviewed-by: Milan Zamazal \n>>>\n>>>> ---\n>>>> src/libcamera/software_isp/debayer_egl.cpp | 2 ++\n>>>> 1 file changed, 2 insertions(+)\n>>>>\n>>>> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n>>>> index 02651fe87922..8e0a9b79dfa4 100644\n>>>> --- a/src/libcamera/software_isp/debayer_egl.cpp\n>>>> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n>>>> @@ -533,6 +533,8 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona\n>>>> if (egl_.createInputDMABufTexture2D(*eglImageIn, input->planes()[0].fd.get()) == 0)\n>>>> return eglImageIn;\n>>>> \n>>>> + if (eglImageInCache_.size() == 1)\n>>>> + LOG(Debayer, Info) << \"Importing input buffer with DMABuf import failed, falling back to upload\";\n>> That's a long line, we usually push the << to the line below to reduce\n>> indentation in that case - and I'm on the fence whether this is Info or\n>> Warning, but it's all minor so either way:\n> The message can be shortened a bit too:\n>\n> \t\t\tLOG(Debayer, Info)\n> \t\t\t\t<< \"Importing input DMABuf failed, falling back to upload\";\nThat's better, indeed. Applied in v2, thanks!\n>\n>> Reviewed-by: Kieran Bingham \n>>\n>>>> } else if (!eglImageIn->dmabuf_import_failed_) {\n>>>> egl_.activateBindTexture(*eglImageIn);\n>>>> return eglImageIn;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53E10BE080\n\tfor ;\n\tThu, 23 Jul 2026 07:21:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E82BE67EAE;\n\tThu, 23 Jul 2026 09:21:51 +0200 (CEST)","from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com\n\t[136.143.188.11])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4F956604D\n\tfor ;\n\tThu, 23 Jul 2026 09:21:50 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1784791304623103.88802030338854; \n\tThu, 23 Jul 2026 00:21:44 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"gZK6Bdry\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1784791306; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=ZBMEQh/FtWALz47zOzpbI5Tsy7riXDMuZzabTE28QVelgT2ytIJHaxWDAREyy3BM2u3+Aw2y1HPjRjPuBE4s8uJI5z/rk6cxe+sJt41EbUfA5G9sErBN+3s6xe+aYN3C8EdD4BbRPb0W7RQmm0F+F3HadzuGrkkFP6o3Mj1NaFg=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1784791306;\n\th=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=LhZcB0y9K++3Os3miJqSYwU8yEWgzPXLGvWR6bQo4is=; \n\tb=M3s9+ZfxPgTfR0zYOj/OqhJATTy6HkGt7Lbv1KGaJwL3M4r/BwKGN+8Gpq2a9P4BQpo7OJ9A7mjdblTOvL7QXiMce4mCikbJySVqAY59QYvKalLzwY+n2St4SOLyOBie15gxet789DZQ/pFiTSsSRz1W7ZZHUyF50/FJ0lpMgPo=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1784791306;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=LhZcB0y9K++3Os3miJqSYwU8yEWgzPXLGvWR6bQo4is=;\n\tb=gZK6BdrygZdsVepdRJu8lb9GA4ECpowy0Skz2Eke0OcI0ZOFUR77uKechl/o3djy\n\tAsREra9Lp5VIZswXbp1jVOxq1s5c5AkXcL+jS5iBJvbECDT1kHxJTQupuTS5GqwTEuj\n\t9x1TpdikHSscefG3r1FF2p7bvrW8qqC5/IOEJcNE=","Message-ID":"<77283513-b75d-4de5-a01e-64fd5a0540fd@collabora.com>","Date":"Thu, 23 Jul 2026 09:21:41 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] software_isp: debayer_egl: Re-add log for failing\n\tDMABuf import","To":"Laurent Pinchart ,\n\tKieran Bingham ","Cc":"Milan Zamazal , libcamera-devel@lists.libcamera.org","References":"<20260721130839.85262-1-robert.mader@collabora.com>\n\t<85zezkuyeb.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<178470765690.1444504.12433254662319393085@ping.linuxembedded.co.uk>\n\t<20260722130740.GB648629@killaraus.ideasonboard.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20260722130740.GB648629@killaraus.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]