From patchwork Tue Jul 21 13:08:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 27425 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 64873BDE4C for ; Tue, 21 Jul 2026 13:09:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2042E67E65; Tue, 21 Jul 2026 15:09:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="KDoT+Civ"; dkim-atps=neutral Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3819A6601C for ; Tue, 21 Jul 2026 15:09:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1784639342; cv=none; d=zohomail.com; s=zohoarc; b=CepIekObBqPGGDGXqleaJJj4jRPuKASDt4Pbq7WatrVm+u/hCVtcMm31gdRikf/We3ekfDBKyOk2io8ee2m5grfIDPN+zozCa/CDZj4TbaijdsBc+cs56D+pjRVpCkQKVQgfRIaxDA/tmV5KvMtOLg4yYiuXnrRkELE3i0rjf+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784639342; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=n00yPCcjoWt7zNCOoKKsBK99JUUJcH3kZodmHnMPe80=; b=ihB96p/Gpbty7QZrOwinOhaQcycKdl+xSowxWhnU5DjGR5PKfZ+xJNZ78bFA4uFiT0k+EVRfICJjmw8xQqkW4AvIlVAXvalSvhYiWhSImLzW/oNLoSc7OGqYLfjfuXEHsRc6+/tvtC77ZwFWieJhOT8TxcZ+Y1TKwl0M0xibN/c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1784639342; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=n00yPCcjoWt7zNCOoKKsBK99JUUJcH3kZodmHnMPe80=; b=KDoT+CivDgxMqMgglV60lRqoD7hP0O2arwyIpI+FRDNYC5dKR9SCnKJKs0X24Fr8 Ipp6JQBTJoNYDfDEcrYC4qaS5S5KQMYnQIL/pWa5kj/miRcgnivH/xW7HJIrCEnCVsH s4Vx6KMPtBL7T/6FsNxjIBmYDN1QDQ+IWlQrx6xM= Received: by mx.zohomail.com with SMTPS id 1784639340695536.5559730578021; Tue, 21 Jul 2026 06:09:00 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader Subject: [PATCH v1] software_isp: debayer_egl: Re-add log for failing DMABuf import Date: Tue, 21 Jul 2026 15:08:39 +0200 Message-ID: <20260721130839.85262-1-robert.mader@collabora.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The log was introduced in commit 93f0db167a8d ("debayer_egl: Implement dmabuf import for input buffers") and dropped in the commit mentioned below. Let's readd it as failing imports majorly impact performance and indicate actionable issues in the V4L2 or GPU drivers. Ensure the log is only printed once, now that we use multiple eGLImages. Fixes: 13f7b921acdf ("libcamera: software_isp: debayer_egl: Implement input/output frame caching mechanism") Signed-off-by: Robert Mader Reviewed-by: Milan Zamazal --- src/libcamera/software_isp/debayer_egl.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp index 02651fe87922..8e0a9b79dfa4 100644 --- a/src/libcamera/software_isp/debayer_egl.cpp +++ b/src/libcamera/software_isp/debayer_egl.cpp @@ -533,6 +533,8 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona if (egl_.createInputDMABufTexture2D(*eglImageIn, input->planes()[0].fd.get()) == 0) return eglImageIn; + if (eglImageInCache_.size() == 1) + LOG(Debayer, Info) << "Importing input buffer with DMABuf import failed, falling back to upload"; } else if (!eglImageIn->dmabuf_import_failed_) { egl_.activateBindTexture(*eglImageIn); return eglImageIn;