Patch Detail
Show a patch.
GET /api/patches/27227/?format=api
{ "id": 27227, "url": "https://patchwork.libcamera.org/api/patches/27227/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27227/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260706-libipa-algorithms-v3-27-968757b038bb@ideasonboard.com>", "date": "2026-07-06T08:01:47", "name": "[v3,27/35] ipa: libipa: lsc_polynomial: Remove sensorSize_", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4afba6295c04ce97e63b5c929950149cfb428d1f", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27227/mbox/", "series": [ { "id": 6038, "url": "https://patchwork.libcamera.org/api/series/6038/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6038", "date": "2026-07-06T08:01:20", "name": "ipa: libipa: Introduce libipa algorithms", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6038/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27227/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27227/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 039D7C330F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Jul 2026 08:02:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81A2266065;\n\tMon, 6 Jul 2026 10:02:35 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE6A866003\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Jul 2026 10:02:14 +0200 (CEST)", "from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it\n\t[109.113.60.81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 751913FC6;\n\tMon, 6 Jul 2026 10:01:26 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zj1uVw7K\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783324886;\n\tbh=NbrfAK9//1utpY5eLKzcx1k5qkbe73wBX/A1oIKCQEw=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=Zj1uVw7KhO8LFH2cde9kXY/6tjP1pytrGdH7MDvXzX/jLfrsP9MIzkLtvaufxLIe/\n\tAFMNXqbXmdDotzPlK5BMSdwJ37Gn598zr2walzJZsFW/09orHLM2AKF9kZlfGXIG/N\n\t6QF0fNZwMDsEFHDGJ4Lr5KFfgZ/l86g1kfdU5ltY=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Mon, 06 Jul 2026 10:01:47 +0200", "Subject": "[PATCH v3 27/35] ipa: libipa: lsc_polynomial: Remove sensorSize_", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260706-libipa-algorithms-v3-27-968757b038bb@ideasonboard.com>", "References": "<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>", "In-Reply-To": "<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3191;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=NbrfAK9//1utpY5eLKzcx1k5qkbe73wBX/A1oIKCQEw=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2DykSCdQ4aftyAYXZi4twXNQViCVDBHKAFel\n\tA62UBkP6qaJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg8gAKCRByNAaPFqFW\n\tPEExEACIQwYR+klXV/YMd7mSsQNvbxWsiHbk/EsC8rNaM+ZpFVnOUmHEg6mPz85VqR2FcQZFvTy\n\tv7vv8QN9mZpwbSPM/JYcrUowCLXWZl1VtPOMD/7uj9MKInKTcnUGNRjQTBluEgI+xX6mrzKhacf\n\tznPuBelV3ImLNvTf2SamNoxhXyfJuSVjSO9b9GHeuO+UgJIMMvbwMEc5ZrcK45vachncTMDv7Or\n\trtuUYZ2tDb/9U2O7VdF03zbEqIVVl+iB3o4lT0gc17g9G0NuZSwYI3aCBgLIAbqHUryd3r/F/ex\n\tW9alzMs14ZZA/tWwdLIJyBm1Yhbxayj+j10K3sGr+WOVKF3FQJTtn4FcIkfDRc09NsLYNB6+v1G\n\tOrk0r8bB5afRMPL+nyibYLiWkPg+CWKFAX0P7HDPG+cqu95q4z43ZM6qZ4dgdrY6jtQzYAz5G+q\n\tMlwA/OuqhSIFvwg4Uzd9tium1iusS0TLQxahZNQ1ER42YN4V43dD3DhyTcVv0XO07UtcUjPyYmm\n\tMS0XaGRDdVMt0g9ofr6mbfdqZV4qTgn+Bt6zmQK+RIn2FZP6cJNWMQ+hnefyj3C7xP6kRDxGCHq\n\tl4GdWfBn28RNpfjY4b6dhrohanwLWVTEjHxgBrFU0SFMlcR6tNSZ+oyXmLaS6noqDPSmCFUHaVP\n\tOmOAMiuk7zahDDA==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sensorSize_ field is only used during the init() function and is\nprovided to LscPolynomial using the LscDescriptor type.\n\nThere is no need to store it as a class member and to pass it in\nat class construction time.\n\nRemove it and move the \\todo comment in the LscDescriptor type\ndocumentation.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc.cpp | 6 +-----\n src/ipa/libipa/lsc_base.cpp | 3 +++\n src/ipa/libipa/lsc_polynomial.cpp | 7 -------\n src/ipa/libipa/lsc_polynomial.h | 6 ------\n 4 files changed, 4 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\nindex c860569ccee4..804bbc2915e4 100644\n--- a/src/ipa/libipa/lsc.cpp\n+++ b/src/ipa/libipa/lsc.cpp\n@@ -215,11 +215,7 @@ int LscAlgorithm::init(const ValueNode &tuningData, ControlInfoMap::Map &control\n \t\timpl_ = std::make_unique<LscTable>();\n \t\tLOG(Lsc, Debug) << \"Using table-based Lsc\";\n \t} else if (type == \"polynomial\") {\n-\t\t/*\n-\t\t * \\todo: Most likely the reference frame should be native_size.\n-\t\t * Let's wait how the internal discussions progress.\n-\t\t */\n-\t\timpl_ = std::make_unique<LscPolynomial>(descriptor.sensorSize);\n+\t\timpl_ = std::make_unique<LscPolynomial>();\n \t\tpolynomial_ = true;\n \t\tLOG(Lsc, Debug) << \"Using polynomial Lsc\";\n \t} else {\ndiff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex 30af8d970a12..7de6ee70e7a0 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -78,6 +78,9 @@ void Interpolator<lsc::Components>::\n * \\var LscDescriptor::sensorSize\n * \\brief The physical sensor size. This is the largest frame size used to\n * generate the lsc table. Only used by the polynomial lsc algorithm\n+ *\n+ * \\todo: Most likely the reference frame should be native_size.\n+ * Let's wait how the internal discussions progress.\n */\n \n /**\ndiff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex 0550229b5152..013a4469546e 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -123,13 +123,6 @@ void Polynomial::setReferenceImageSize(const Size &size)\n * \\sa LscImplementation\n */\n \n-/**\n- * \\fn LscPolynomial::LscPolynomial\n- * \\param[in] sensorSize The physical sensor size\n- *\n- * Construct an LscPolynomial\n- */\n-\n /**\n * \\brief Parse polynomial lsc data\n * \\param[in] sets The tuning file content\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex 2a26db499d68..6d19e46a50b7 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -57,11 +57,6 @@ private:\n \tusing PolynomialComponentsMap = std::map<unsigned int, PolynomialComponents>;\n \n public:\n-\tLscPolynomial(const Size &sensorSize)\n-\t\t: sensorSize_(sensorSize)\n-\t{\n-\t}\n-\n \tint parseLscData(const ValueNode &sets,\n \t\t\t const LscDescriptor &descriptor) override;\n \n@@ -75,7 +70,6 @@ private:\n \t\t\t\t\t Span<const double> yPositions,\n \t\t\t\t\t const Rectangle &cropRectangle);\n \tPolynomialComponentsMap lscData_;\n-\tSize sensorSize_;\n };\n \n } /* namespace ipa */\n", "prefixes": [ "v3", "27/35" ] }